The patch bumps min version of tox to 3.18.0 python in order to
replace tox's whitelist_externals by allowlist_externals option:
https://github.com/tox-dev/tox/blob/master/docs/changelog.rst#v3180-2020-07-23
The patch also sets ubuntu-focal nodeset for the docs job as newer
ubuntu (with newer tox available) is required.
Change-Id: I5b32e7f65710199601a6856dba86584390eb92b7
The .pdf documentation could not be build without errors because the
source code of the documentation contained errors. In addition, there
were other problems:
- The readme section of the documentation was in .md format
instead of .rst format. As a result, the created documentation did
not look good.
- The .html documentation used deprecated oslosphinx theme instead
of openstackdocstheme.
This patch fixes the above-mentioned problems and makes sure that
the documentation is generated properly.
Also, this patch updates nodejs4-docs to nodejs10-docs because the
nodejs4-docs was using deprecated nodejs-npm-run-docs job [1].
[1] https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/757101
Task: 35462
Depends-On: I738b833109e4caeb58bb391d79d6e63284462bd8
Change-Id: I921b15edda433c3e47456488da6d2bda07c34262
This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.
This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.
This update should result in no functional change.
For more information see the thread at
http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html
Change-Id: I1c9142277b805d9c269a63d324f0c8d7edb7d84c
This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.
Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.
Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Depends-On: https://review.openstack.org/601057
Change-Id: If703f0dcf1cb58f3bbd28bd1432ff19e68c21aad
Story: #2002586
Task: #24327
readme.rst includes a README.rst file that does not exist - we have a
README.md but cannot include it here. Thus remove the readme.rst file.
Change-Id: I8a30c6ed4609658b2b8d3caa945cdeb0a678b68c
This rule was adopted in js-openstack-lib and I propose
we adopt it here as well. Whether we enforce a space or
no space, so long as it is consistent.
Change-Id: I5881b46ea16112729f2327484e56bcb138e0c386
This upgrades the eslint version to 3.0.0, removes zombie rules, and
ensures all new rules are disabled.
Change-Id: I8ea98aeda7a42ed0e140164c0e9d5e28d54794b8
This commit adds an additional config, which should be used in
ES2015-based projects. It's available by adding
`extends: openstack/es2015` to project's .eslintrc file.
Change-Id: I5d54cdceb206db7a52ee396eafc513b290e38f86
OpenStack starts to support ES6, so the config has been updated
with instructions how to enable ES6 support.
"ecmaFeatures" were moved under "parserOptions" as it's required
by ESLint 2.x, all ES6-related flags were removed as they're
enabled using env.es6.
Change-Id: I5531534e2ab12ece0859816679aa19deb974957e
Arrow functions can omit parentheses when they have exactly one
parameter. In all other cases the parameter(s) must be wrapped
in parentheses. This rule enforces the consistent use of
parentheses in arrow functions.
http://eslint.org/docs/rules/arrow-parens
Change-Id: I40fca3fc2ecaf99ebb8ab9c40e7eaed8e78bdbd7
In the constructor of derived classes, if this/super are used
before super() calls, it raises a reference error.
http://eslint.org/docs/rules/no-this-before-super
Change-Id: I7cd9f2e802dbc1b3e9e91ca708366cb2b461e7fb
If there are declarations of the same name in class members,
the last declaration overwrites other declarations silently.
It can cause unexpected behaviors.
http://eslint.org/docs/rules/no-dupe-class-members
Change-Id: I0279dd2f818ea893f26e6230ac7a7648dbae5520
This rule checks usage of super() calls in class constructors.
Constructors of derived classes must call super().
Constructors of non derived classes must not call super().
If this is not observed, the javascript engine will raise
a runtime error.
http://eslint.org/docs/rules/constructor-super
Change-Id: Ic5fd761584770bdd2ae1a361b85ccb0a0167fce3
Require spaces around arrow in arrow functions, like they are
required around keywords if, else, in, do, etc.
http://eslint.org/docs/rules/arrow-spacing
Change-Id: I1b8f2b4ed3619f0e8565a79ddcd439fa7851b5ad
This enforces a space before and after keywords such as else, if,
switch, case, catch, try, and import.
http://eslint.org/docs/rules/keyword-spacing
Change-Id: I71a9b0d3527ba7612b9af75a3a0e14eaf8b3665e
This rule ensures that parameters used to declare a loop, are modified
within the loop. If they are not, it is likely that this is an error.
Example:
while(foo) {
doSomething(foo);
}
http://eslint.org/docs/rules/no-unmodified-loop-condition
Change-Id: I8f5a0b2b1f48a9f93e0946c76c497e86a199f01e