summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-12-06Merge "Remove broken readme.rst"HEADmasterZuul
2018-09-09import zuul job settings from project-configDoug Hellmann
This is a mechanically generated patch to complete step 1 of moving the zuul job settings out of project-config and into each project repository. Because there will be a separate patch on each branch, the branch specifiers for branch-specific jobs have been removed. Because this patch is generated by a script, there may be some cosmetic changes to the layout of the YAML file(s) as the contents are normalized. See the python3-first goal document for details: https://governance.openstack.org/tc/goals/stein/python3-first.html Depends-On: https://review.openstack.org/601057 Change-Id: If703f0dcf1cb58f3bbd28bd1432ff19e68c21aad Story: #2002586 Task: #24327 Notes (review): Code-Review+1: Andreas Jaeger <jaegerandi@gmail.com> Code-Review+2: Ghanshyam Mann <gmann@ghanshyammann.com> Workflow+1: Ghanshyam Mann <gmann@ghanshyammann.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 10 Sep 2018 10:38:05 +0000 Reviewed-on: https://review.openstack.org/601000 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2017-11-09Remove broken readme.rstAndreas Jaeger
readme.rst includes a README.rst file that does not exist - we have a README.md but cannot include it here. Thus remove the readme.rst file. Change-Id: I8a30c6ed4609658b2b8d3caa945cdeb0a678b68c Notes (review): Code-Review+1: Sean McGinnis <sean.mcginnis@gmail.com> Code-Review+2: Ghanshyam Mann <gmann@ghanshyammann.com> Workflow+1: Ghanshyam Mann <gmann@ghanshyammann.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 06 Dec 2018 12:51:00 +0000 Reviewed-on: https://review.openstack.org/518793 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2017-01-30Merge "Fix the typo of release doc"Jenkins
2016-11-02Merge "Disallow space between a function & opening paren"Jenkins
2016-11-02Copy .gitignore from js-generator-openstack templateYujun Zhang
Change-Id: I83397a517a188240a9f8af17951522d287d81c5e Notes (review): Code-Review+1: Dong Ma <winterma.dong@gmail.com> Code-Review+2: Michael Krotscheck <krotscheck@gmail.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 02 Nov 2016 16:34:34 +0000 Reviewed-on: https://review.openstack.org/389610 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-10-27Disallow space between a function & opening parenmsmol
This rule was adopted in js-openstack-lib and I propose we adopt it here as well. Whether we enforce a space or no space, so long as it is consistent. Change-Id: I5881b46ea16112729f2327484e56bcb138e0c386 Notes (review): Code-Review+1: Vitaly Kramskikh <vkramskikh@mirantis.com> Code-Review+1: Corentin Ardeois <corentin.ardeois@gmail.com> Code-Review+1: Dong Ma <winterma.dong@gmail.com> Code-Review+1: Yujun Zhang <zhang.yujunz@zte.com.cn> Code-Review+2: Michael Krotscheck <krotscheck@gmail.com> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 02 Nov 2016 16:35:28 +0000 Reviewed-on: https://review.openstack.org/381929 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-10-24Fix the typo of release docDong Ma
Change-Id: Ieb4ddb0ffcd988ae87786b4e85efb4308cc101b3 Notes (review): Code-Review+2: Michael Krotscheck <krotscheck@gmail.com> Code-Review+2: Matthew Treinish <mtreinish@kortar.org> Workflow+1: Matthew Treinish <mtreinish@kortar.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Mon, 30 Jan 2017 14:31:34 +0000 Reviewed-on: https://review.openstack.org/385718 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-10-21Fix the gate npm docs failureDong Ma
This commit try to fix the gate nodejs4 npm docs failure by adding docs script. Change-Id: I186d3ec7fc826ea767c57bad5cf3e2f5676c19bb Notes (review): Code-Review+1: Vitaly Kramskikh <vkramskikh@mirantis.com> Code-Review+1: Mitchell Smolash <mitch@smolash.com> Code-Review+1: Corentin Ardeois <corentin.ardeois@gmail.com> Code-Review+1: Yujun Zhang <zhang.yujunz@zte.com.cn> Code-Review+2: Michael Krotscheck <krotscheck@gmail.com> Code-Review+2: Matthew Treinish <mtreinish@kortar.org> Workflow+1: Matthew Treinish <mtreinish@kortar.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 27 Oct 2016 13:39:11 +0000 Reviewed-on: https://review.openstack.org/385777 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-08-17Added documentation for eslint-config-openstackElizabeth Elwell
Added documentation to include release guidelines. Change-Id: I2c2cd929283868dac415f986f541d0ec5741ef17 Notes (review): Code-Review+2: Michael Krotscheck <krotscheck@gmail.com> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Fri, 02 Sep 2016 14:02:43 +0000 Reviewed-on: https://review.openstack.org/356473 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-08-054.0.14.0.1Elizabeth Elwell
Change-Id: I2aa51a40562dbfebd5fbd6baad801b8542498706 Notes (review): Code-Review+2: Michael Krotscheck <krotscheck@gmail.com> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Fri, 05 Aug 2016 22:47:29 +0000 Reviewed-on: https://review.openstack.org/351913 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-08-05Upgraded eslint to 3.0.0Elizabeth Elwell
This upgrades the eslint version to 3.0.0, removes zombie rules, and ensures all new rules are disabled. Change-Id: I8ea98aeda7a42ed0e140164c0e9d5e28d54794b8 Notes (review): Code-Review+1: Mitchell Smolash <mitch@smolash.com> Code-Review+2: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Zara <zara.zaimeche@codethink.co.uk> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Fri, 05 Aug 2016 15:52:31 +0000 Reviewed-on: https://review.openstack.org/350530 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-07-29Added config with ES2015-only rulesVitaly Kramskikh
This commit adds an additional config, which should be used in ES2015-based projects. It's available by adding `extends: openstack/es2015` to project's .eslintrc file. Change-Id: I5d54cdceb206db7a52ee396eafc513b290e38f86 Notes (review): Code-Review+2: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Julia Aranovich <jkirnosova@mirantis.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Tue, 02 Aug 2016 09:57:14 +0000 Reviewed-on: https://review.openstack.org/346875 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-07-21Merge "Enable no-unmodified-loop-condition"Jenkins
2016-06-10Merge "Enable keyword-spacing"Jenkins
2016-06-022.0.02.0.0Michael Krotscheck
Change-Id: Ief3454d4f1cd5a56707b3a5151ac48b894b59cfe Notes (review): Code-Review+2: Michael Krotscheck <krotscheck@gmail.com> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 02 Jun 2016 18:14:06 +0000 Reviewed-on: https://review.openstack.org/324664 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-06-02Merge "Enable arrow-parens"Jenkins
2016-06-02Merge "Enable no-this-before-super"Jenkins
2016-06-02Merge "Enable constructor-super"Jenkins
2016-06-02Merge "Enable arrow-spacing"Jenkins
2016-06-02Merge "Enable no-const-assign"Jenkins
2016-06-02Merge "Enable no-class-assign"Jenkins
2016-06-02Merge "Enable no-dupe-class-members"Jenkins
2016-05-12Update descriptions of ES6-related optionsVitaly Kramskikh
OpenStack starts to support ES6, so the config has been updated with instructions how to enable ES6 support. "ecmaFeatures" were moved under "parserOptions" as it's required by ESLint 2.x, all ES6-related flags were removed as they're enabled using env.es6. Change-Id: I5531534e2ab12ece0859816679aa19deb974957e Notes (review): Code-Review+1: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Vitaly Kramskikh <vkramskikh@mirantis.com> Code-Review+1: Julia Aranovich <jkirnosova@mirantis.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+1: Kate Pimenova <kpimenova@mirantis.com> Code-Review+1: Nick Bogdanov <nbogdanov@mirantis.com> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 18 May 2016 15:29:33 +0000 Reviewed-on: https://review.openstack.org/315177 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-05-12Enable arrow-parensVitaly Kramskikh
Arrow functions can omit parentheses when they have exactly one parameter. In all other cases the parameter(s) must be wrapped in parentheses. This rule enforces the consistent use of parentheses in arrow functions. http://eslint.org/docs/rules/arrow-parens Change-Id: I40fca3fc2ecaf99ebb8ab9c40e7eaed8e78bdbd7 Notes (review): Code-Review+1: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Julia Aranovich <jkirnosova@mirantis.com> Code-Review+1: Kate Pimenova <kpimenova@mirantis.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 02 Jun 2016 16:08:51 +0000 Reviewed-on: https://review.openstack.org/315641 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-05-12Enable no-this-before-superVitaly Kramskikh
In the constructor of derived classes, if this/super are used before super() calls, it raises a reference error. http://eslint.org/docs/rules/no-this-before-super Change-Id: I7cd9f2e802dbc1b3e9e91ca708366cb2b461e7fb Notes (review): Code-Review+1: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Julia Aranovich <jkirnosova@mirantis.com> Code-Review+1: Kate Pimenova <kpimenova@mirantis.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 02 Jun 2016 16:08:35 +0000 Reviewed-on: https://review.openstack.org/315633 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-05-12Enable no-dupe-class-membersVitaly Kramskikh
If there are declarations of the same name in class members, the last declaration overwrites other declarations silently. It can cause unexpected behaviors. http://eslint.org/docs/rules/no-dupe-class-members Change-Id: I0279dd2f818ea893f26e6230ac7a7648dbae5520 Notes (review): Code-Review+1: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Julia Aranovich <jkirnosova@mirantis.com> Code-Review+1: Kate Pimenova <kpimenova@mirantis.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 02 Jun 2016 15:11:09 +0000 Reviewed-on: https://review.openstack.org/315624 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-05-12Enable no-const-assignVitaly Kramskikh
Attempts to modify a constant cause runtime errors http://eslint.org/docs/rules/no-const-assign Change-Id: I89c0426c601f834fa91ea8315ca5b8ba0600c181 Notes (review): Code-Review+1: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Julia Aranovich <jkirnosova@mirantis.com> Code-Review+1: Kate Pimenova <kpimenova@mirantis.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 02 Jun 2016 15:13:28 +0000 Reviewed-on: https://review.openstack.org/315600 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-05-12Enable no-class-assignVitaly Kramskikh
Usually it makes no sense to reassign class variables http://eslint.org/docs/rules/no-class-assign Change-Id: Id556cd4e427c8772aed0e97aa68fa742f8692b7d Notes (review): Code-Review+1: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Julia Aranovich <jkirnosova@mirantis.com> Code-Review+1: Kate Pimenova <kpimenova@mirantis.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 02 Jun 2016 15:11:16 +0000 Reviewed-on: https://review.openstack.org/315583 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-05-11Enable constructor-superVitaly Kramskikh
This rule checks usage of super() calls in class constructors. Constructors of derived classes must call super(). Constructors of non derived classes must not call super(). If this is not observed, the javascript engine will raise a runtime error. http://eslint.org/docs/rules/constructor-super Change-Id: Ic5fd761584770bdd2ae1a361b85ccb0a0167fce3 Notes (review): Code-Review+1: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Julia Aranovich <jkirnosova@mirantis.com> Code-Review+1: Kate Pimenova <kpimenova@mirantis.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 02 Jun 2016 16:08:29 +0000 Reviewed-on: https://review.openstack.org/315183 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-05-11Enable arrow-spacingVitaly Kramskikh
Require spaces around arrow in arrow functions, like they are required around keywords if, else, in, do, etc. http://eslint.org/docs/rules/arrow-spacing Change-Id: I1b8f2b4ed3619f0e8565a79ddcd439fa7851b5ad Notes (review): Code-Review+1: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Julia Aranovich <jkirnosova@mirantis.com> Code-Review+1: Kate Pimenova <kpimenova@mirantis.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 02 Jun 2016 16:08:19 +0000 Reviewed-on: https://review.openstack.org/315181 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-05-05Merge "Enable no-self-assign"Jenkins
2016-05-04Merge "Clarified wording in governance"Jenkins
2016-05-04Merge "Added policy for aging patches"Jenkins
2016-05-04Merge "Added policy guidelines for policy updates"Jenkins
2016-05-04Enable keyword-spacingMichael Krotscheck
This enforces a space before and after keywords such as else, if, switch, case, catch, try, and import. http://eslint.org/docs/rules/keyword-spacing Change-Id: I71a9b0d3527ba7612b9af75a3a0e14eaf8b3665e Notes (review): Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Code-Review+1: Cindy Lu <clu@us.ibm.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+1: Vitaly Kramskikh <vkramskikh@mirantis.com> Code-Review+1: Zara <zara.zaimeche@codethink.co.uk> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Fri, 10 Jun 2016 14:05:22 +0000 Reviewed-on: https://review.openstack.org/293500 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-05-04Enable no-unmodified-loop-conditionMichael Krotscheck
This rule ensures that parameters used to declare a loop, are modified within the loop. If they are not, it is likely that this is an error. Example: while(foo) { doSomething(foo); } http://eslint.org/docs/rules/no-unmodified-loop-condition Change-Id: I8f5a0b2b1f48a9f93e0946c76c497e86a199f01e Notes (review): Code-Review+1: Frank White <francoblanco.openstack@gmail.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+1: Vitaly Kramskikh <vkramskikh@mirantis.com> Code-Review+1: Dong Ma <winterma.dong@gmail.com> Code-Review+1: Zara <zara.zaimeche@codethink.co.uk> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 21 Jul 2016 16:21:30 +0000 Reviewed-on: https://review.openstack.org/293499 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-05-04Enable no-self-assignMichael Krotscheck
This will throw an error on all variants of a = a; http://eslint.org/docs/rules/no-self-assign Change-Id: Iaddc5e106da307e9ead62d2a37876805aaa86746 Notes (review): Code-Review+1: Cindy Lu <clu@us.ibm.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Code-Review+1: Frank White <francoblanco.openstack@gmail.com> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 05 May 2016 15:06:20 +0000 Reviewed-on: https://review.openstack.org/293490 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-04-27Merge "Added approval policy for library upgrades"Jenkins
2016-03-16Merge "Upgraded eslint to 2.4.0"Jenkins
2016-03-16Merge "Upgraded eslint to 1.10.3"Jenkins
2016-03-16Merge "Enable "no-empty-pattern""Jenkins
2016-03-16Merge "Enable "no-case-declarations""Jenkins
2016-03-16Merge "Upgraded eslint version"Jenkins
2016-03-16Upgraded eslint to 2.4.0Michael Krotscheck
This upgrades the eslint version to 2.4.0, removes zombie rules, and ensures that all new rules are disabled. Change-Id: I6249663f8e226c5fa2739481b4c79625f94c7eb5 Notes (review): Code-Review+2: Cindy Lu <clu@us.ibm.com> Workflow+1: Cindy Lu <clu@us.ibm.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 16 Mar 2016 18:28:10 +0000 Reviewed-on: https://review.openstack.org/293468 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-03-02Merge "Documented project governance"Jenkins
2016-03-02Merge "Enable builtinGlobals for no-redeclare"Jenkins
2016-03-01Clarified wording in governanceMichael Krotscheck
This patch clarifies the wording on a few governance statements. First, the intent of the rule approval policy is to encourage more pairs of eyeballs - thus the wording was changed from +5 to 'five positive votes'. Secondly - library upgrades should _never_ change the existing rule set, because they already impose changes due to bugfixes in the rules themselves. Change-Id: I4f2765bcd04cb50da94ac121259c0cc8244bda19 Notes (review): Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Code-Review+1: Itxaka Serrano Garcia <itxaka@redhat.com> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 04 May 2016 19:54:32 +0000 Reviewed-on: https://review.openstack.org/286740 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-02-29Added policy for aging patchesMichael Krotscheck
This proposes an 'abandon after one month of inactivity' rule for extant patches on this project. It is intended to keep the list of outstanding patches small and manageable. Change-Id: Ie12eb568b61995ef77570774513806b7da0f964d Notes (review): Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Code-Review+1: David Lyle <dklyle0@gmail.com> Code-Review+1: Timur Sufiev <tsufiev@mirantis.com> Code-Review+1: Tyr Johanson <tyr@hpe.com> Code-Review+1: Itxaka Serrano Garcia <itxaka@redhat.com> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 04 May 2016 19:54:27 +0000 Reviewed-on: https://review.openstack.org/265942 Project: openstack/eslint-config-openstack Branch: refs/heads/master
2016-02-29Added policy guidelines for policy updatesMichael Krotscheck
Updates to project governance must require +2 from all direct cores on the project. QA core votes are optional. Change-Id: I2ef352bd7fda7199297fdbe8045cd74f2414f158 Notes (review): Code-Review+1: Timur Sufiev <tsufiev@mirantis.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Code-Review+1: Itxaka Serrano Garcia <itxaka@redhat.com> Code-Review+1: Rob Cresswell <robert.cresswell@outlook.com> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 04 May 2016 19:54:20 +0000 Reviewed-on: https://review.openstack.org/265937 Project: openstack/eslint-config-openstack Branch: refs/heads/master