openstack
/
freezer
Code Issues Proposed changes

Add ftp get file success unit test 

The patch add ftp get file ok unit test

Change-Id: I72a0e316092489a6c8a8e6d208324a382330af89
This commit is contained in:
gecong1973 2018-12-07 01:05:50 -08:00
parent b8f382422c
commit 6df8069992
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
freezer/tests/unit/storages/test_ftp.py
View File

@ -211,6 +211,24 @@ class FtpStorageTestCase(unittest.TestCase):
self.assertTrue(mock_ftp.storbinary.called)
self.delete_ftp_test_file()
@patch('ftplib.FTP')
def test_getfile_ok_FtpStorage(self, mock_ftp_constructor):
mock_ftp = mock_ftp_constructor.return_value
ftpobj = ftp.FtpStorage(
storage_path=self.ftp_opt.ftp_storage_path,
remote_pwd=self.ftp_opt.ftp_remote_pwd,
remote_username=self.ftp_opt.ftp_remote_username,
remote_ip=self.ftp_opt.ftp_remote_ip,
port=self.ftp_opt.ftp_port,
max_segment_size=self.ftp_opt.ftp_max_segment_size)
self.create_ftp_test_file()
topath = self.ftp_test_file_dir + "/" + self.ftp_test_file_name
frompath = '/home/from'
ftpobj.get_file(frompath, topath)
self.assertTrue(mock_ftp.pwd.called)
self.assertTrue(mock_ftp.retrbinary.called)
self.delete_ftp_test_file()
class FtpsStorageTestCase(unittest.TestCase):