Merge "Delete the unnecessary empty mode check"

This commit is contained in:
Zuul 2018-09-07 05:34:44 +00:00 committed by Gerrit Code Review
commit 9881cbbcc2
2 changed files with 1 additions and 9 deletions

View File

@ -152,8 +152,7 @@ class BackupJob(Job):
LOG.error('Error while sync exec: {0}'.format(err))
except Exception as error:
LOG.error('Error while sync exec: {0}'.format(error))
if not self.conf.mode:
raise ValueError("Empty mode")
mod_name = 'freezer.mode.{0}.{1}'.format(
self.conf.mode, self.conf.mode.capitalize() + 'Mode')
app_mode = importutils.import_object(mod_name, self.conf)

View File

@ -60,13 +60,6 @@ class TestBackupJob(TestJob):
job = jobs.BackupJob(backup_opt, backup_opt.storage)
self.assertRaises(Exception, job.execute) # noqa
def test_execute_raise(self):
backup_opt = commons.BackupOpt1()
backup_opt.no_incremental = False
backup_opt.mode = None
job = jobs.BackupJob(backup_opt, backup_opt.storage)
self.assertRaises(ValueError, job.execute) # noqa
class TestAdminJob(TestJob):
def setUp(self):