Commit Graph

8 Commits

Author SHA1 Message Date
caihui e5f36293e5 Fix CI error
1. no_voting for lower-constraints CI
2.pep8 create: /home/zuul/src/opendev.org/openstack/freezer/.tox/pep8
pep8 installdeps: -c/home/zuul/src/opendev.org/openstack/requirements/upper-constraints.txt, -r/home/zuul/src/opendev.org/openstack/freezer/test-requirements.txt
ERROR: invocation failed (exit code 1), logfile: /home/zuul/src/opendev.org/openstack/freezer/.tox/pep8/log/pep8-1.log
================================== log start ===================================
Looking in indexes: https://mirror.bhs1.ovh.opendev.org/pypi/simple, https://mirror.bhs1.ovh.opendev.org/wheel/ubuntu-20.04-x86_64
Collecting astroid==2.1.0
  Downloading 8809bc008b36396c0cff6279841e8a/astroid-2.1.0-py3-none-any.whl (176 kB)
Collecting pylint==2.3.1
  Downloading b3f73f4ac00277237721ef1c151f0d/pylint-2.3.1-py3-none-any.whl (765 kB)
INFO: pip is looking at multiple versions of <Python from Requires-Python> to determine which version is compatible with other requirements. This could take a while.
INFO: pip is looking at multiple versions of astroid to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install -r /home/zuul/src/opendev.org/openstack/freezer/test-requirements.txt (line 23) and astroid==2.1.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested astroid==2.1.0
    pylint 2.3.1 depends on astroid<3 and >=2.2.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies
WARNING: You are using pip version 20.3.3; however, version 21.0 is available.
You should consider upgrading via the '/home/zuul/src/opendev.org/openstack/freezer/.tox/pep8/bin/python -m pip install --upgrade pip' command.
================================ log end ===============================

Change-Id: I898d03d716ebc6c6285c4589cd30f7875b0c51d2
2021-01-28 21:36:03 -08:00
caihui e5a4d0cf75 Upgrade pylint to a new version that works with python3.7
1.The pylint & astroid verison should be specified for python3.7
pylint is upgrade 2.3.1
astroid is upgrade 2.2.0

2.Some rules are added to the ignore list in .pylintrc

Change-Id: Id5f91aa5dd22b1364fe35143b6c96e834284d252
2019-10-30 22:41:02 -04:00
Doug Hellmann 3e1e0bd7ed update pylint to 1.9.2
The older version of pylint being used does not work correctly under
python 3. In order to be able to update the pylint job to run under
python 3, we need to update the tool.

This patch updates to the latest version at this time. It also updates
and pins astroid, which was previously capped. Using a pin instead of
a cap should let us avoid issues with new releases while being
specific about which version to actually use.

The import-error linter rule is disabled because it appears in
Windows-related code that looks for modules we don't expect to be able
to find on the CI system under Linux.

The non-iterator-returned rule is disabled because it is erroring on a
class that doesn't make sense (freezer.utils.utils.ReSizeStream does
appear to honor the iterator protocol). Further investigation is
probably warranted on this one.

The public entry point for multiprocessing.SimpleQueue is the
top-level multiprocessing module, not multiprocessing.queues. The
linter correctly caught this error because the ctx argument was not
being passed to the class. The fix is to use the top-level entry point
to access the class.

basestring is no longer defined under python 3. The fix is to use
six.string_types, which correctly sets the alias to str or
basestring. By using the library, we can avoid having to tell the
linter to ignore the local customization.

The linter also caught a base raise, without an exception specified
and not in the context of an exception handler. I added an exception
using the pattern from the one on an earlier line.

Change-Id: I349de35c9ee52e2946e661f777308444b61ba4e0
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Co-Authored-By: Nguyen Hai <nguyentrihai93@gmail.com>
2018-09-03 13:10:55 +00:00
Saad Zaher f609f3b9ac Fix pylint checks
Change-Id: I784ee29952fc4cc1f605b60023a0c7ad30aef2e2
Partial-Bug: #1696455
2017-06-07 16:15:01 +01:00
Jenkins 550d088f24 Merge "Fix typos" 2016-05-04 10:41:37 +00:00
Deklan Dieterly 9f8ec0b9b9 Add More Freezer Tempest Tests
Continue to develop integration tests
that get run with Tempest tests.

Continue to get more test coverage.

Change-Id: I4ad40d84305eca0204ecdb72ee559f95837b1218
2016-04-07 20:08:42 -06:00
daiki kato ecfa4f6f13 Fix typos
This patch fixes several typos.

TrivialFix

Change-Id: Id5d5205f9234b1c8c8df6e865062261fcf960e8c
2016-03-25 17:04:13 +09:00
Fausto Marzi eaf8d10599 Added pylint checks. Fixed import error during python-novaclient import.
Finally pylint checks are executed now during the build.
Currently, as pylint is just enabled, checks for
Warnings, Refactor, Convention are disabled.

Closes bug: 1465063

Change-Id: I1a5447d7a7c2ec717e21aae67d26b0586edad7a5
2015-06-14 21:22:21 +00:00