puppet-lint installed from the master branch breaks the CI. This change
uses the official gem instead because the latest version now includes
the bug fix that wasn't released before.
Change-Id: I646176e30494cf1e8fac97c6ecebb3899ade8107
The latest version of puppetlabs_spec_helper (1.2.0) depends on
rubocop-rspec which itself requires at least Ruby 2.2.
Change-Id: Ica4b71296912a66a98b223c002d1e8bdd04111d6
This change adds syntax checking and lint tests for the Puppet
manifests locates in deployment_scripts/puppet/manifests.
It also fixes a Puppet lint problem in base.pp as well as illegal key
assignments that aren't allowed with Puppet 4.x.
Change-Id: I3a6913773d3c3952e882db5644b8cc2289cee8fa