Pylint: fix trivial issues 2

Change-Id: Id29cb8831714fd96960f85c29d866084a5565f5c
fix: invalid import order, double import, relative import, no super call, instance defined outside of init, incorrect __all__ variable
Related-bug: #1556791

fuelweb_test/helpers/checkers.py

@@ -15,11 +15,16 @@ import hashlib
 import json
 import os
 import re
+from time import sleep
 import urllib2
 
 from devops.error import TimeoutError
 from devops.helpers.helpers import _wait
 from devops.helpers.helpers import wait
+from netaddr import IPAddress
+from netaddr import IPNetwork
+from proboscis.asserts import assert_equal
+from proboscis.asserts import assert_true
 import yaml
 
 from fuelweb_test import logger
@@ -33,13 +38,6 @@ from fuelweb_test.settings import OPENSTACK_RELEASE_UBUNTU
 from fuelweb_test.settings import POOLS
 from fuelweb_test.settings import PUBLIC_TEST_IP
 
-from netaddr import IPAddress
-from netaddr import IPNetwork
-from proboscis.asserts import assert_equal
-from proboscis.asserts import assert_true
-
-from time import sleep
-
 
 ssh_manager = SSHManager()
 

fuelweb_test/helpers/decorators.py

@@ -17,26 +17,26 @@ import inspect
 import json
 import os
 from subprocess import call
-import requests
 import sys
 import time
 import traceback
 from urlparse import urlparse
 
+from proboscis import SkipTest
+from proboscis.asserts import assert_equal
+from proboscis.asserts import assert_true
+import requests
+
+from fuelweb_test import logger
+from fuelweb_test import settings
+from fuelweb_test.settings import MASTER_IS_CENTOS7
 from fuelweb_test.helpers.checkers import check_action_logs
 from fuelweb_test.helpers.checkers import check_repo_managment
 from fuelweb_test.helpers.checkers import check_stats_on_collector
 from fuelweb_test.helpers.checkers import check_stats_private_info
 from fuelweb_test.helpers.checkers import count_stats_on_collector
-from proboscis import SkipTest
-from proboscis.asserts import assert_equal
-from proboscis.asserts import assert_true
-
-from fuelweb_test import logger
-from fuelweb_test import settings
-from fuelweb_test.helpers.ssh_manager import SSHManager
-from fuelweb_test.settings import MASTER_IS_CENTOS7
 from fuelweb_test.helpers.regenerate_repo import CustomRepo
+from fuelweb_test.helpers.ssh_manager import SSHManager
 from fuelweb_test.helpers.utils import get_current_env
 from fuelweb_test.helpers.utils import pull_out_logs_via_ssh
 from fuelweb_test.helpers.utils import store_astute_yaml
@@ -512,6 +512,7 @@ def check_repos_management(func):
 # Python.six is less smart
 
 
+# pylint: disable=no-member
 def __getcallargs(func, *positional, **named):
     if sys.version_info.major < 3:
         return inspect.getcallargs(func, *positional, **named)
@@ -541,6 +542,7 @@ def __get_arg_names(func):
         return [arg for arg in inspect.getargspec(func=func).args]
     else:
         return list(inspect.signature(obj=func).parameters.keys())
+# pylint:enable=no-member
 
 
 def __call_in_context(func, context_args):

fuelweb_test/helpers/exceptions.py

@@ -27,6 +27,7 @@ class UnexpectedExitCode(Exception):
         self.cmd = command
         self.stdout = stdout
         self.stderr = stderr
+        super(UnexpectedExitCode, self).__init__()
 
     def __str__(self):
         message = "Command '{cmd:s}' returned unexpected exit code {code:d}," \

fuelweb_test/helpers/gerrit/gerrit_info_provider.py

@@ -17,8 +17,8 @@ from collections import namedtuple
 import os
 import re
 from fuelweb_test import settings
-from gerrit_client import GerritClient
-import utils
+from fuelweb_test.helpers.gerrit.gerrit_client import GerritClient
+from fuelweb_test.helpers.gerrit import utils
 
 
 class FuelLibraryModulesProvider(object):

fuelweb_test/helpers/ironic_actions.py

@@ -12,11 +12,12 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
+import json
+
 from devops.helpers.helpers import tcp_ping
 from devops.helpers.helpers import wait
 
 from fuelweb_test.helpers import os_actions
-import json
 
 
 class IronicActions(os_actions.OpenStackActions):

fuelweb_test/helpers/os_actions.py

@@ -12,13 +12,13 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-import paramiko
-from proboscis import asserts
 import random
 import time
 
 from devops.error import TimeoutError
 from devops.helpers import helpers
+import paramiko
+from proboscis import asserts
 
 from fuelweb_test.helpers import common
 from fuelweb_test import logger

fuelweb_test/helpers/patching.py

@@ -16,7 +16,6 @@ import os
 import re
 import sys
 import traceback
-import yaml
 import zlib
 from urllib2 import urlopen
 from urlparse import urlparse
@@ -28,6 +27,7 @@ from proboscis.asserts import assert_equal
 from proboscis.asserts import assert_is_not_none
 from proboscis.asserts import assert_not_equal
 from proboscis.asserts import assert_true
+import yaml
 
 from fuelweb_test import logger
 from fuelweb_test import settings

fuelweb_test/helpers/rally.py

@@ -15,10 +15,10 @@
 import json
 import os
 
+from devops.helpers.helpers import wait
 from proboscis.asserts import assert_equal
 from proboscis.asserts import assert_true
 
-from devops.helpers.helpers import wait
 from fuelweb_test import logger
 
 

fuelweb_test/helpers/regenerate_repo.py

@@ -16,10 +16,10 @@ import traceback
 import os
 import re
 import urllib2
+from xml.etree import ElementTree
 import zlib
 
 from proboscis.asserts import assert_equal
-from xml.etree import ElementTree
 
 from fuelweb_test import logger
 from fuelweb_test import settings

fuelweb_test/helpers/security.py

@@ -12,9 +12,9 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
+from random import randrange
 
 from proboscis.asserts import assert_equal
-from random import randrange
 
 from fuelweb_test import logwrap
 from fuelweb_test import logger

fuelweb_test/helpers/ssh_manager.py

@@ -12,17 +12,17 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
+import json
 import os
 import posixpath
 import re
 import traceback
-import json
 
-import six
-
-from paramiko import RSAKey
 from devops.helpers.helpers import wait
 from devops.models.node import SSHClient
+from paramiko import RSAKey
+import six
+
 from fuelweb_test import logger
 from fuelweb_test.helpers.metaclasses import SingletonMeta
 from fuelweb_test.helpers.exceptions import UnexpectedExitCode

fuelweb_test/helpers/utils.py

@@ -13,21 +13,23 @@
 #    under the License.
 
 import ConfigParser
+# pylint: disable=no-name-in-module
 from distutils import version
+# pylint: enable=no-name-in-module
 import inspect
 import json
-import time
-import traceback
-import yaml
 import os
 import posixpath
 import re
 import signal
-import netaddr
+import time
+import traceback
 
+import netaddr
 from proboscis import asserts
 from proboscis.asserts import assert_true
 from proboscis.asserts import assert_equal
+import yaml
 
 from fuelweb_test import logger
 from fuelweb_test import logwrap
@@ -251,6 +253,9 @@ class TimeStat(object):
         else:
             self.name = 'timestat'
         self.is_uniq = is_uniq
+        self.begin_time = 0
+        self.end_time = 0
+        self.total_time = 0
 
     def __enter__(self):
         self.begin_time = time.time()

fuelweb_test/models/fuel_web_client.py

@@ -15,10 +15,6 @@
 import re
 import time
 import traceback
-
-import yaml
-import netaddr
-
 from urllib2 import HTTPError
 
 from devops.error import DevopsCalledProcessError
@@ -26,13 +22,14 @@ from devops.error import TimeoutError
 from devops.helpers.helpers import _wait
 from devops.helpers.helpers import wait
 from devops.models.node import Node
-
+import netaddr
 from proboscis.asserts import assert_equal
 from proboscis.asserts import assert_false
 from proboscis.asserts import assert_is_not_none
 from proboscis.asserts import assert_not_equal
 from proboscis.asserts import assert_raises
 from proboscis.asserts import assert_true
+import yaml
 
 from fuelweb_test import logger
 from fuelweb_test import logwrap

fuelweb_test/testrail/__init__.py

@@ -11,8 +11,10 @@
 #    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 #    License for the specific language governing permissions and limitations
 #    under the License.
+
 import os
-from settings import LOGS_DIR
+
+from fuelweb_test.testrail.settings import LOGS_DIR
 
 if not os.path.exists(LOGS_DIR):
     os.makedirs(LOGS_DIR)

fuelweb_test/testrail/builds.py

@@ -16,8 +16,8 @@ import json
 import re
 import urllib2
 
-from settings import JENKINS
-from settings import logger
+from fuelweb_test.testrail.settings import JENKINS
+from fuelweb_test.testrail.settings import logger
 
 
 def get_jobs_for_view(view):

fuelweb_test/testrail/generate_statistics.py

@@ -25,14 +25,14 @@ from collections import OrderedDict
 from logging import CRITICAL
 from logging import DEBUG
 
-from builds import Build
-from launchpad_client import LaunchpadBug
-from report import get_version
-from settings import GROUPS_TO_EXPAND
-from settings import LaunchpadSettings
-from settings import logger
-from settings import TestRailSettings
-from testrail_client import TestRailProject
+from fuelweb_test.testrail.builds import Build
+from fuelweb_test.testrail.launchpad_client import LaunchpadBug
+from fuelweb_test.testrail.report import get_version
+from fuelweb_test.testrail.settings import GROUPS_TO_EXPAND
+from fuelweb_test.testrail.settings import LaunchpadSettings
+from fuelweb_test.testrail.settings import logger
+from fuelweb_test.testrail.settings import TestRailSettings
+from fuelweb_test.testrail.testrail_client import TestRailProject
 
 
 def inspect_bug(bug):

fuelweb_test/testrail/report.py

@@ -20,17 +20,17 @@ import time
 
 from logging import DEBUG
 from optparse import OptionParser
-from builds import Build
-from builds import get_build_artifact
-from builds import get_downstream_builds_from_html
-from builds import get_jobs_for_view
-from launchpad_client import LaunchpadBug
-from settings import JENKINS
-from settings import GROUPS_TO_EXPAND
-from settings import LaunchpadSettings
-from settings import logger
-from settings import TestRailSettings
-from testrail_client import TestRailProject
+from fuelweb_test.testrail.builds import Build
+from fuelweb_test.testrail.builds import get_build_artifact
+from fuelweb_test.testrail.builds import get_downstream_builds_from_html
+from fuelweb_test.testrail.builds import get_jobs_for_view
+from fuelweb_test.testrail.launchpad_client import LaunchpadBug
+from fuelweb_test.testrail.settings import JENKINS
+from fuelweb_test.testrail.settings import GROUPS_TO_EXPAND
+from fuelweb_test.testrail.settings import LaunchpadSettings
+from fuelweb_test.testrail.settings import logger
+from fuelweb_test.testrail.settings import TestRailSettings
+from fuelweb_test.testrail.testrail_client import TestRailProject
 
 
 class TestResult(object):

fuelweb_test/testrail/report_pi.py

@@ -20,13 +20,13 @@ import urllib2
 from logging import DEBUG
 from optparse import OptionParser
 
-from builds import Build
-from settings import JENKINS
-from settings import logger
-from settings import TestRailSettings
-from testrail_client import TestRailProject
-from report import get_tests_results
-from report import publish_results
+from fuelweb_test.testrail.builds import Build
+from fuelweb_test.testrail.report import get_tests_results
+from fuelweb_test.testrail.report import publish_results
+from fuelweb_test.testrail.settings import JENKINS
+from fuelweb_test.testrail.settings import logger
+from fuelweb_test.testrail.settings import TestRailSettings
+from fuelweb_test.testrail.testrail_client import TestRailProject
 
 
 def find_run_by_name(test_plan, run_name):

fuelweb_test/testrail/report_tempest_results.py

@@ -18,11 +18,11 @@ import optparse
 import urlparse
 from xml.etree import ElementTree
 
-import report
-from settings import JENKINS
-from settings import logger
-from settings import TestRailSettings
-from testrail_client import TestRailProject
+from fuelweb_test.testrail import report
+from fuelweb_test.testrail.settings import JENKINS
+from fuelweb_test.testrail.settings import logger
+from fuelweb_test.testrail.settings import TestRailSettings
+from fuelweb_test.testrail.testrail_client import TestRailProject
 
 
 LOG = logger

fuelweb_test/testrail/testrail.py

@@ -28,7 +28,7 @@ import json
 import time
 import urllib2
 
-from settings import logger
+from fuelweb_test.testrail.settings import logger
 
 
 def request_retry(codes):

fuelweb_test/testrail/testrail_client.py

@@ -12,9 +12,9 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from settings import logger
-from testrail import APIClient
-from testrail import APIError
+from fuelweb_test.testrail.settings import logger
+from fuelweb_test.testrail.testrail import APIClient
+from fuelweb_test.testrail.testrail import APIError
 
 
 class TestRailProject(object):

fuelweb_test/testrail/upload_cases_description.py

@@ -19,21 +19,21 @@ from optparse import OptionParser
 from proboscis import TestPlan
 from proboscis.decorators import DEFAULT_REGISTRY
 
-from builds import Build
+from fuelweb_test.testrail.builds import Build
+from fuelweb_test.testrail.settings import GROUPS_TO_EXPAND
+from fuelweb_test.testrail.settings import logger
+from fuelweb_test.testrail.settings import TestRailSettings
+from fuelweb_test.testrail.testrail_client import TestRailProject
 from system_test import define_custom_groups
 from system_test import discover_import_tests
 from system_test import register_system_test_cases
 from system_test import tests_directory
 from system_test import get_basepath
-from settings import GROUPS_TO_EXPAND
-from settings import logger
-from settings import TestRailSettings
-from testrail_client import TestRailProject
+from system_test.tests.base import ActionTest
 
 
 def get_tests_descriptions(milestone_id, tests_include, tests_exclude, groups,
                            default_test_priority):
-    from system_test.tests.actions_base import ActionsBase
     discover_import_tests(get_basepath(), tests_directory)
     define_custom_groups()
     for one in groups:
@@ -55,7 +55,7 @@ def get_tests_descriptions(milestone_id, tests_include, tests_exclude, groups,
                 continue
             parent_home = case.entry.parent.home
             case_state = case.state
-            if issubclass(parent_home, ActionsBase):
+            if issubclass(parent_home, ActionTest):
                 case_name = parent_home.__name__
                 test_group = parent_home.__name__
                 if any([x['custom_test_group'] == test_group for x in tests]):
@@ -78,7 +78,7 @@ def get_tests_descriptions(milestone_id, tests_include, tests_exclude, groups,
                                          tests_exclude))
                     continue
 
-            if issubclass(parent_home, ActionsBase):
+            if issubclass(parent_home, ActionTest):
                 docstring = parent_home.__doc__.split('\n')
                 case_state.instance._load_config()
                 configuration = case_state.instance.config_name

fuelweb_test/testrail/upload_tempest_test_suite.py

@@ -16,8 +16,8 @@ import subprocess
 
 from joblib import Parallel, delayed
 
-from settings import TestRailSettings
-from testrail_client import TestRailProject
+from fuelweb_test.testrail.settings import TestRailSettings
+from fuelweb_test.testrail.testrail_client import TestRailProject
 
 
 TEST_GROUPS = ["API", "CLI", "Scenario", "ThirdParty"]

fuelweb_test/tests/gd_based_tests/test_neutron.py

@@ -13,6 +13,7 @@
 #    under the License.
 
 import sys
+import time
 import traceback
 
 from proboscis.asserts import assert_true
@@ -28,7 +29,6 @@ from fuelweb_test.settings import NEUTRON_SEGMENT
 from fuelweb_test.settings import UPLOAD_MANIFESTS
 from fuelweb_test.tests.base_test_case import SetupEnvironment
 from fuelweb_test.tests.base_test_case import TestBasic
-import time
 
 
 @test(groups=["gd", "gd_deploy_neutron_tun"])
@@ -272,7 +272,6 @@ class NeutronTun(TestBasic):
                         remote=ssh,
                         path=post_virtual_ips[0]['cmd'])
                 except AssertionError:
-                    import time
                     time.sleep(60)
                     gd.run_check_from_task(
                         remote=ssh,

fuelweb_test/tests/gd_based_tests/test_neutron_vlan_ceph_mongo.py

@@ -13,6 +13,7 @@
 #    under the License.
 
 import sys
+import time
 import traceback
 
 from proboscis.asserts import assert_true
@@ -28,7 +29,6 @@ from fuelweb_test.settings import NEUTRON_SEGMENT
 from fuelweb_test.settings import UPLOAD_MANIFESTS
 from fuelweb_test.tests.base_test_case import SetupEnvironment
 from fuelweb_test.tests.base_test_case import TestBasic
-import time
 
 
 @test(groups=["gd", "gd_deploy_neutron_vlan_ceph_mongo"])

fuelweb_test/tests/plugins/plugin_elasticsearch/test_plugin_elasticsearch.py

@@ -17,6 +17,7 @@ from proboscis.asserts import assert_equal
 from proboscis.asserts import assert_is_not_none
 from proboscis.asserts import assert_true
 from proboscis import test
+import requests
 
 from fuelweb_test.helpers.checkers import check_plugin_path_env
 from fuelweb_test.helpers.decorators import log_snapshot_after_test
@@ -27,8 +28,6 @@ from fuelweb_test.settings import ELASTICSEARCH_KIBANA_PLUGIN_PATH
 from fuelweb_test.tests.base_test_case import SetupEnvironment
 from fuelweb_test.tests.base_test_case import TestBasic
 
-import requests
-
 
 @test(groups=["plugins"])
 class TestElasticsearchPlugin(TestBasic):

fuelweb_test/tests/plugins/plugin_influxdb/test_plugin_influxdb.py

@@ -17,6 +17,7 @@ from proboscis.asserts import assert_equal
 from proboscis.asserts import assert_is_not_none
 from proboscis.asserts import assert_true
 from proboscis import test
+import requests
 
 from fuelweb_test.helpers.checkers import check_plugin_path_env
 from fuelweb_test.helpers.decorators import log_snapshot_after_test
@@ -27,8 +28,6 @@ from fuelweb_test.settings import INFLUXDB_GRAFANA_PLUGIN_PATH
 from fuelweb_test.tests.base_test_case import SetupEnvironment
 from fuelweb_test.tests.base_test_case import TestBasic
 
-import requests
-
 
 @test(groups=["plugins"])
 class TestInfluxdbPlugin(TestBasic):

fuelweb_test/tests/test_backup_restore.py

@@ -14,27 +14,27 @@
 
 import os
 
+from devops.error import TimeoutError
+from devops.helpers.helpers import wait
 from proboscis.asserts import assert_equal
 from proboscis.asserts import assert_true
 from proboscis import test
 
-from fuelweb_test.helpers import checkers
-from fuelweb_test.helpers.decorators import log_snapshot_after_test
-from fuelweb_test.helpers import os_actions
-from devops.helpers.helpers import wait
-from devops.error import TimeoutError
-from fuelweb_test.helpers.utils import RunLimit
 from fuelweb_test import settings
+from fuelweb_test import logger
+from fuelweb_test.helpers import checkers
+from fuelweb_test.helpers import os_actions
+from fuelweb_test.helpers.decorators import log_snapshot_after_test
+from fuelweb_test.helpers.utils import RunLimit
+from fuelweb_test.settings import DEPLOYMENT_MODE
+from fuelweb_test.settings import NEUTRON_SEGMENT_TYPE
+from fuelweb_test.settings import OPENSTACK_RELEASE
 from fuelweb_test.tests.base_test_case import SetupEnvironment
 from fuelweb_test.tests.base_test_case import TestBasic
 from fuelweb_test.tests.test_ha_one_controller_base\
     import HAOneControllerNeutronBase
 from fuelweb_test.tests.test_neutron_tun_base import NeutronTunHaBase
-from fuelweb_test.settings import DEPLOYMENT_MODE
-from fuelweb_test.settings import NEUTRON_SEGMENT_TYPE
-from fuelweb_test.settings import OPENSTACK_RELEASE
 from fuelweb_test.tests.test_cli_base import CommandLine
-from fuelweb_test import logger
 
 
 @test(enabled=False, groups=["backup_restore_master"])

fuelweb_test/tests/test_ceph.py

@@ -12,7 +12,6 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from six import BytesIO
 import time
 
 from pkg_resources import parse_version
@@ -21,6 +20,7 @@ from proboscis import SkipTest
 from proboscis import test
 from devops.helpers.helpers import tcp_ping
 from devops.helpers.helpers import wait
+from six import BytesIO
 
 from fuelweb_test.helpers import os_actions
 from fuelweb_test.helpers import ceph

fuelweb_test/tests/test_cli.py

@@ -12,13 +12,13 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
+from devops.error import TimeoutError
+from devops.helpers.helpers import wait
 from proboscis import test
 from proboscis.asserts import assert_equal
 from proboscis.asserts import assert_false
 from proboscis.asserts import assert_true
 
-from devops.error import TimeoutError
-from devops.helpers.helpers import wait
 from fuelweb_test.helpers.checkers import check_cluster_presence
 from fuelweb_test.helpers.checkers import check_cobbler_node_exists
 from fuelweb_test.helpers.decorators import log_snapshot_after_test

fuelweb_test/tests/test_ironic_base.py

@@ -12,6 +12,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
+from proboscis import test
+
 from fuelweb_test.helpers.decorators import log_snapshot_after_test
 from fuelweb_test.helpers import ironic_actions
 from fuelweb_test.settings import DEPLOYMENT_MODE
@@ -20,8 +22,6 @@ from fuelweb_test.settings import NEUTRON_SEGMENT
 from fuelweb_test.tests.base_test_case import SetupEnvironment
 from fuelweb_test.tests.base_test_case import TestBasic
 
-from proboscis import test
-
 
 @test(groups=["ironic"])
 class TestIronicBase(TestBasic):

fuelweb_test/tests/test_multiple_networks.py

@@ -12,11 +12,11 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-import netaddr
 import json
 
 from devops.helpers.helpers import wait
 from devops.error import TimeoutError
+import netaddr
 from proboscis import asserts
 from proboscis import SkipTest
 from proboscis import test

fuelweb_test/tests/test_services_reconfiguration.py

@@ -14,10 +14,11 @@
 
 import random
 import time
-import netaddr
 import traceback
+from urllib2 import HTTPError
 
 from devops.helpers import helpers
+import netaddr
 from proboscis import asserts
 from proboscis import test
 
@@ -80,7 +81,7 @@ class ServicesReconfiguration(TestBasic):
                             func, *args, **kwargs):
         try:
             func(*args, **kwargs)
-        except Exception as e:
+        except HTTPError as e:
             if e.code != expected_code:
                 raise
             logger.warning('Ignoring exception: {!r}'.format(e))

fuelweb_test/tests/tests_scale/test_scale_group_2.py

@@ -80,7 +80,7 @@ class HaScaleGroup2(TestBasic):
                 primary_controller)['online'], timeout=30 * 8)
         except TimeoutError:
             assert_false(
-                self.get_nailgun_node_by_devops_node(
+                self.fuel_web.get_nailgun_node_by_devops_node(
                     primary_controller)['online'],
                 'Node {0} has not become '
                 'offline after warm shutdown'.format(primary_controller.name))

fuelweb_test/tests/tests_strength/test_failover_base.py

@@ -19,7 +19,6 @@ from devops.error import TimeoutError
 from devops.helpers.helpers import _wait
 from devops.helpers.helpers import tcp_ping
 from devops.helpers.helpers import wait
-from fuelweb_test.helpers.utils import RunLimit
 from proboscis.asserts import assert_equal
 from proboscis.asserts import assert_false
 from proboscis.asserts import assert_not_equal
@@ -27,14 +26,15 @@ from proboscis.asserts import assert_true
 from proboscis import SkipTest
 import yaml
 
+from fuelweb_test import logger
+from fuelweb_test import logwrap
+from fuelweb_test.helpers import os_actions
 from fuelweb_test.helpers.checkers import check_mysql
 from fuelweb_test.helpers.checkers import check_ping
 from fuelweb_test.helpers.checkers import check_public_ping
 from fuelweb_test.helpers.utils import get_file_size
-from fuelweb_test.helpers import os_actions
+from fuelweb_test.helpers.utils import RunLimit
 from fuelweb_test.helpers.utils import TimeStat
-from fuelweb_test import logger
-from fuelweb_test import logwrap
 from fuelweb_test.helpers.utils import run_on_remote
 from fuelweb_test.settings import DEPLOYMENT_MODE
 from fuelweb_test.settings import DNS

fuelweb_test/tests/tests_strength/test_master_node_failover.py

@@ -12,9 +12,11 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
+import time
+import traceback
+
 from proboscis.asserts import assert_equal
 from proboscis import test
-import traceback
 
 from fuelweb_test.helpers import common
 from fuelweb_test.helpers import checkers
@@ -23,7 +25,6 @@ from fuelweb_test.helpers.decorators import log_snapshot_after_test
 from fuelweb_test import settings
 from fuelweb_test import logger
 from fuelweb_test.tests import base_test_case
-import time
 
 
 @test(groups=["thread_non_func_1"])

fuelweb_test/tests/tests_strength/test_restart.py

@@ -13,6 +13,9 @@
 #    under the License.
 import time
 
+from devops.helpers.helpers import wait
+from proboscis import test
+
 from fuelweb_test.helpers.decorators import log_snapshot_after_test
 from fuelweb_test import logger
 from fuelweb_test import ostf_test_mapping
@@ -20,9 +23,6 @@ from fuelweb_test.settings import DEPLOYMENT_MODE
 from fuelweb_test.tests.base_test_case import SetupEnvironment
 from fuelweb_test.tests.base_test_case import TestBasic
 
-from devops.helpers.helpers import wait
-from proboscis import test
-
 
 @test(groups=["thread_3", "ceph"])
 class CephRestart(TestBasic):

gates_tests/helpers/exceptions.py

@@ -21,6 +21,7 @@ class PackageVersionError(Exception):
     def __init__(self, package, version):
         self.package = package
         self.version = version
+        super(PackageVersionError, self).__init__()
 
     def __repr__(self):
         return 'Package {0} has wrong version {1}'.format(
@@ -30,6 +31,7 @@ class PackageVersionError(Exception):
 class FuelQATestException(Exception):
     def __init__(self, message):
         self.message = message
+        super(FuelQATestException, self).__init__()
 
     def __str__(self):
         return self.message
@@ -39,6 +41,9 @@ class FuelQAVariableNotSet(FuelQATestException):
     def __init__(self, variable_name, expected_value):
         self.variable_name = variable_name
         self.expected_value = expected_value
+        super(FuelQAVariableNotSet, self).__init__(
+            "Variable {0} was not set in value {1}".format(
+                self.variable_name, self.expected_value))
 
     def __str__(self):
         return "Variable {0} was not set in value {1}".format(

system_test/__init__.py

@@ -33,21 +33,21 @@ from system_test.core.repository import get_groups
 
 
 __all__ = [
-    Repository,
-    ActionsFactory,
-    discover_import_tests,
-    register_system_test_cases,
-    get_groups,
-    testcase,
-    deferred_decorator,
-    action,
-    nested_action,
-    get_configs,
-    logger,
-    define_custom_groups,
-    tests_directory,
-    collect_yamls,
-    get_path_to_config,
-    get_list_confignames,
-    get_basepath,
+    'Repository',
+    'ActionsFactory',
+    'discover_import_tests',
+    'register_system_test_cases',
+    'get_groups',
+    'testcase',
+    'deferred_decorator',
+    'action',
+    'nested_action',
+    'get_configs',
+    'logger',
+    'define_custom_groups',
+    'tests_directory',
+    'collect_yamls',
+    'get_path_to_config',
+    'get_list_confignames',
+    'get_basepath',
 ]

system_test/actions/__init__.py

@@ -20,9 +20,9 @@ from .strength_actions import FillRootActions
 
 
 __all__ = [
-    BaseActions,
-    FuelMasterActions,
-    VMwareActions,
-    StrengthActions,
-    FillRootActions
+    'BaseActions',
+    'FuelMasterActions',
+    'VMwareActions',
+    'StrengthActions',
+    'FillRootActions'
 ]

system_test/actions/base.py

@@ -44,6 +44,13 @@ class PrepareActions(object):
     revert_slaves - revert environment with bootstrapped slaves
 
     """
+    def __init__(self):
+        self.full_config = None
+        self.env_config = None
+        self.env_settings = None
+        self.config_name = None
+        self._devops_config = None
+        self._start_time = 0
 
     def _load_config(self):
         config = load_yaml(self.config_file)

system_test/core/__init__.py

@@ -18,6 +18,6 @@ from .repository import Repository
 
 
 __all__ = [
-    ActionsFactory,
-    Repository,
+    'ActionsFactory',
+    'Repository',
 ]

system_test/core/repository.py

@@ -12,14 +12,13 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from fuelweb_test.helpers import metaclasses
-
 import re
 
 import proboscis.core
 from proboscis import factory
 from proboscis.decorators import DEFAULT_REGISTRY
 
+from fuelweb_test.helpers import metaclasses
 from system_test.tests import ActionTest
 from system_test.core.discover import config_filter
 

system_test/tests/__init__.py

@@ -16,5 +16,5 @@ from .base import ActionTest
 
 
 __all__ = [
-    ActionTest
+    'ActionTest'
 ]