summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrian Rosmaita <rosmaita.fossdev@gmail.com>2019-01-10 11:46:46 -0500
committerBrian Rosmaita <rosmaita.fossdev@gmail.com>2019-01-10 11:46:46 -0500
commitcf2b3f25aabe2136041a32e4f732ee99e59cf51e (patch)
treeaa6a3410ae920fea1d0e2e2cfc753ba57c8b38de
parentfb2c2e7de1bc4fd4eead3632de9358d1a7037c9f (diff)
Update "Disallowed minor code changes" doc
Update contributor docs to reflect the discussion of oslo library usage at the 10 January 2019 Glance weekly meeting. Change-Id: Ibb75ce0cbc2b906838a5149dc75bfb27383178a7
Notes
Notes (review): Code-Review+2: Sean McGinnis <sean.mcginnis@gmail.com> Code-Review+2: Erno Kuvaja <jokke@usr.fi> Workflow+1: Erno Kuvaja <jokke@usr.fi> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 15 Jan 2019 11:24:24 +0000 Reviewed-on: https://review.openstack.org/629899 Project: openstack/glance Branch: refs/heads/master
-rw-r--r--doc/source/contributor/minor-code-changes.rst12
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/source/contributor/minor-code-changes.rst b/doc/source/contributor/minor-code-changes.rst
index b75147c..4afcb06 100644
--- a/doc/source/contributor/minor-code-changes.rst
+++ b/doc/source/contributor/minor-code-changes.rst
@@ -94,3 +94,15 @@ Python 3. While the deprecation is real, Glance uses oslo_log that provides
94alias warn and solves the issue in single place for all projects using it. 94alias warn and solves the issue in single place for all projects using it.
95These changes are not accepted due to the huge amount of refactoring they 95These changes are not accepted due to the huge amount of refactoring they
96cause for no reason. 96cause for no reason.
97
98Gratuitious use of oslo libraries
99---------------------------------
100
101We are big fans of the oslo libraries and all the hard work the Oslo team does
102to keep common code reusable and easily consumable. But that doesn't mean that
103it's a bug if Glance isn't using an oslo library everywhere you could possibly
104use one. We are all for using oslo if it provides any level of benefit for us
105and makes sense, but please let's not have these bugs/patches of "Let's use
106oslo because it exists".
107
108