This change removes option to configure Images API v1
This change removes Images API v1 endpoints from the router
This change removes all v1 tests
This change removes the v1 dependant glance-cache-manage command
This change does not remove all v1 codebase. Further cleanup and
decoupling will be needed.
Change-Id: Ia086230cc8c92f7b7dfd5b001923110d5bc55d4d
The optparse module has been deprecated for some time and all apps
should be updated to use argparse instead. This switches our one
remaining command that was using it to the newer argparse usage.
Change-Id: I8f801fb804515ecf2a8b402b2923135379730098
Closes-bug: #1553030
In many places, there are more specific asserts
which can be used. I replaced the generic assert
with more specific ones, where it was possible.
This change enhances readibility, and on fail, more useful
message is displayed
Change-Id: I76dca80b6bd8886860fb383ee8d35e16cd99762e
Now, 'glance-cache-manage help' and 'glance-replicator help' don't
work. They returned wrong result. It is not user friendly at all.
Closes-bug: #1533927
Change-Id: I9b5ff7eaff4b27a5e964231dd4dfbf02a3fac7db
while running unit tests using run_tests.sh,
we can see quite an amount of unwanted log
messages and stdout prints as part of
the unit test results on the console.
This basically makes it difficult to go
through the test results and figure whats happening.
This patch fixes the cause for those
extraneous log messages caused due to
a incorrect fixture usage in test_manage.py
and also by mocking sys.stdout at the respective unit tests.
Closes-bug: #1496898
Change-Id: If986691cb3f36ba357a5c0df34b6df7bf2d8ff86
Args of assertEquals method in glance.tests are arranged
in wrong order. In result when test fails it shows incorrect
information about observed and actual data. It's found more
than 2000 times. Right order of arguments is "expected, actual".
Change-Id: Ifea4809f5a696b608a19e36a9ed9e5eec46c8a21
Co-Authored-By: Li Yingjun <liyingjun1988@gmail.com>
Closes-Bug: 1277104
The following replacements were done in unit tests to have
clearer messages in case of failure:
- assertTrue(* is None) with assertIsNone
- assertTrue(* is not None) with assertIsNotNone
- assertTrue(* in *) with assertIn
- assertTrue(* not in *) with assertNotIn
- assertFalse(* in *) with assertNotIn
- assertTrue(* == *) with assertEqual
- assertTrue(* != *) with assertNotEqual
Change-Id: I0c47f991c3974e441335e71c9d26fab8a127f2ca
Erno Kuvaja