Commit Graph

1100 Commits

Author SHA1 Message Date
Zuul 51887ec64a Merge "reno: Update master for xena Unmaintained status" 2024-03-26 16:02:59 +00:00
Zuul a1247c706c Merge "reno: Update master for wallaby Unmaintained status" 2024-03-26 16:02:58 +00:00
Zuul ac1e8714aa Merge "reno: Update master for victoria Unmaintained status" 2024-03-26 15:56:56 +00:00
OpenStack Release Bot 390310d30c reno: Update master for xena Unmaintained status
The stable/xena branch has been deleted, so reno can't find its
release notes.  Use the xena-eom tag to indicate the end of the
Glance project's maintenance of the Xena series.

This strategy is consistent with the way we handled stable/yoga and
was agreed upon at the 8 Feb Glance meeting:
https://meetings.opendev.org/meetings/glance/2024/glance.2024-02-08-14.00.log.html#l-58

Change-Id: I72b66cf523f1d5515704e4d6909ee032bdb06210
2024-03-07 22:12:03 +00:00
OpenStack Release Bot 7e50396aee reno: Update master for wallaby Unmaintained status
The stable/wallaby branch has been deleted, so reno can't find its
release notes.  Use the wallaby-eom tag to indicate the end of the
Glance project's maintenance of the Wallaby series.

This strategy is consistent with the way we handled stable/yoga and
was agreed upon at the 8 Feb Glance meeting:
https://meetings.opendev.org/meetings/glance/2024/glance.2024-02-08-14.00.log.html#l-58

Change-Id: I04c557318accc4b95c52833b15c1f0f8ca91ef97
2024-03-07 22:08:11 +00:00
OpenStack Release Bot f9809f8659 reno: Update master for victoria Unmaintained status
The stable/victoria branch has been deleted, so reno can't find its
release notes.  Use the victoria-eom tag to indicate the end of the
Glance project's maintenance of the Victoria series.

This strategy is consistent with the way we handled stable/yoga and
was agreed upon at the 8 Feb Glance meeting:
https://meetings.opendev.org/meetings/glance/2024/glance.2024-02-08-14.00.log.html#l-58

Change-Id: I7e5ac421b51be33b67ffd5910a16d549c3df624d
2024-03-07 22:02:46 +00:00
OpenStack Release Bot 8200b759b8 Update master for stable/2024.1
Add file to the reno documentation build to show release notes for
stable/2024.1.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.1.

Sem-Ver: feature
Change-Id: I377e11336ba61b77d5253a1c40d924e41fef48a4
2024-03-07 15:00:45 +00:00
Zuul e9217809e7 Merge "Bump hacking" 2024-02-21 07:52:02 +00:00
OpenStack Release Bot a17b8a8fef reno: Update master for yoga Unmaintained status
The stable/yoga branch has been deleted, so reno can't find its
release notes.  Use the yoga-eom tag to indicate the end of the
Glance project's maintenance of the Yoga series.

This strategy was agreed upon at the 8 Feb Glance meeting:
https://meetings.opendev.org/meetings/glance/2024/glance.2024-02-08-14.00.log.html#l-58

Change-Id: I5947418451eb37bd78d1910a3c7d9049f4cf1736
2024-02-12 19:58:36 +00:00
Christian Rohmann 4bdba0cae3 Remove _snapshot_has_external_reference from rbd driver
With the implementation of the trash feature in [1] checking for external
references is not done anymore, so this code is unused.

[1] https://review.opendev.org/c/openstack/glance_store/+/884524

Closes-Bug: #1959186
Partial-Bug: #2051244
Change-Id: I8e2b37441b5bb3675ebbc438f0c37d57df103ec7
2024-01-31 13:53:22 +01:00
Takashi Kajinami 14ffe72e39 Bump hacking
hacking 3.0.x is too old.

Change-Id: I3293136b291c38803c701f7aabf0ec896d164944
2024-01-28 00:00:08 +09:00
Takashi Kajinami d6e531af48 s3: Do not log access keys
The previous attempt a5ba027922 was
incomplete and there are still a few more logs where access keys are
logged. This fixes these to avoid leaking access keys to log.

Related-Bug: #2047688
Change-Id: I8dc564bed33d6fc71965f4f573ae9109b410b1d4
2024-01-21 02:09:05 +09:00
Zuul e823a3caa0 Merge "RBD: Use rados_connect_timeout to override timeout" 2024-01-19 16:44:23 +00:00
Zuul 398bc020d7 Merge "Do not show access_key in s3 driver" 2024-01-19 15:03:04 +00:00
Zuul 00cf2e67ce Merge "Increase timeout of glance_store-src-ceph-tempest" 2024-01-19 06:20:25 +00:00
lujie a5ba027922 Do not show access_key in s3 driver
Closes-Bug: #2047688
Change-Id: I9193df38d613259b61bb369fa1040fb2c51a21d7
2024-01-19 13:12:20 +08:00
Takashi Kajinami c197bbdcca RBD: Use rados_connect_timeout to override timeout
This imports the existing rados_connect_timeout option handling in
cinder so that users can use a different timeouts for Glance
specifically, instead of relying on the global ceph.conf options.

This parameter was initially deprecated in Zed release by [1] and has
had no effect since then, but this change restores the parameter with
the logic to override the timeout value in RADOS client.

[1] b1d0feeba4

Related-Bug: #1983499
Change-Id: Ib370f527c06dc85bcfd9df6ca1efb2a4e8cb5e7d
2024-01-19 13:16:24 +09:00
Zuul a35f371f3b Merge "Remove unnecessary ceilometer service overrides" 2024-01-18 11:54:52 +00:00
Andrew Bogott 62044431bd rbd: compute appropriate resize amount before resizing image
Resolves a bug introduced in

c43f19e845

This issue is only in evidence when glance is behind a proxy where the
client buffer size can be lower (for haproxy: bufsize = 16384) which
can cause unaligned reads

(https://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L1028).

The response length can be bigger than the store_chunk_size for the
first time, so at the end the RBD write will fail because it wants
to write more data than the actual RBD image size after the first
resize.

Thanks to Robert Varjasi for investigating this issue!

Fixes-Bug: 1916482
Change-Id: Ie03693c2cb8b096978fb156231c3b1cab695470f
2024-01-16 21:03:22 +00:00
Ghanshyam Mann 7b1df2a651 Update python classifier in setup.cfg
As per the current release tested runtime, we test
till python 3.11 so updating the same in python
classifier in setup.cfg

Change-Id: I9120adf03e99fe6165e430d42a30e9393da5e8ac
2024-01-08 20:21:24 -08:00
Takashi Kajinami fd083533cc Remove unnecessary ceilometer service overrides
The ceilometer services were removed from core devstack a long ago[1].
Unless the additional plugins are installed, overriding status of
the ceilometer services is just useless.

[1] e9a4750fe1b111eeb457378c26ca9eea1b5e0085

Change-Id: Icfb7add2b1d0cc330e53521fa175a8b4b37c96d2
2024-01-03 02:45:29 +00:00
Zuul 6f5011d1f0 Merge "cinder: Catch missing dependencies" 2023-12-13 07:02:02 +00:00
Zuul 0d925b6ce4 Merge "Remove unused test tools" 2023-12-07 17:25:20 +00:00
Zuul 6964d5dc3f Merge "Remove unused httplib2" 2023-12-07 15:12:06 +00:00
Zuul b72d837acb Merge "Deprecate VMWare Datastore" 2023-12-07 15:12:04 +00:00
Takashi Kajinami c2e2e62cfa Increase timeout of glance_store-src-ceph-tempest
Since [1] was merged, tempest takes quite long time because of lower
concurrency. However it's not feasible to increase the concurrency
again because of resource limitation.

This increases timeout as a short-term solution to unblock gate.

[1] https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/865315

Change-Id: Ib4c900e14788c6b581ce277a71c02d7b07369e6a
2023-12-04 19:40:08 +09:00
Takashi Kajinami 0752a868bd Remove unused httplib2
The library is no longer imported from any implementations in this
package.

Change-Id: I794b24dbdf9a29dd2542e71c99ece85a510c10bd
2023-11-19 23:58:23 +09:00
Takashi Kajinami 14a188fa90 Remove unused test tools
These tools were added 9 years ago but has no longer been used recently
in favor of tox.

Change-Id: I105dc3eba7cbe54d68a5e576340f1b0ca4a35090
2023-11-16 01:09:09 +09:00
Takashi Kajinami 651f41a95a cinder: Catch missing dependencies
Cinder store requires a few additional dependencies.
 - cinderclient
 - os.brick
 - oslo.provsep

Currently the driver handles missing cinderclient, but it does not
properly treat in case one of the other two libraries is unavailable.

Note that oslo.rootwrap is also part of the additional dependencies but
this library is not directly imported. So we do not implement check
at store initialization.

Closes-Bug: #2043583
Change-Id: I4ea0a9749fdd821f3f958f77a2923b0fafefa471
2023-11-15 21:18:00 +09:00
OpenStack Release Bot f3f5bdb45b Update master for stable/2023.2
Add file to the reno documentation build to show release notes for
stable/2023.2.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.

Sem-Ver: feature
Change-Id: I50485a9c9a563c925988bf8456b45f9caaf844ba
2023-09-15 14:53:08 +00:00
Takashi Kajinami ea61721442 Deprecate VMWare Datastore
The vmwareapi virt driver in nova was marked as experimental some
cycles ago due to lack of CI and maintainers[1]. This deprecates
the VMWare Datastore so that we can remove it when nova removes
the virt driver. The store driver is used along with the vmwareapi virt
driver and we don't expect any usage of this store driver with
the other virt drivers such as libvirt driver.

[1] 713ef7839670bd5d73af52c211a14932adc933ba

Change-Id: I57fc8cbd6308c4a82a638a2d1e997605736aedc4
2023-09-05 22:02:19 +09:00
OpenStack Proposal Bot 0c60291637 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: If5c27deb39ce62c5791b8157efeb42cfc728fc67
2023-07-08 02:08:39 +00:00
OpenStack Proposal Bot 5a81f77bd4 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ic35a1ee81e3a406aca987f75707d61e21d8606f4
2023-06-22 03:20:15 +00:00
Zuul f627d69f04 Merge "Add per-store weight config element" 2023-06-21 14:20:58 +00:00
Zuul 054bd5ddf5 Merge "RBD: Wrap RBD calls in native threads" 2023-06-16 16:18:57 +00:00
Zuul c401d3e371 Merge "RBD: Trash image when snapshots prevent deletion" 2023-06-16 08:35:53 +00:00
Eric Harney 5427e0ca48 RBD: Trash image when snapshots prevent deletion
RBD snapshots automatically end up in the trash
when deleted when using RBD image format v2.

However, they prevent images from being deleted.

Instead, move RBD images to the trash in this
situation.  This trash must be purged by a scheduled
rbd trash purge operation outside of Glance.

This passes new cinder<->image dependency tests in
I5fee2395195 when using ceph require-min-compat-client
of "mimic", which enables clone v2.

Closes-Bug: #1959186
Change-Id: I34dcd90a09d43127ff2e8b477750c70f3cc01113
2023-06-15 07:58:48 -07:00
Dan Smith b0b3edf703 Add per-store weight config element
Related to blueprint store-weight

Change-Id: Ia7d5ca93500aa84a00cd571a67d9838152ecfadd
2023-06-15 06:57:53 -07:00
Rajat Dhasmana 127410cd81 RBD: Wrap RBD calls in native threads
librbd methods call lower level C code which runs in native code
and isn't aware about the eventlet threads hence hangs the eventlet
loop until the native code is finished.
This could cause problems when we are creating multiple images
with large size where one call to librados can cause the process to
hang and other operations can starve for execution and error out.
This patch wraps each RBD call in it's own native thread that won't
affect other RBD call from executing.

Note that since glance can run under eventlet *or* native threads
with something like uwsgi, this only delegates to an eventlet worker
when we are running in that environment.

Note: This was originally merged as commit
27ab8a6aeb, but without the handling
for non-eventlet cases.

Change-Id: I87dd4a129113e6309bee1b35a7a45b2a04353b04
Co-Authored-By: Dan Smith <dms@danplanet.com>
2023-05-19 11:49:54 -07:00
Dan Smith cc39326230 Make ceph job voting
This job should be voting on glance-store.

Change-Id: Ib11da7ee08a85b6b3c00e003d1170f5ed72e3582
2023-05-19 11:49:53 -07:00
Zuul 9bd9cf4fcd Merge "Revert "RBD: Wrap RBD calls in native threads"" 2023-05-18 20:17:13 +00:00
Dan Smith 99f4014493 Revert "RBD: Wrap RBD calls in native threads"
This reverts commit 27ab8a6aeb.

Reason for revert: The change introduced a blocking library call for
the thread running import jobs.

Closes-Bug: #2020122
Change-Id: I83e3a0da9fdf7167cf4adf7257d5960338901158
2023-05-18 09:30:58 -07:00
Zuul a86bac8ce0 Merge "Update 'extras' for cinder driver" 2023-05-16 16:49:23 +00:00
Brian Rosmaita ce86bf3823 Update 'extras' for cinder driver
Raise the min version of os-brick to include the fix for
CVE-2023-2088.

Change-Id: If3dba01d5cbb3a3deacdf23ab5290d7bcab4b5c7
Related-bug: #2004555
2023-05-11 12:12:51 -04:00
OpenStack Proposal Bot ec389750c8 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ic5399869cc57661706a6e8801fcb200fbb526082
2023-05-11 03:44:56 +00:00
Brian Rosmaita 1d8033e54e Add force to os-brick disconnect
In order to be sure that devices are being removed from the host,
we should be using the 'force' parameter with os-brick's
disconnect_volume() method.

Closes-bug: #2004555
Change-Id: I63d09ad9ef465bc154c85a9ea125449c039d1b90
2023-05-10 08:29:05 -04:00
Zuul 7fd4c49b16 Merge "move attachment_update to try block" 2023-05-03 17:27:17 +00:00
Zuul 96f28eb35c Merge "RBD: Wrap RBD calls in native threads" 2023-04-26 15:09:20 +00:00
Brian Rosmaita 6741951591 Run cinder driver unit tests
We have all these nice tests, might as well execute them.

Change-Id: Iaf5131927bc2a0a953ec87c8b4d2e40f5d61d878
2023-04-18 11:31:30 -04:00
Rajat Dhasmana 27ab8a6aeb RBD: Wrap RBD calls in native threads
librbd methods call lower level C code which runs in native thread
and isn't aware about the eventlet threads hence hangs the eventlet loop
until the native thread is executed.
This could cause problems when we are creating multiple images
with large size where one call to librados can cause the process to
hang and other operations can starve for execution and error out.
This patch wraps each RBD call in it's own native thread that won't
affect other RBD call from executing.

Change-Id: I8efb0460df9fcba050b5ce949eb10caea325c851
2023-04-06 15:15:05 +00:00