openstack
/
goal-tools
Code Issues Proposed changes

tweak definition of 'review' 

Change-Id: I2aa413da3395ae68cda39bf97dca5322d02a355f
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2018-09-19 14:29:31 -04:00
parent 5fd6f60739
commit 5822c28d22
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
goal_tools/python3_first/patches.py
View File

@ -392,8 +392,13 @@ class PatchesCount(lister.Lister):
verified_votes = count_votes(c, 'Verified')
if verified_votes.get(-1) or verified_votes.get(-2):
fail_counts.update(item)
# We count reviewers as anyone posting +/- 1 or +/- 2
# votes on a patch.
reviewed_votes = count_votes(c, 'Code-Review')
if not (reviewed_votes.get(-1, 0) + reviewed_votes.get(1, 0)):
reviewers = (
sum(reviewed_votes.values()) - reviewed_votes.get(0, 0)
)
if not reviewers:
unreviewed_counts.update(item)
columns = (