openstack
/
governance
Code Issues Proposed changes

correct date comparison in check_review_status.py 

The earliest allowed merge date was being reported differently from
the way the date comparison was performed with the effect that the tool
reported it was OK to merge a change before it should have. Switch to <=
to ensure that the two dates match.

Change-Id: Iab2c783aae4fd769d02e60a6884f1128d3471270
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2018-12-05 10:20:31 -05:00
parent 92c03a9fee
commit 5194642047
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/check_review_status.py
View File

@ -304,7 +304,7 @@ def get_one_status(change, delegates):
if votes[-1]:
can_approve = 'dissenting votes'
elif age < datetime.timedelta(7):
elif age <= datetime.timedelta(7):
can_approve = 'too soon'
else:
can_approve = 'YES'
@ -317,7 +317,7 @@ def get_one_status(change, delegates):
if votes[-1]:
can_approve = 'dissenting votes'
elif age < datetime.timedelta(7):
elif age <= datetime.timedelta(7):
can_approve = 'too soon'
else:
can_approve = 'YES'