Commit Graph

30 Commits

Author SHA1 Message Date
Dmitriy Rabotyagov 5e4b092c53 Rename extra-atcs key to extra-acs
We have agreed to use term Active Contrubitor rather then
Active Technical Contributor, which means it's high time we've aligned
naming in our tools and releases documentation to align on
term to use. Moreover, it makes even more sense with Extra ACs, since
these are designed for ones, who do not contribute in gerrit but with
other means, which are usually non-technical.

Needed-By: https://review.opendev.org/c/openstack/releases/+/893833
Needed-By: https://review.opendev.org/c/openstack/election/+/893810
Change-Id: Id9f2d182d93a9fbe1357e9ecd4814d49d6eb962f
2023-09-06 10:09:30 +02:00
Ghanshyam Mann ea29ed06e9 Fix tox4 error
Fixing tox4 error to remove the skipsdist=True and
add external command via allowlist_externals.

Change-Id: I55232b60e92f31891790ae0917fc5f582477cbed
2022-12-27 23:09:45 +00:00
Zuul 0f758605cc Merge "Remove the tags framework (part 1)" 2022-02-20 19:30:08 +00:00
Dan Smith 72a3018a21 Clean generated files before run in docs target
Change-Id: Ia7f35bec67c90a907d87d089fc596b203f405a26
2022-02-10 11:38:01 -08:00
Radosław Piliszek b7f45e2266 Remove the tags framework (part 1)
This change enacts the first steps of the TC's decision to remove
the tags framework. [1]

This change does not remove all the parts to avoid breaking
the releases tooling as well as to preserve useful information
as discussed under this change and during one of the TC meetings.
[2]

[1] http://lists.openstack.org/pipermail/openstack-discuss/2021-October/025554.html
[2] https://meetings.opendev.org/meetings/tc/2022/tc.2022-01-20-15.00.log.html

Change-Id: Iab4a136905a9c7a61530ff7576a216d229f717a0
2022-02-03 18:32:27 +00:00
Hervé Beraud eb5f038b13 Add doc/requirements
This project isn't released but uniformization can't hurt.

The origin of these changes was that we need to specify doc requirements
in doc/requirements.txt to avoid problems with the pip resolver [1]
for the release team [2][3].  Removed specific doc requirements
from test-requirements.txt.

The problem here is that this repos haven't doc/requirements.txt file
and by default in this case zuul will use the test-requirements.txt file
to pull requirements [4].

This requirements file contains extra requirements like flake8 that
collided with those allowed in our job environment and so the new pip
resolver fails to install these requirements and the job exits in error.

This project could meet similar conditions leading to the bug.

[1] http://lists.openstack.org/pipermail/release-job-failures/2021-January/001500.html
[2] http://lists.openstack.org/pipermail/openstack-discuss/2021-January/019611.html
[3] http://lists.openstack.org/pipermail/openstack-discuss/2021-January/019612.html
[4] https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/ensure-sphinx/tasks/main.yaml#L36

Change-Id: Ie0c8db6331630c5d3a379a9c8c2d87eb0a8fd207
2021-01-07 10:49:37 +01:00
Mohammed Naser d5a9229ec2 Add legacy repository validation
This patch improves the legacy repository validation by ensuring that we
actually make sure the repository is properly retired.  This job will
only run on changes to the legacy.yaml file to avoid a high number of
API calls.

Change-Id: I40f1818955eaa0a2037f239aeced86c3faf3281e
2020-08-07 15:47:05 -04:00
Andreas Jaeger 7931f9818d Cleanup py27 support
This repo is now testing only with Python 3, so let's make
a few cleanups:
- Remove obsolete sections from setup.cfg
- Use newer openstackdocstheme and Sphinx versions for Python3
- Cleanup */source/conf.py to remove now obsolete content.
- Remove install_command from tox.ini, the default is fine
- Move python3 to testenv in tox.ini
- Switch to hacking 3, fix problems found.

Change-Id: I26fcab3b288b5ed64c74f7a6725b43036f195d44
2020-04-17 17:33:47 +02:00
Jean-Philippe Evrard 1afb0b8792 Make validate atcs optional
Without this patch, a change of membership of any ATC could break
the lint jobs.

This is a problem, as the change of membership can happen anytime.

This fixes it by creating a new job to show whether atc validation
fails or not, as non voting. This brings increased visibility to
the eventual membership problems, compared to having them listed
in stdout like we used to do in the past.

Change-Id: I5cb3dee7809d80369eaf8c955695b1389f5eb5d4
2019-12-23 12:43:28 +01:00
Doug Hellmann 96e8407730 add jsonschema validation for project data
This change adds a tool to perform basic JSONSchema validation of the
reference/projects.yaml file.

Change-Id: I28ff94af37d7f4de07c1d282bf3c37c77eeea101
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Co-Authored-by: Zane Bitter <zbitter@redhat.com>
2019-07-31 10:03:31 -04:00
Doug Hellmann 5a4e76328b add module for fetching and parsing governance data
Change-Id: I7279023e5d81554e19f315fe12ab6fdb988af934
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-11-07 08:30:27 -05:00
Doug Hellmann db8bc28573 add pep8 to tox.ini
Add a separate pep8 environment in tox.ini for linting only the code
changes. We don't need to add the zuul job because flake8 also runs as
part of the linters environment and job.

Change-Id: Ie6bbdfdecef43666cb0eb5d3ff4a34a7067daed2
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-10-31 13:36:03 -04:00
Doug Hellmann 92764d7cd6 remove basepython from default testenv settings
We do not want to set basepython in [testenv] because that overrides
the value used in the automatic environments like py35 and py36.

Change-Id: If198a38def34c3017523ab2fa8fec1c094732443
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-10-31 13:36:03 -04:00
Andreas Jaeger 9864d1504f Use tox-docs for building
Switch docs to new PTI docs interface using tox-docs via
the template build-openstack-docs-pti.

Fix tox.ini to use proper output directory.

With this change, Zuul now uses "tox -e docs" for building
documentation following the updated PTI.

Needed-By: https://review.openstack.org/608443
Change-Id: Ifdb23c28a0c8a42542919dd02d8f459af324deec
2018-10-07 10:31:46 +02:00
Doug Hellmann 9121a0e65a add soft validation of extra-atcs
We do not want to fail the linters job because existing valid
memberships can be closed or deleted at any time, so we just report
the errors to stdout.

Change-Id: I70bcab87c839760c43fc667dd526bd6992a46e53
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-08-03 10:40:30 -04:00
Doug Hellmann 9cde9c9afc add validation for new repositories
Require new repositories to exist in the gerrit project data managed
by the infra team before they can be added to governance.

Change-Id: Ic465e415d5253d2a918c3cd3ec8861f672360834
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-07-19 10:24:44 +02:00
Doug Hellmann 464d623c03 add check_review_status.py
I have been using this script to apply the house rules to governance
changes to help track when they are ready to be approved. I thought it
would be good to share it for others to be able to see and review the
work.

Change-Id: I41e3338858f546705e78ce5428a09dfe3b904947
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-07-13 10:59:45 -04:00
huang.zhiping 2683829189 fix tox python3 overrides
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: I13cd6b83388368966868f90ae09c88a3c644114f
2018-06-09 01:17:31 +08:00
Doug Hellmann 3cf31abecb fix tox to allow building docs locally
Recent changes in sphinx and pbr make it easier to just invoke
sphinx-build directly instead of going through setup.py.

Change-Id: Ic5c4f397fd45d9978c630ff03dcff7bf6b4d05e4
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-03-28 17:34:07 -04:00
Doug Hellmann 76868e8a50 add redirect for renamed top-5-list file
Add the redirect instructions and add whereto as a step in the linters
build to ensure that all redirects are being tested.

Change-Id: Ib8ea0be2e063a7972f3a6ad71c32921512796136
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2017-12-15 10:38:58 +01:00
Doug Hellmann 1c98c456b5 add flake8 to the linter job
Turn on flake8 for code style checks, like in our other repos. Fix or
explicitly ignore various issues to allow the linter job to pass.

Change-Id: I7bfd8cf5e9c00dfa83c0393a4307fd54d2113047
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2017-03-15 17:47:28 -04:00
Doug Hellmann 446fc28df7 update to use python3 by default
Set tox to use python3 as the base python so that all of the
environments default to python3. Fix various issues with code associated
with the change to make it work under python 3.

Change-Id: I29f9514f83aa97740e55adddaeff76d0800135bc
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2017-03-15 17:38:07 -04:00
Tony Breeds 950c4f19b7 Reduce the scope of yamllints coverage
Since I76bc62ef22d09e1b6c19ebcd9b12f6381e1fd2db the non-voting linters
target has been failign as it was also checking yaml files in the
virtualenvs created by tox [1].  This change modifies the way we invoke
yamllint so that only files we actually care about are linted.

We also configure yamllint to have a slight more generous line-length
limit and to disable the 'truthy'[2] rule.

[1] http://logs.openstack.org/10/382110/2/check/gate-governance-linters-ubuntu-xenial/6c8ae21/console.html#_2016-10-11_15_39_52_575891
[2] https://yamllint.readthedocs.io/en/latest/rules.html#module-yamllint.rules.truthy

Change-Id: Ia0337aa49efb9ec832356eed374cc56bac1e75bc
2016-10-18 14:09:41 +11:00
Tony Breeds 3bb2d51c48 Create a generic linters tox environment
Move yamllimt and check_projects_yaml_alphabetized into a generic linters
environment which can then be called from in the gate to keep yaml
data clean.

This can be extended later to include pep8 and other tools if desired

Needed-By: I92b38a8363d716fd2b844ff9c6db7dc74f4b4bfc
Change-Id: I76bc62ef22d09e1b6c19ebcd9b12f6381e1fd2db
2016-10-04 22:02:54 +00:00
Adrien Vergé 47c32a7f36 Lint YAML files
Currently most OpenStack code is linted, but YAML files are not.
This patch enables linting in tox tests using the yamllint tool [1].

It also corrects some indentation misalignments and a line longer
than 80 chars; the new CI test will prevent new errors from coming in.

[1]: http://yamllint.readthedocs.org/

Change-Id: Ie33e2636be97a09f27e519be185382be82fa19f2
2016-01-25 16:32:54 +01:00
Sean M. Collins fd6d0691e3 Add tox env for validate_tags script
This way the script can be run as:

$tox -e validate

Change-Id: Ia90bd02ab2e20dd99d613f91c9cd6b92eb9d94d8
2015-12-20 15:35:07 -05:00
Andreas Jaeger cacc105773 Ensure that reference/projects.yaml is sorted
Add to docs tox target a check that reference/projects.yaml is sorted
alphabetically and display entries that are not sorted.

Change-Id: Ia86b50622e2fac5fdf791d57c884d2d8a9ec6c44
2015-07-29 21:02:12 +02:00
Sean Dague 3ca051c746 begin conversion to rst
This converts 2 of the reference documents to rst, and fixes the
tox.ini so that tox -e docs creates a pretty html version of these
documents. While the publish target location has still not been
sorted this moves the ball forward in generating nicer output
for the documents.

The incubation-integration-requirements document was intentionally
left out, because it's much more active, and we should decide this
is the right approach before we impose the merge conflicts on
everyone in flight.

Change-Id: I2fefdb5efe196cdbda4555141b09e7e771e20bdd
2014-04-15 08:24:17 -04:00
Jeremy Stanley d2fb352f73 Remove tox locale overrides
* tox.ini: The LANG, LANGUAGE and LC_ALL environment overrides were
introduced originally during the testr migration in an attempt to be
conservative about the possibility that locale settings in the
calling environment could cause consistency problems for test runs.
In actuality, this should be unnecessary and any place where it does
cause issues ought to be considered an actual bug. Also, having
these in the configuration actively causes older pip to have
problems with non-ASCII content in some package metadata files under
Python 3, so drop it now.

Change-Id: Ie399248ec210966a57e7ef6354b6664fa48ef334
Closes-Bug: #1277495
2014-02-10 03:00:23 +00:00
Sean Dague 051215303a provide infrastructure for publishing docs to html
this brings over the pbr infrastructure for publishing rst files
to html with the oslo.sphix style. We'll need to move around
and reformat some of the documents for them to fully take effect
but this would be the first step in getting there.

Updated with our latest knowledge on how to do the right tox.ini
changes to handle sphinx issues.

This will then get used by another publish job to go to some
online repository.

Change-Id: I0dd3ecf0a9b3e356a4a2980a305b421b7d7b8602
2014-01-07 15:29:11 -05:00