openstack
/
heat
Code Issues Proposed changes

Don't assert that we haven't signalled the calling thread 

We use the notify.signal() call to notify the main thread that the stack
status has moved to IN_PROGRESS so that it can wait before returning
control to the user. Therefore it is expected that if an operation
eventually fails (or succeeds), signal() will have been called a long
time previously. The only reason it is there is to guard against
failures before the resource attains the IN_PROGRESS state, where the
persistence of the state has been deferred to coincide with the lock
release.

Story #2003988
Task: 26931

Change-Id: Ie0519ee78607f71855c2c0ace2cb4ff52c5809b6
This commit is contained in:
Zane Bitter 2018-10-05 18:22:37 -04:00
parent 7b34d88e13
commit b4038c44b5
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
heat/engine/service.py
View File

@ -184,8 +184,7 @@ class ThreadGroupManager(object):
stack.persist_state_and_release_lock(lock.engine_id)
notify = kwargs.get('notify')
if notify is not None:
assert not notify.signalled()
if notify is not None and not notify.signalled():
notify.signal()
else:
lock.release()