openstack
/
heat
Code Issues Proposed changes

Avoid reference loops in DependencyTaskGroup 

Holding a reference to a traceback in a local variable can cause a
reference loop (since the stack frame containing the local variable is
inevitably referenced by the traceback), with the result that basically
everything may need to get garbage collected. Prevent this by explicitly
deleting the local variable holding the deletingtraceback once it is no
longer required.

Change-Id: Icde3dc0c6d5b2c799df778d3e1780514bc04bf5b
This commit is contained in:
Zane Bitter 2016-03-30 14:29:40 -04:00
parent a56ec8be94
commit 2897634814
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
heat/engine/scheduler.py
View File

@ -401,11 +401,14 @@ class DependencyTaskGroup(object):
self.cancel_all()
if raised_exceptions:
if self.aggregate_exceptions:
raise ExceptionGroup(v for t, v, tb in raised_exceptions)
else:
exc_type, exc_val, traceback = raised_exceptions[0]
raise_(exc_type, exc_val, traceback)
try:
if self.aggregate_exceptions:
raise ExceptionGroup(v for t, v, tb in raised_exceptions)
else:
exc_type, exc_val, traceback = raised_exceptions[0]
raise_(exc_type, exc_val, traceback)
finally:
del raised_exceptions
def cancel_all(self, grace_period=None):
for r in six.itervalues(self._runners):