openstack
/
horizon
Code Issues Proposed changes

Fix instance launch dialog under MSIE11 

The novaAPI.getFlavors() call takes only a single parameter, which
should be an object with params. But it is being called with two
parameters here, both "true", which makes IE11 fail with TypeError
later on, when it tries to iterate over keys of params.

Change-Id: I0dcfcdca3dda2d94509d7a574184e7f82f21ca22
Closes-Bug: #1694574
This commit is contained in:
Radomir Dopieralski 2017-05-31 14:18:23 +02:00
parent 3bc399f3ae
commit afb31d55ad
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js
View File

@ -237,7 +237,10 @@
promise = $q.all([
novaAPI.getAvailabilityZones().then(onGetAvailabilityZones, noop),
novaAPI.getFlavors(true, true).then(onGetFlavors, noop),
novaAPI.getFlavors({
is_public: true,
get_extras: true
}).then(onGetFlavors, noop),
novaAPI.getKeypairs().then(onGetKeypairs, noop),
novaAPI.getLimits(true).then(onGetNovaLimits, noop),
securityGroup.query().then(onGetSecurityGroups, noop),

10
openstack_dashboard/static/app/core/openstack-service-api/nova.service.js
View File

@ -459,13 +459,9 @@
* The listing result is an object with property "items". Each item is
* a flavor.
*
* @param {boolean} isPublic (optional)
* True if public flavors should be returned. If not specified, the API
* will return public flavors by default for Admins and only project
* flavors for non-admins.
* @param {boolean} getExtras (optional)
* Also retrieve the extra specs. This is expensive (one extra underlying
* call per flavor).
* @param {Object} params (optional)
* Parameters that should be passed to the API call. Currently those can
* be "is_public" and "get_extras", both of them boolean.
* @returns {Object} The result of the API call
*/
function getFlavors(params) {