Codes for load-edit directive is placing under framework directory:
horizon/static/framework/widgets
But it has code inside for Instance creation workflow.
This should be commonized.
If load-edit will be commonized, we can use it for Key Pair importing,
Orchestration Template and Environment in stack creation.
Furthermore, plugins can use load-edit. e.g. cert file uploading in
Magnum UI, cluster spec yaml registering in Senlin Dashboard, etc.
This patch fixes the issue.
Also, at the point view from UX, file input element should be
above of textarea. Because user wants to load file at first,
rather than input directly.
Change-Id: I3e1befb81996841820111558adf3ca386709904d
Closes-Bug: #1704260
The load-edit widget had a phrase passed as separate translated words,
which makes it impossible for translators to control the word order.
This patch passes it as a single translation, fixing the issue.
Change-Id: I0dfd8e098b84241070a69938611a7e33ca3ab35a
Closes-Bug: 1553610
This patch makes the new angular Launch Instance workflow mostly
themeable. Most of the existing CSS has been deleted, and this now
follows bootstraps markup. This is not intended to solve all edge cases
given the size of the work, but is a big step in the right direction.
Changes:
- Use stacked nav tabs for navigation. Move base nav tabs toward
bootstrap default. Style primary side nav as before.
- Use bootstraps form markup for modal
- Use bootstraps form markup for form fields and their errors
- Make pie charts and tables inherit any missing theme variables. A more
thorough pass will be done on this next release cycle.
Closes-Bug: 1538491
Change-Id: Ic20b7f4341a2853ca334824c6a811125b04e88cc
Write unit tests for the directive to increase test coverage
Split file read into a separate service for easier testing.
Co-Authored-By: Matt Borland <matt.borland@hpe.com>
Co-Authored-By: Shaoquan Chen <sean.chen2@hp.com>
Co-Authored-By: Rajat Vig<rajatv@thoughtworks.com>
Change-Id: Ie886c374b19d24351766bb48023ddfb7426b7a06
Partial-Bug: #1506891
Shu Muto