The template for the instance detail overview uses Django template
filters to define a default value for metadata with an empty value.
This usage looks magic and does not work with Django 4.2.
It looks like this is an undocumented/unspecified behavior.
This commit changes it to use {% if %} template syntax instead of
depending on the unspcified behavior.
Closes-Bug: #2040129
Change-Id: Ida5b2a721f2657347c174e386d2e023dffd64b1b
Patch I0cfe9090e8263f983fa5f42f42616a26407be47a adds hypervisor hostname
to the instance details view. This patch adds the rest of instance
attributes allowed by 'os_compute_api:os-extended-server-attributes'
policy.
Change-Id: Id39ee14e3054422a96248f8cdd0a5bf07c27f2fc
Closes-Bug: #1874273
This patch add 'Project ID' information in instances,Subnet,
Volumes and Volumes Snapshots detail pages.
Change-Id: I48da491d5283ab607d298b454d32a349e97be0d1
Closes-Bug: #1815029
The 'Time since created' column name has been shortened to 'Age'
in project instances and admin instances meaning it fits properly
in table header cell and doesn't cause table header height to
increase.
Closes-Bug: #1614287
Change-Id: I94fc9eb260050e187445abd8236ac414b885b467
Co-Authored-By: Sam Wright <swright.wellington@gmail.com>
Previously, when a network name is an empty string,
network information of server interfaces will be empty,
so we cannot distinguish server interfaces.
Also network name in the instance detail page is capitalized
but there is no need to capitalize it and such information like
network name should be displayed as-is. This is not directly
related to the bug fixed by this commit, but it is simple enough
and related to network name, so I believe it is okay.
Change-Id: I2f2ad9b6bf50a2b53e79e4929d877111f875bd5b
Closes-Bug: #1805812
Previously instance ports without IP address were not shown
because api.neutron.servers_update_addresses() ignored ports
without IP address.
This commit changes servers_update_addresses() to include
a special symbol (None) representing "No IP address"
in "addresses" attribute in "server" object.
"(No IP address)" will be shown for ports without IP addresses now.
Closes-Bug: #1804016
Change-Id: I46699731ab515667b8cdf97ef68bdb8cbfe0b563
Previously this had a check for is_superuser. That's sort of
right since the default nova-api policy doesn't return the hypervisor
if you don't have the admin priv.
But, since there is a modifiable policy enforced by the api,
let's just let that decide. If nova-api returns the hypervisor,
presumably it has decided that we're allowed to see it, so let's
see it!
Change-Id: I0cfe9090e8263f983fa5f42f42616a26407be47a
The description field is only shown when the description of
a corresponding server has non-empty string. It is better to
display "description" field regardless of its value.
"description" field is supported since Mitaka release, so
this commit always shows 'description' field rather than
showing the field conditionally.
Change-Id: I2064c6e8a625d4362ce00218528a09ef734087fc
Closes-Bug: #1737558
In Nova Compute API microversion 2.19, you can specify a “description”
attribute when creating, rebuilding, or updating a server instance. This
description can be retrieved by getting server details, or list details
for servers, this patch adds support for this attribute for instance in
horizon.
Change-Id: Ic9217234021d236aee8295915f1a9c3c544396b0
Implement-blueprint: support-description-for-instance
* (admin/instances/tables.py)
_(" ") is confusing to translators. We already use an empty string ""
in the project instance table, so there is no need to use a string
only with a space.
* (project/instances/templates/instances/_detail_overview.html)
"Locked" in the instance detail template means an attribute name.
The word "locked" is potentially used in various contexts:
passive voice, adjective or some name like attribute name.
We can clarify the meaning of the string by using gettext context.
* (Angular workflow/launch-instance/keypair/create-keypair.html)
<label> with "translate" attribute leads to an extracted string
with HTML tagws. It can be avoided by using <translate> tag.
The fix is same as what were fixed in commit fcd30d95e8.
Change-Id: Ib30306d82e45d81188393d4965493abac93699e3
Added a column to show the locked status on project/admin instances table.
There will be a locked or unlocked icon with help tooltip if nova 2.9 or
above is used. See openstack_dashboard/api/microversions.py
Added the locked field on project/admin instance details panel.
Change-Id: If31ae281d2782c71cd6112f3bd6228647a6130e4
Closes-bug: #1593903
If click the name link and go into the details page for the instance, volume, etc.
And attempt to delete. It will pop up a message, but omit the name/id.
Need to add the property of 'data-display' in detail page.
Change-Id: I9c1966dc7942a27903237e2786edbcd2fbd936ea
Closes-Bug: #1680329
Updated the nova api to return None when the image name
is not available, for example, when it's deleted.
Added a check for the image name before showing it as
a link.
Change-Id: I342b23dfd8352182f50c41054d2dbb3eae854839
Closes-bug:1668783
Added space between the nav-tabs and tab content on details panels.
Removed the bullet points in front of instance IP addresses
and security groups.
Change-Id: I426e73eca0ef8ac57434631da75cb602674be893
Closes-bug: #1625310
blocktrans trimmed option removes newlines from contents of blocktrans
and replaces any whitespace at the beginning and end of a line into
a single space. This makes translator life easier.
More detail is described in the bug report.
Closes-Bug: #1583757
Depends-On: I534895be0d5f4bf0429b1511ee5421991386c873
Change-Id: Idb451b7688fd5533a8315399de13bac8b8078a67
Adds a common detail page and a breadcrumb templatetag. The breadcrumb
templatetag defaults to displaying the panel name and the existing page
title, which is usually name_or_id. The templatetag can also access the
context, and accepts a "custom_breadcrumb", for complex nested pages or
customised layouts.
This type of navigation is also useful for small devices (mobile/
tablet), providing logical direction that isn't dependant on the
sidebar being displayed.
Currently implemented in Images, Volumes (simple breadcrumb), Ports and
Subnets (more complex nesting).
This approach has been chosen as manipulation of the URLs was seen as
undesirable, making request.path too unreliable. Furthermore, the
templatetag seperation means this could easily be used in other views.
NOTE: The network details page itself will be updated following the
resolution of https://bugs.launchpad.net/horizon/+bug/1416838
Change-Id: I7443b2ffa61560e5d1fd4d6d91b11201f1db6fac
Partial-Bug: 1413823
Instances can be filtered by Image ID, but that ID isn't displayed.
This patch shows the Image ID, and also makes the Flavour name more
explicit.
Change-Id: I38c59fb0a387f8f05d42b0a0107d0102a4ddc480
Partial-Bug: 1366320
In admin instance detail page, the url for attached volume
pointing to volume detail in project panel.
This behavior is wrong, it should be link to admin panel only.
This patch corrected the url to point to the admin panel volume detail.
Change-Id: I76419f1236304211602fa98f3885d8a2a05b6468
Closes-Bug: #1470821
In admin instance detail page, the image url pointing to image detail page in project panel.
This behavior is wrong, it should be link to admin panel only.
This patch corrected the url to point to the admin panel image detail page.
Change-Id: I4ec2687cc208e61b2be00dc86e42f95fa8a1a363
Closes-Bug: #1463312
If the logined user is normal user, the instance overview page
will always show "HOST: -". There is no need show them for normal
users, it may cause some safety problem.
Closes-Bug: 1417849
Change-Id: Ib51bb05822fe910e97f73af56a8d6856764f7653
Under Instance Detail | Overview | Meta | Key Name an unclosed </em>
is rendered for an instance launched without an associated key pair.
This seems to be reproducible using Django 1.6.1 in local devstack.
The issue seems to be that Django's implementation of the add filter
has an issue concatenating a string and a function to localize text.
Since that fails and returns an empty string which subsequently is
added to the closing </em> tag, the closing tag is the only thing
that is displayed.
This fix saves the localized value to a variable which is then used
in the add filter.
Closes-Bug: #1423797
Change-Id: I4452ca4a902bbaf19ae5b2bd9bcbe2900069ac3b
in instance table, we can filter out the
instances by using the flavor id.
but there is no way to get the flavor id
in horizon for non admin users.
so adding the flavor id in instance detail
and popover flavor detail table.
Change-Id: I4995d9181a47bb7e15ce8b2c7b4252e389d91c71
Closes-Bug: #1415825
According to the Jinja2 documentation the preferred usage for
the syntax of the {% ... %} delimter is {% ... %}. This patch
changes all occurcens of {%... and ...%} to {% ... %}.
Change-Id: I49243a16b71237bea47bc29f11508e16e77e3621
According to the Jinja2 documentation the preferred usage for
the syntax of the {{ ... }} delimter is {{ ... }}. This patch
changes all occurcens of {{... and ...}} to {{ ... }}.
Change-Id: I755475d1476cbfeac190217fa67dc2640917762c
Per UX suggestion applied Bootstrap 'dl-horizontal' styling plus
added css to left justify the labels on the details page. Also
addeds col-sm-12 div inside all row divs in detail views, to achieve
proper bootstrap grid usage.
Closes-bug: #1349602
Change-Id: I337150c7a8c90cc838fac8cb89a552a0566789e3
There are several places where "-" or '-' are not translated strings.
There are others where they are. This should be consistent. I can see
value in being able to translate "-" to another character.
Closes-Bug: #1398892
Change-Id: Icfcd20fb597122d8efa30debf9f6e7273f036419
The Host Server is potentially available in the instance detail
data. Now displaying that information. This is useful data for
diagnosing issues.
Implements blueprint: instance-details-add-host-server
Change-Id: If397a6ca6f0fdf0edad12e1948ebaf4041e072d1
The current instance details page rounds the amount of RAM to the
nearest integer, which at GB and TB levels does not provide enough
fidelity to be useful, this patch allows the page to display up to one
decimal place if it is required, by changing the filter applied in the
template from mbformat to mb_float_format.
Change-Id: Ida97e83285b64ac6b08260f78f31c69dc37009b0
Closes-Bug: 1384446
In some cases, a flavor in use can become unaccessible, for instance
after deleting a flavor with access restrictions.
* On the Instance details page, make the try/except blocks for API
calls more fine-grained. Some specific failures shouldn't cause the
whole page to fail to load (and e.g. prevent Console access).
* Fix the Resize Instance form to display even if information about
the current flavor cannot be retrieved.
* Gracefully handle failures to retrieve flavor information on AJAX
calls for row update, so that the row doesn't disappear from the
table.
Change-Id: I011b6e01eca3e04e5ef2528732b9bde3782b4eba
Closes-Bug: #1366166
Use the same set of translations we have for status in the
instances table to make the status in the instance details
screen translatable.
Change-Id: I2430b9211e9f1aa2d067c74e577ba5905b261402
Closes-Bug: #1383916
Translatable string "on" is a part of string concatenation
and it makes difficult to translate it properly.
Change-Id: Ib2bf65791899a3c69087749d3a5fcf5061568b5d
Closes-Bug: #1382874
The exception fixed is the following:
NoReverseMatch: Reverse for 'detail' with arguments '('',)' and keyword
arguments '{}' not found. 1 pattern(s) tried:
[u'project/volumes/(?P<volume_id>[^/]+)/$']
The test data doesn't include a volumeId attribute to volumes but they
contain an id attribute.
Here I modify the template to rely on the the "id" attribute but maybe
real data has a volumeId attribute and it's the test data in
openstack_dashboard/test/test_data/nova_data.py that needs to be
modified instead.
Change-Id: Ia561c2db1c59e51fb669e1ad6636d9b3bc9f7676
Updated to bootstrap 3.2.0
back to v3.1.1
fix base-line-height variable
Revamped grid system
Replaced help-inline with help-block
Change .control-group to .form-group
Add column widths to horizontal form labels and .controls, remove .controls class
Datepicker form fix
Add btn-default to btn elements with no other color
Topbar switcher fix
Rename button sizes
Replace alert-error with alert-danger
Removed alert-block
Alerts fixing
Updated LinkAction and Action table actions to define icon, replaced btn-default icon with glyphicon
Replaced icons with glyphicons, removed btn-icon styling from horizon.scss
change Button Icons text in customizing docs
Fixed table header
Fix page_header h2 margin
Nav accordion fix
Tables fix
Modal fixes
added form-control class to input and selects
Forms fixes
Workflow modal fix
Fix quota bar
updated customizing docs
removed unused styling from horizon.scss
make datepicker form inline
fix table filter styling
added btn-danger to terminate instances button
fixed loading spinner
form fields and validations
Created bootstrap_form_field filter and template to render bootstrap forms properly
Style up the datepicker
Fixed failing test cases
Implements: blueprint bootstrap-update
Change-Id: Ic826849be1af7fc6bf06f97dd7a60fc54b862148
It shows up differently in Project vs Admin table for instance with no image.
Project table shows '-'
Admin table shows '(not found)'
=> Now both tables show '-' as it is consistent with other tables
Also, in the Instance detail page, Image Name shows as a hyperlinked "(not found)"
=> Now the detail page shows a plain text 'None'
Change-Id: Ie865017d4fdd6c5d6e028d9e3bf94dd67c21daca
Closes-Bug: #1277240
instance detail page and stack mapping has wrong links
to volume details (They point to volume snapshot by mistake)
Change-Id: I2c067941034d6a75f5d99fc663fe07515705afe7
Closes-Bug: #1296356
Now that instance snapshots are just images, the images & snapshots
page only has images and volume snapshots. This is an odd combination.
I think we should now move volume snapshots to the volumes panel,
since a volume snapshot is tied to a volume.
Closes-Bug: #1190843
Change-Id: I3e12cec8b859a30db9f131e9889a92277e064086
Akihiro Motoki