Commit Graph

214 Commits

Author SHA1 Message Date
Akihiro Motoki eac3e7032a Drop Heat related code from horizon
Orchestration tab in the admin info panel needs a discussion.
It seems not to be covered by heat-dashboard yet.

blueprint heat-dashboard-split-out

Change-Id: I56e6edb1f2ac72e2f42d0e9f3291308e67f24cad
2017-12-05 07:38:55 +00:00
Zuul 14cf54696d Merge "Properly sort Heat stacks on Created field" 2017-10-24 15:37:47 +00:00
Akihiro Motoki af3b7e4134 flake8-import-order: Ensure to place project imports last
To ensure project imports are placed after third party import,
we need to specify application-import-names.
Previously flake8-import-check checks only standard imports or not.

Change-Id: I9beb2105f686dc7d9aebfce8e21c5e182698e2fe
2017-09-20 01:19:38 +00:00
Pavlo Shchelokovskyy bfd66305ce Properly sort Heat stacks on Created field
replace the 'timesince_or_never' filter with 'timesince_sorted' one as the
creation_time attribute of a Heat stack can not actually be None.
Also add a 'timesince' data-type to this field.

Change-Id: I9727254b4c255331562083f957133ed6e3cd7e90
Closes-Bug: #1713748
2017-08-29 15:08:34 +00:00
yaraat 08fd18c03b Add exceptions for action
In ResumeStack.action use try/except for action resume, delete, suspend

Closes-Bug: #1535571

Change-Id: I5f1ed830e16ca60cd11c78dcaaef3596b338b4ce
2017-08-14 13:41:32 +03:00
Diana Whitten 1f11a79279 Horizon Forms should allow themable number spinners
Much like the themable selects and checkboxes, number spinners
should also be themable.

Standard number spinners are not very customizable.  We should use
existing buttons and fonts to add their functionality to allow a
richer experience if desired downstream.

An example of how to customize the spinner was placed in Material.
The example shows how to use flexbox to change layout type from
column to row, change icon order, and how to override the icons.

'autocomplete' needs to be false on this new element, otherwise
the browser will retain and load the last value without actually
triggering any JavaScript events by which we can key on and update
the state of the spinner buttons.

Change-Id: Ifd266cd515a903841e2d28e2f4731879116e3513
Closes-bug: #1598311
2017-06-28 15:50:27 -07:00
wei.ying fa3528933c Delete instance,volume,etc confirmation is missing name or ID
If click the name link and go into the details page for the instance, volume, etc.
And attempt to delete. It will pop up a message, but omit the name/id.
Need to add the property of 'data-display' in detail page.

Change-Id: I9c1966dc7942a27903237e2786edbcd2fbd936ea
Closes-Bug: #1680329
2017-04-07 22:58:50 +00:00
zhurong b1a9078404 Update the access_and_security url
Since this bp reorganise-access-and-security,
move access_and_security to separate panel,
there are some places url need to change too.

Closes-Bug: #1679895

Change-Id: I59560c479ad77d2452484b2138065a003451f376
2017-04-05 03:33:50 +00:00
Gábor Antal 34a3aa0ba8 Handle log message interpolation by the logger
According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.

[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages
Change-Id: I51f50935f1eeffe4960562d6309dfdf05814e595
Closes-Bug: #1596829
2017-03-31 20:59:16 +09:00
Jenkins e3cd250a81 Merge "hacking: noqa cleanup in openstack_dashboard" 2017-03-27 05:11:18 +00:00
Akihiro Motoki baa4ca8dce hacking: noqa cleanup in openstack_dashboard
attribute-level imports are not checked by hacking module now.
most noqa is used to disable warnings on attribute-level imports.
This commit drops noqa for this purpose.

After this, there are only 3 noqa under openstack_dashboard/ :)

Change-Id: I4a449802f5dbd6e44e4b8b5c378a555d47d9a99f
2017-03-17 19:38:47 +00:00
Kenji Ishii 00173dc3c8 Use ThemableSelectWidget for themable
Some places are not using ThemableSelectWidget, so
these select ui is not themable. This patch fix it.

Change-Id: I303a9cf8c6f8f651edf68973a2f5e16a8b04b26d
Closes-bug: #1669696
2017-03-14 12:47:56 +00:00
Jenkins 03a81c54d0 Merge "Refactor Project Volumes stand-alone panel" 2017-03-09 12:51:08 +00:00
Richard Jones 678aee340b Correct error in policy action name
It is "resource" not "resources".

Change-Id: I211439cd5be761398ebe8253ebc6a93f5237f1ce
Closes-Bug: 1671084
2017-03-09 16:24:35 +11:00
xurong00037997 9f7bf67b87 Replace six.iteritems/itervalues with dict.items()/values()
1.As mentioned in [1], we should avoid using six.iteritems
to achieve iterators. We can use dict.items instead, as it will
return iterators in PY3 as well. And dict.items/keys will more
readable.
2.In py2, the performance about list should be negligible,
see the link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: I88c133a37a11ef9049766a151a134106440bef6a
2017-03-08 01:33:07 +00:00
Richard Jones 46ad19dbf0 Refactor Project Volumes stand-alone panel
Note that there was state leaking from one of the existing
tests that was relied upon in other tests and moving that test
in the run order caused the others to fail. All related tests
have been altered to not leak state.

Change-Id: I972bc5650fa77044de8a027f570cf2cb41febef8
Implements: blueprint reorganise-volumes
2017-03-06 15:50:09 +11:00
Jenkins 2e7a0ea7a4 Merge "Fixes inconsistency in Stacks filter label" 2017-02-13 19:01:14 +00:00
Radomir Dopieralski 39e2bb784c Use "Default", "Value" and "DefaultValue" for Heat parameters
It seems there has been changes in the Heat API, and it no longer
returns the default value for a parameter in the "Default" key, it
has been instead renamed to "DefaultValue" and later to "Value".
This patch makes it use all those key names, whichever exists.

Change-Id: Ia86d8d79fcd48974ffe3fecf21a7153bf2ba6a9a
2017-02-09 12:01:07 +01:00
Rob Cresswell 560f23a1c9 Add default common template to python table views
Many of the Python table views are using identical (or nearly identical)
table templates. This patch adds a common template and makes it the
default for a DataTableView, which allows us to remove many similar
templates and redundant lines of code.

Change-Id: I1e4e15e695ee1f21f4d44f141a854e30f1e567a1
Closes-Bug: 1653986
2017-01-05 08:59:35 +00:00
Rob Cresswell 83e3ff88ec Remove duplicated modal_header statements
Across the codebase we've been using modal_header values that are
identical (or very close to) the page_title values. This patch sets the
modal_header to default to the page_title value, and cleans up a few
inconsistencies. Also deleted a couple of redundant submit_label values
that were identical to the default ("Submit").

Change-Id: I88815c3801c29b3fbc41e0cb426a50653255595f
Closes-Bug: 1653960
2017-01-04 13:31:36 +00:00
Jenkins 4f13234118 Merge "Revert "Add policy rules to project panels"" 2017-01-03 20:16:21 +00:00
David Lyle 8e03e51f71 Revert "Add policy rules to project panels"
This reverts commit 59741bd46e.

Change-Id: I4dab9699f432230ba623b35db33fe02971350c15
2017-01-03 19:35:35 +00:00
Jenkins 71f8af9751 Merge "Add policy rules to project panels" 2017-01-03 19:08:31 +00:00
Samantha Blanco 59741bd46e Add policy rules to project panels
Add policy rules to panel in
- firewalls
- instances
- network_topology
- networks
- routers
- stacks

Change-Id: Iab9f2ebb9f70febbc712eb4cfacf069049db7426
Partial-Bug:#1534495
2016-12-22 14:37:38 -05:00
Jenkins 51fffd99b7 Merge "Make ResourceTypesTests skippable" 2016-12-19 05:39:48 +00:00
Cady_Chen 51fe944449 Replace six.iteritems(iter) with iter.items()
As mentioned in [1], we should avoid using six.iteritems(iter) to
achieve iterators. We can use iter.items() instead, as it will
return iterators in PY3 as well.

[1] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: Ieadd5fa69b3f6058c0641a5b96ef3e8e1e3f6cc2
2016-12-14 11:13:20 +08:00
Revon Mathews 4458f5aaec Fixes inconsistency in Stacks filter label
Fixed inconsisteny in filter label to include '=' after the text
as seen in all the other cases.

Change-Id: I2c0905dbfef96a062028f5e0200c9e2c6100c9c8
Closes-Bug: #1648565
2016-12-08 12:08:37 -06:00
David Lyle 9f75312b07 Removing deprecated Swift UI code
The move to the angularJS based UI for swift as the default occurred
two releases ago in Mitaka. This patch removes the dead code.

Change-Id: I0322808aeacab5406c0dd3f4b19bed50bc0ff089
2016-11-17 16:00:00 -07:00
Jenkins 22b71f7c26 Merge "Drop LBaaS v1 dashboard" 2016-11-10 15:50:45 +00:00
Akihiro Motoki 7e64a1cef1 Drop LBaaS v1 dashboard
LBaaS v1 feature was removed from neutron-lbaas in Newton.
There is no reason we have LBaaS v1 dashboard in Ocata or later.

Change-Id: Ic7d4ceea1943c3721500ce4b7f769b9dba28a359
Closes-Bug: #1624655
2016-10-18 08:57:26 +09:00
Eddie Ramirez 69e18fc42c Server-side filtering Orchestration
Included patch 12 changes
Implements blueprint: server-side-filtering
Co-authored-by: Revon Mathews <revon.mathews@intel.com>
Change-Id: I22c5c736f756b1f5640d2fc4d284ac45deaefc19
2016-10-17 15:50:17 +00:00
Ying Zuo be934e5f9b Make ResourceTypesTests skippable
The unit test fails when the resource types panel is disabled, even
if it's skipped with unittest.skip becuase the INDEX_URL is defined
as a class property. Also, it is used once only so it doesn't need
to be defined as a variable.

Change-Id: Ib9c190ca13c791c1f72c348bef0be1f20ccd33e1
2016-09-30 10:46:06 -07:00
Rob Cresswell 3488ab3d40 Fix compatibility issues with Django 1.10
Required modifying our URL pattern decorator to
be compatible with the slightly different callback
attribute mechanism in 1.10

Modified breadcrumb structures to always be 2-tuples
as tuple unpacking is now strictly enforced in 1.10

Also made the following things changed in Django 1.10.
- fixed the now-deprecated TEMPLATE_DEBUG.
- Caught up with Request context change
- SimpleTestCase.urls is removed in 1.10.
  ROOT_URLCONF needs to be used instead.

Co-Authored-By: Richard Jones <r1chardj0n3s@gmail.com>
Co-Authored-By: Akihiro Motoki <motoki@da.jp.nec.com>
Change-Id: I59cbd8bff117813258539ed0724fe89a9f5b77ee
Implements: blueprint dj110
2016-09-20 12:29:16 +01:00
zhurong 2c56563580 Remove the lowercase case boolean type in heat param_type
heat-api had already return the boolean type using 'Boolean' in this commit:
https://review.openstack.org/#/c/116762/ , So remove the lowercase case.

Change-Id: If2fd981ffb854699301b77c6b0bc318a90c178dc
2016-09-11 21:51:00 +08:00
Tatiana Ovchinnikova 88aaf89a08 Add filter action to Template Versions tables
Orchestration Template Versions table and Template Functions tables
(which are actually template versions details) need filter function.
This patch adds filters and removes appeared checkboxes.

Change-Id: If3c5dfdb3f5915ee0b464c675d976f67ebb09be3
Closes-Bug: #1614889
2016-08-19 12:40:55 +03:00
Tatiana Ovchinnikova a86c7d9be7 Remove Orchestration Resource Types names restriction
The additional columns "Implementation", "Component" and "Resource"
are representative for a limited resource type group only. Resource
type name can have less or more than three words and Heat even allows
to specify a URL as a resource type. Horizon should not use these
columns at all: "Type" column and filter will do just the same trick.

Change-Id: I38a671490b90122e2d75e6aa11d3de0fa12817c9
Closes-Bug: #1614000
2016-08-17 20:21:26 +03:00
Ramaraja dafa021766 Remove multi select option on Resource types table
Resource Types panel in Orchestration panel group has a resources
type table.Filter option has been added recently and it brings
checkboxes for each rows by default which is not necessary for this
table action. Hence set multi select option false to remove checkboxes.

Change-Id: Id3fee4fc8c4a67b6ac0057fce92178b8a314e57d
Closes-Bug: #1606328
2016-07-26 17:55:23 +00:00
David Lyle af627907d5 Updating heat policy file
The heat policy is out of date. This patch updates the policy file
to match heat master.

There have been several modifications to the heat policy rules
checked in the heat views. The previously used policies were a
mix of fantasy, out-dated policy rules and just error. After
instrumenting the heat code to verify policy usage, the new
rule checks align with heat master policy use.

Change-Id: I17eb7d2945924167f3a62440b7e12b9b313d0f5d
2016-06-14 11:01:45 -06:00
Tatiana Ovchinnikova 914a07a51f Refactor Orchectration Stacks menu
Move some Orchestration Stacks table actions to table actions menu.

Change-Id: I38f0b4f2e961b0e3f40bb44efad16d5eb64762b2
Closes-Bug: #1570532
2016-05-13 17:10:02 +03:00
Jenkins 1554e281bc Merge "Heat Template Versions panel" 2016-05-10 18:21:52 +00:00
Tatiana Ovchinnikova e2f46511ff [Trivial] Wrong policy for Heat resource type details
TrivialFix

Change-Id: I1ef79478f1309f11a6a7c4772cb844299496708b
2016-05-05 06:47:07 +00:00
Tatiana Ovchinnikova 94fd2485f9 Heat Template Versions panel
This patch set adds a separate panel for Heat template versions and
template functions.

Depends on: Id9718bb5d1c2b70664a9c27c67e91436e5489dd6
Partially implements blueprint: heat-template-versions

Change-Id: I44bfd72a7d4147d48ffa999c93de0e41e591d5c1
2016-05-05 06:45:46 +00:00
David Lyle 037d1c0927 removing httplib2 test dependency
Once upon a time, the python-*client libraries were primarily built to
use httplib2. They have subsequently shift to using requests and thus
urllib3. The horizon test helpers code was maintaining a reference to
httplib2 as it intercepted errant library calls that were not mocked.

httplib2 is not actively maintained and OpenStack is moving to remove it
as a dependency. See
http://lists.openstack.org/pipermail/openstack-dev/2016-March/089225.html
for more details.

This patch removed the httplib2 dependency. Upon removing the
dependency it exposed a missed update from httplib2 to urllib3. A
function that was intended to catch unmocked calls was only listening
for httplib2 connections. This patch updates that failsafe to work with
urllib3. Upon doing so, it pointed out many, many missing mocks and in
turn, many broken tests that appeared to work because of API call
failures. This patch adds the missing mocks and fixes the broken tests.

The new failsafe prints the stack trace when an outside connection is
attempted. Additionally, to fix the fact that a missed mock used to
allow tests to potentially pass, as documented by bug 1517704, a test
failure is now forced on tests where a missing mock is detected.

Closes-Bug: #1517704
Implements blueprint: remove-httplib2-dep
Change-Id: Iaabdf03966c14c82e0c58a3b1ab1a6755c05adcb
2016-05-02 13:19:08 -06:00
Kenji Ishii 2b80998f9a Add filter function on resource type table
Resource Types panel in Orchestration panel group has a resources
type table. This table does not have a filter function even though
the number of colums is over 90.
This patch add a filter function to this table.

Change-Id: I66e950b1acc3d9ea70fff5545cc0cc7fce6fa500
Closes-bug: #1569681
2016-04-20 11:56:18 +00:00
Jenkins dc8c01c929 Merge "Update URLs to Django 1.8+ style" 2016-04-11 18:10:51 +00:00
Jenkins 84f9c75b80 Merge "Pass environment data to update stack action" 2016-04-10 16:16:37 +00:00
Rob Cresswell fd92d8ec59 Fix remaining Django 1.9 test failures
This patch gets Horizon to a passing state in the Django 1.9 tests

Co-Authored-By: Itxaka <iserrano@redhat.com>
Co-Authored-By: Timur Sufiev <tsufiev@mirantis.com>
Change-Id: Icbc1a3c039de658faa9fba4a2cdd5027345fe94d
Partially-Implements: blueprint drop-dj17
2016-04-09 11:13:16 +00:00
Ying Zuo f65ff0fe91 Pass environment data to update stack action
Change-Id: I7df7f1664ab067b287cffab4187c16a10ad4abba
Closes-bug: #1564613
2016-04-04 15:53:09 +00:00
LIU Yulong d3dd5e0ff0 Make no response notification(msg) level to INFO
Some API calls just sent but the results were uncertain,
Horizon should notify the user that your request is
just accepted, not successfully.
So this patch change some form message level to INFO,
and some message expression.

Change-Id: I241cd9cf3ad6b2bd747e3ea1c6040a140ba77b56
Closes-Bug: #1326301
Closes-Bug: #1286418
2016-03-29 21:12:31 +08:00
Rob Cresswell 15e83c6448 Update URLs to Django 1.8+ style
Django 1.8 altered and deprecated the existing pattern for defining
URLs. This will be removed in 1.10, meaning that many deprecation
warnings show up under Django 1.9. We should fix the URLs promptly to
avoid logspam, and to support Django 1.10 in Newton.

See
https://docs.djangoproject.com/en/1.9/releases/1.8/#django-conf-urls-patterns

Change-Id: I074d20850de59bfe678a3bc72e9f0f25bd743cbf
Partially-Implements: blueprint dj110
2016-03-28 11:03:08 +01:00