Commit Graph

30 Commits

Author SHA1 Message Date
Akihiro Motoki eac3e7032a Drop Heat related code from horizon
Orchestration tab in the admin info panel needs a discussion.
It seems not to be covered by heat-dashboard yet.

blueprint heat-dashboard-split-out

Change-Id: I56e6edb1f2ac72e2f42d0e9f3291308e67f24cad
2017-12-05 07:38:55 +00:00
zhurong b1a9078404 Update the access_and_security url
Since this bp reorganise-access-and-security,
move access_and_security to separate panel,
there are some places url need to change too.

Closes-Bug: #1679895

Change-Id: I59560c479ad77d2452484b2138065a003451f376
2017-04-05 03:33:50 +00:00
Akihiro Motoki baa4ca8dce hacking: noqa cleanup in openstack_dashboard
attribute-level imports are not checked by hacking module now.
most noqa is used to disable warnings on attribute-level imports.
This commit drops noqa for this purpose.

After this, there are only 3 noqa under openstack_dashboard/ :)

Change-Id: I4a449802f5dbd6e44e4b8b5c378a555d47d9a99f
2017-03-17 19:38:47 +00:00
Jenkins 03a81c54d0 Merge "Refactor Project Volumes stand-alone panel" 2017-03-09 12:51:08 +00:00
xurong00037997 9f7bf67b87 Replace six.iteritems/itervalues with dict.items()/values()
1.As mentioned in [1], we should avoid using six.iteritems
to achieve iterators. We can use dict.items instead, as it will
return iterators in PY3 as well. And dict.items/keys will more
readable.
2.In py2, the performance about list should be negligible,
see the link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: I88c133a37a11ef9049766a151a134106440bef6a
2017-03-08 01:33:07 +00:00
Richard Jones 46ad19dbf0 Refactor Project Volumes stand-alone panel
Note that there was state leaking from one of the existing
tests that was relied upon in other tests and moving that test
in the run order caused the others to fail. All related tests
have been altered to not leak state.

Change-Id: I972bc5650fa77044de8a027f570cf2cb41febef8
Implements: blueprint reorganise-volumes
2017-03-06 15:50:09 +11:00
Akihiro Motoki 7e64a1cef1 Drop LBaaS v1 dashboard
LBaaS v1 feature was removed from neutron-lbaas in Newton.
There is no reason we have LBaaS v1 dashboard in Ocata or later.

Change-Id: Ic7d4ceea1943c3721500ce4b7f769b9dba28a359
Closes-Bug: #1624655
2016-10-18 08:57:26 +09:00
Cindy Lu 49fad8b093 Heat Stacks Details: Events table doesn't show up
It shows a loading sign.
There is an AttributeError because event_list does not return
with any 'resource_type' to map. Since it doesn't make any sense,
removed the resource_to_url link, and also add a check in the method.

Change-Id: Ic94cffaa2450bbee3f9c9dabcaffb03a6cdc3b46
Closes-Bug: #1493216
2015-10-02 09:58:05 -07:00
Victor Stinner 27e3f6c537 py3: Replace basestring with six.string_types
Patch generated by the command:

  sixer.py basestring horizon/ openstack_dashboard/ tools/

Partial-Implements: blueprint porting-python3
Change-Id: I6fd251243a058457f69907eb1111f559a224e1cb
2015-08-19 17:18:32 -07:00
David Lyle fce980c8ce Fix static file paths in heat topology view
The svg and gif images are still using '/static/' as the base url. Since
WEBROOT is configurable and STATIC_URL is as well. This is needs to be
fixed or the images won't be found when either has been changed from the
default.

Closes-Bug: #1474512
Change-Id: I532216c86e131b947e4377303ff3123f32e236f9
2015-07-24 17:02:04 +00:00
Jenkins 34de24a7b6 Merge "Clean up terminal output for stack details section" 2015-06-29 17:25:41 +00:00
Antoine Abélard 78e1da339b Heat topology display improvement
The current heat topology display is poor because a lot of resources
don't have any icons and are displayed as unknown resources.

openstack_dashboard/dashboards/project/stacks/mappings.py file has
been modified to add the identification of the other resource types.

Icons were created for the others resources types, keeping the actual
style and put them in the openstack_dashboard/static/dashboard/img/
folder.

Co-Authored-By: Antoine Abélard <abelard.antoine@gmail.com>
Co-Authored-By: David Lyle <david.lyle@intel.com>

Implements: blueprint heat-topology-display-improvement
Change-Id: I03f184e1561d27cda498c4d4d17be975069101bd
2015-05-01 15:40:37 +00:00
Tatiana Ovchinnikova 1192752ee6 [Heat] Resource url mapping improvement
This patch set adds nested stacks and autoscaling groups to resource
url mapping to make proper links to resources from stacks details.
Some resource types from Neutron component are also added.

Closes-Bug: 1443454

Change-Id: I0f95aa3381401e30e68bf34c0d3bc5895ce8a433
2015-04-13 16:40:21 +03:00
Tatiana Ovchinnikova beab5bc295 Heat resource url mapping improvement
This patch set adds a few resource types to resource
url mapping to make proper links to resources from
stacks details.

Partially implements blueprint: heat-ui-improvement

Change-Id: I829c586b75c9b4c15dcf58ea317cf28eddec182b
2015-03-16 14:53:11 +03:00
nikunj2512 dabfe0ab92 Fixes Resource id mapping with Heat Resources
Adds a few more resources which heat backend provides. This will
take care of the resource id mapping on 'Resource Detail' page.

Closes-bug: #1335032

Change-Id: I056bf2f0340b5c9f197ebb26120eed34b2693845
2015-02-04 14:52:23 +05:30
liyingjun 2677db4dc0 Add missing OS::Cinder::Volume resource url map
OS::Cinder::Volume is missing in resource url map in file
openstack_dashboard/dashboards/project/stacks/mappings.py,
this will lead to no link for cinder volume stack resource

Closes-bug: #1417388

Change-Id: Ic6d23be797b0910b60bf616fd5d18b9e4b4e1727
2015-02-03 14:09:44 +08:00
liyingjun bdaf50455c Updating stack resource urls mapping
Needs to update OS::Quantum::** to OS::Neutron::**

Change-Id: I7671d209d30739fa5eb55cb6baadf85eb3cfed0b
Closes-bug: #1416948
2015-02-02 13:56:43 +08:00
Vic Howard 4860fa23df Clean up terminal output for stack details section
heat output section formatted poorly, fix is to output the
output filter the same as the log or console sections

Closes-Bug: 1350088
Change-Id: I23bfbe03fa33a5af06c59dcfd2b87137e3a82f51
2015-01-02 10:28:22 -05:00
Miguel Grinberg e8f5dc442c show correct link to compute instances in stack resource overview tab
There are two related fixes in the stacks resource overview page.
First, any resource types for which horizon does not have a link for
were getting a URL of "None" in the uuid field, and with this
change the link is suppressed if it is None. The second part involves
adding compute resources to the resource mappings, so that the uuid
field for those links to the instance detail page.

Change-Id: Ib8d51b49ac51092a3d7db6d889f4427167e5adb0
Closes-Bug: 1322162
2014-08-21 23:12:21 +00:00
He Yongli e790ac070e Remove extraneous vim configuration comments
Remove vim setting:
comment - # vim: tabstop=4 shiftwidth=4 softtabstop=4

at the top of source code files, except for files in
openstack/common.

Change-Id: I9a5c6b17c6ef7ecec601f4503dfc7b31fc72e90a
Close-bug: #1229324
2014-05-06 15:30:10 +08:00
CristianFiorentino 198dba6a2d Introduces escaping in Horizon/Orchestration
1) Escape help_text a second time to avoid bootstrap tooltip XSS issue

The "Description" parameter in a Heat template is used to populate
a help_text tooltip in the dynamically generated Heat form. Bootstrap
inserts this tooltip into the DOM using .html() which undoes any
escaping we do in Django (it should be using .text()).

This was fixed by forcing the help_text content to be escaped a second
time. The issue itself is mitigated in bootstrap.js release 2.0.3
(ours is currently 2.0.1).

2) Properly escape untrusted Heat template 'outputs'

The 'outputs' parameter in a Heat template was included in a Django
template with HTML autoescaping turned off. Malicious HTML content
could be included in a Heat template and would be rendered by Horizon
when details about a created stack were displayed.

This was fixed by not disabling autoescaping and explicitly escaping
untrusted values in any strings that are later marked "safe" to render
without further escaping.

Change-Id: Icd9f9d9ca77068b12227d77469773a325c840001
Closes-Bug: #1289033
Co-Authored-By: Kieran Spear <kispear@gmail.com>
2014-04-09 00:29:56 +09:00
Akihiro Motoki 2139fe9433 Fix wrong links to volume detail
instance detail page and stack mapping has wrong links
to volume details (They point to volume snapshot by mistake)

Change-Id: I2c067941034d6a75f5d99fc663fe07515705afe7
Closes-Bug: #1296356
2014-03-24 03:56:29 +09:00
Fengqian Gao 9133f5ad63 Use six.moves.urllib.parse instead of urlparse
To keep Python 3.x compatibility, use six.moves.urllib.parse to
replace urlparse.

Partial-Bug: #1279611

Change-Id: Ie49589651ed80d8fc3196fb0750cbb04661c19cd
2014-02-24 13:45:47 +08:00
Radomir Dopieralski 028332da4a Remove #noqa from most common imports and add them to import_exceptions
We have a lot of import with #noqa that is there to ignore h302,
because it's traditional to import and use a name directly, instead
of a whole module. This hides other errors and gives people the
impression that it's actually fine to import non-modules, you just
have to slap #noqa on those lines.

I went through the code and identified about a dozen names that are
most commonly imported this way. I remove the #noqa tag from them,
and added them to the list in import_exceptions.

I also removed a few unused imports that were revealed in the process.

Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78
2014-01-07 12:26:35 +01:00
Paul Belanger da8c69afa6 Gate on H4xx docstrings for pep8
In an effort to help horizon more friendly to OpenStack hacking
guidelines, we now gate on H40* violations.

Change-Id: Id07294543660368d2f7f5ac363710176ab23b874
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
2013-11-23 12:51:07 -05:00
Tatiana Mazur b4fc9b4bc9 Small "H302 check" cleanup
This patch set removes some commented out stuff that
has been unintentially left in "H302 check" patch set.
It also replaces a couple more method imports with
module imports.

Fixes bug 1215892

Change-Id: I35fd880154a4ea6d6d8d3b3615103c271aa4a005
2013-08-23 18:07:08 +04:00
Tatiana Mazur 953d1b9793 Enable H302 check
This patch replaces some method imports with module imports and
makes H302 test enabled.

Fixes bug 1188531

Change-Id: Ibfbddeaa19cbbb244da58ffd5c918c41f03a0c65
2013-08-22 17:39:09 +04:00
Tim Schnell 4898dd9846 Updates Topology to correctly handle resources in the INIT state.
Before resources are pushed to create_in_progress,
they now exist as init_complete.
This allows us to draw the entire topology at
instantiation instead of waiting for
resources to start creating before they can be seen
in the topology.

Change-Id: I9c5ea164ec13f1b89633c4b10c04e0c1941649b7
Implements: blueprint init-state-heat-topology
2013-08-07 14:24:29 -05:00
Tim Schnell 8914ed95fc Adding Heat Resource Topology to Horizon
Change-Id: Ie9f2040850df3d7f1fcefe68430e9103c972f80f
Implements: blueprint heat-ui-resource-topology
2013-07-16 18:33:11 -05:00
Steve Baker 1f71152b4b Implementation of a Heat stacks UI.
This change implements a UI to launch, manage and delete Heat stacks.

The launch screens are implemented with a set of chained forms where
the second form is dynamically built from the template in the first step.

A significant portion of this change was derived from
the work Dan Radez <dradez@redhat.com> did on thermal:
https://github.com/steveb/heat-horizon

UX flow revisions and basic test cases by Gabriel Hurley.

Implements blueprint: heat-ui

Change-Id: I294e93bed6da9dd3553e8b4a6a1c09b7c165a555
2013-07-03 03:48:31 -07:00