Orchestration tab in the admin info panel needs a discussion.
It seems not to be covered by heat-dashboard yet.
blueprint heat-dashboard-split-out
Change-Id: I56e6edb1f2ac72e2f42d0e9f3291308e67f24cad
attribute-level imports are not checked by hacking module now.
most noqa is used to disable warnings on attribute-level imports.
This commit drops noqa for this purpose.
After this, there are only 3 noqa under openstack_dashboard/ :)
Change-Id: I4a449802f5dbd6e44e4b8b5c378a555d47d9a99f
Many of the Python table views are using identical (or nearly identical)
table templates. This patch adds a common template and makes it the
default for a DataTableView, which allows us to remove many similar
templates and redundant lines of code.
Change-Id: I1e4e15e695ee1f21f4d44f141a854e30f1e567a1
Closes-Bug: 1653986
Across the codebase we've been using modal_header values that are
identical (or very close to) the page_title values. This patch sets the
modal_header to default to the page_title value, and cleans up a few
inconsistencies. Also deleted a couple of redundant submit_label values
that were identical to the default ("Submit").
Change-Id: I88815c3801c29b3fbc41e0cb426a50653255595f
Closes-Bug: 1653960
Previous commit broken heat resource drill down:
f38ddf2032 (diff-15e3003726d7b90816528ee8248b000f)
This patch fixes the ID attribute, correctly specifies the template,
alters the page to match other detail page styles, and adds a UT to
prevent regression.
Change-Id: Ie3f76d6666f4e3154fbcb5808c8f8b841e650a02
Co-Authored-By: Rob Cresswell <robert.cresswell@outlook.com>
Closes-bug: #1531341
when get_file is contained in template, the stack create/update/preview
will fail due to No content found in the "files" section.
So added handle get_file code.
Change-Id: I6f125f9e5f3f53f630ab0d4f3f00631e6850e905
Closes-Bug: #1512564
This patch adds basic Breadcrumb nav to the detail pages for Data
Processing, Databases, Metadata Definitions and Routers.
Change-Id: I114e93799b957db39cbe0d4e49d3e6869bc9d92d
Partial-Bug: 1413823
The App Catalog UI would like to pass Heat environment data through to
the Heat stack create form and noticed environments can't be passed
without this patch.
Change-Id: I74618bd7e894325dadca048ede929de15996bb25
Closes-Bug: 1497591
This fixes passing params to stack and image creation form dialogs.
It also fixes a bug with nested dialogs.
Partial-Bug: 1481518
Change-Id: Ie6965ad7c8a738f8b88927077884bba621f2eb6b
This patch set adds "Preview Stack" button to Stacks table
to provide user with a possibility to preview stack without
creating it, as it is already implemented in CLI.
Partially implements blueprint: heat-ui-improvement
Change-Id: Idf92deb57f8213a403f102db467828087d91e79a
Patch https://review.openstack.org/#/c/142802 adds a method of
reducing duplication of page title logic, this patch applies that change
to the project stacks views.
Change-Id: Icff6df155983adeedec59d3aacdd4a0b685cf9a3
Partial-Bug: 1413749
The same line of code to add a page title to a template was repeated in
many templates, this patch moves that line into the base.html, and also
tries to standardize the way page titles are defined in the python.
Change-Id: I11367d3007ebae727ba45446076a31307d477995
Closes-Bug: 1399840
The page title for heat resources was a huge object with
all of it's attributes and renders to the page in the most
horrific of ways. This fixes that
Change-Id: I886cbdd27c41652f8da9248fe6fc5157581fba3f
Closes-bug: 1415084
Several panels use the template filter "add" to concatenate data
and translatable text, for example
title=_("Volume Details: ")|add:volume.name|default:_("Volume Details:")
These need to be updated to use string formatting. This is needed
because it's not clear when looking at the translations if any text
follows the translatable segment. Dict based substitution has been
used to further clarify the messages for translators.
Change-Id: I54d07233d2003904468ef317c352126eb6bf5f70
Closes-bug: #1394573
Once you launch a stack from any template source (using raw data
or template file), there is no possibility to check this template
later from Horizon. This patch set adds 'Stack Template' tab to
Stack Details page.
Partially implements blueprint: heat-ui-improvement
Change-Id: I27fb687829f9c060ea55d81bcc0344a6e782da06
Stack list API supports a sort direction and sort key which we can
use to paginate back
Following same convention as merged patch:
https://review.openstack.org/#/c/91111/
Change-Id: I511d7d27a6234e1510c7fa3c7f84c007599f3721
Partially-implements: blueprint pagination-add-prev-link
Warnings H904, H307 and H405 are new or considerably changed, and will
be fixed in a separate patch.
Closes-bug: #1349820
Partial-bug: #1347472
Change-Id: I4fd28990dacf16f03a4eaa6074ef59c37f1a2c14
Remove vim setting:
comment - # vim: tabstop=4 shiftwidth=4 softtabstop=4
at the top of source code files, except for files in
openstack/common.
Change-Id: I9a5c6b17c6ef7ecec601f4503dfc7b31fc72e90a
Close-bug: #1229324
2 Part view for updating Heat Templates. The first page allows you to
select a new template for your stack. The second allows you to set new
template parameters for your stack. Like the launch stack workflow, this
is not a horizon workflow, but two separate forms.
Implements: blueprint heat-stack-update
Change-Id: I2854e9e4bb578be5187ef962808b93f11ac6b1f1
Ignoring kwargs causes wrong key generation for
cache (for memoization) and hence, causes repeated call
of function with wrong arguments list.
Change-Id: I85391f30fa81a27496b3399108b4859b2234591e
Closes-Bug: #1268349
We have a lot of import with #noqa that is there to ignore h302,
because it's traditional to import and use a name directly, instead
of a whole module. This hides other errors and gives people the
impression that it's actually fine to import non-modules, you just
have to slap #noqa on those lines.
I went through the code and identified about a dozen names that are
most commonly imported this way. I remove the #noqa tag from them,
and added them to the list in import_exceptions.
I also removed a few unused imports that were revealed in the process.
Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78
A lot of horizon's views use the pattern:
def get_data(self):
if not hasattr(self, "_data"):
# Calculate data here.
self._data = data
return self._data
This is copy-pasted all over the codebase. It's better to handle that
with a single decorator. In the future, we might even replace it with
some better caching approach.
Closes-bug: #1248230
Change-Id: Id021fccf9032e5068993ec91a7774a5d0fbf29bb
This patch replaces some method imports with module imports and
makes H302 test enabled.
Fixes bug 1188531
Change-Id: Ibfbddeaa19cbbb244da58ffd5c918c41f03a0c65
Fixes all occurrences of this. We have a custom exception handler
in Horizon anyway that only catches ClientException in most of these
cases, but this commit lets us gate on the other cases.
Change-Id: Iea3dc13817f3e5b775b2024424bf3a906da5584b
Closes-Bug: #1211657
This bug addresses the incorrect location of the AJAX function call in api.py and moves it to the correct location in views.py
It also standardizes the AJAX JSON function to use a generic Django class instead of a function.
Change-Id: I445ca58d1e05187c9d05fdb6814039c69543324c
Fixes: bug #1201980
This patch replaces relative imports with full paths and
makes H304 test enabled.
Fixes bug 1188535
Change-Id: I47254cf9a790727102f7993d0fd107da514983df
This change implements a UI to launch, manage and delete Heat stacks.
The launch screens are implemented with a set of chained forms where
the second form is dynamically built from the template in the first step.
A significant portion of this change was derived from
the work Dan Radez <dradez@redhat.com> did on thermal:
https://github.com/steveb/heat-horizon
UX flow revisions and basic test cases by Gabriel Hurley.
Implements blueprint: heat-ui
Change-Id: I294e93bed6da9dd3553e8b4a6a1c09b7c165a555