openstack
/
instack-undercloud
Code Issues Proposed changes

Unit tests - actually do some validations ... 

Change-Id: I1b9c4fae6d2e9851e3afaa8952b16dfe7c50d044
This commit is contained in:
Harald Jensas 2018-01-13 15:31:29 +01:00
parent 955c339af3
commit 53d35ac772
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
instack_undercloud/tests/test_validator.py
View File

@ -135,6 +135,8 @@ class TestValidator(base.BaseTestCase):
def test_invalid_undercloud_nameserver_fails(self):
self.conf.config(undercloud_nameservers=['Iamthewalrus'])
self.assertRaises(validator.FailedValidation,
undercloud._validate_network)
def test_fail_on_invalid_public_host(self):
self.conf.config(undercloud_public_host='192.0.3.2',
@ -165,6 +167,7 @@ class TestValidator(base.BaseTestCase):
self.conf.config(undercloud_admin_host='10.0.0.10',
generate_service_certificate=True,
enable_ui=True)
undercloud._validate_network()
@mock.patch('netifaces.interfaces')
def test_fail_on_invalid_ip(self, ifaces_mock):