instack-undercloud is no longer in use by the TripleO project. Removing
the code to avoid confusion. Stable branches will continue to be
maintained for their life however no new features should be added.
Change-Id: I63a813c7c1ffd30ca30017133d31a497b77a9a4d
Blueprint: remove-instack-undercloud
This replaces the deprecated (in python 3.2) unittest.TestCase
method assertRaisesRegexp() with assertRaisesRegex().
Change-Id: Ib2f53eaa039514bacf3dd0000e8400baf1ba659d
Signed-off-by: Chuck Short <chucks@redhat.com>
There have been some reports of users misinterpreting
where to place configuration for the provisining subnets
in undercloud.conf. The example text for the subnets leads
to users adding the subnets section directly after the
subnets option. I.e in the middle of the DEFAULT section
of the ini file.
This change drops the example. The ctlplane-subnet section
is there as an example already.
Related-Bug: rhbz1585497
Related-Bug: #1778779
Change-Id: I417623db410330058d30fe7435112f01a0f72c83
We migrate overcloud stack to convergence in post_config which would
otherwise fail. It makes sense to fail quicker before doing any upgrade.
Change-Id: Ie5831b022d1a7572729e0715cdc07253efbbca17
Related-Bug: #1767962
They are deprecated and will be removed from Ironic. A similar change
was already done to the containerized undercloud.
Change-Id: If442f103adc03ec97f9e995d5e2bc47dfc097f90
Introduce docker_insecure_registries that is an array of host/port
combiniations of docker insecure registries. The default value will
be the previous parameter that were hardcoded, but now we can easily
override it in undercloud.conf.
Note: the feature is already supported for the containerized undercloud
but was only missing in instack-undercloud. This patch will be
backported.
Depends-On: I14fda3481ac88429648bed8edb2f4469b33be957
Change-Id: I402ebb80b1d755cdb0c3c28fd542121bc60cb144
Closes-Bug: #1767373
When having a file with incorrect SELinux context
in /home/stac/.ssh a permission error is displayed
at the time of running semanage during Pike to
Queens undercloud upgrade.
Closes-Bug: #1767405
Change-Id: I994917e491d6f8b4141a3c332c79ed8e8ce8e64c
There is an issue with the _validate_no_ip_change function
where it doesn't work correctly with a custom net_config_override
file.
This patch resolves validation issue so that custom os-net-config
templates are taken into account. Additionally it makes it so
that the net_config_override can be empty, thus providing the
user a means of disabling os-net-config if they choose to do so.
Change-Id: Iada099a6bddc7927d26b19776e705b1ac231b2e5
Depends-On: I69eb812af2d653cb3eb29694ae29b57ebb2de53d
Closes-bug: #1764507
This wasn't include in the bash version and was incorrecly added
when it was converted to python in I0168991a0fbd9dacf708ba2bdbc13248414affbe
Closes-Bug: #1754681
Change-Id: I41e37346122b0acaffb72fad34519e9e9828f61e
The host route to the metadata service should use the
undercloud as next_hop when configuring the subnet that
is on the same L2 segment as the undercloud itself. The
code used to manage this was not correctly implemented.
Change-Id: Icf40af8ac424d14386aacda38cf674cc25273fc8
Closes-Bug: #1757418
This enables TLS by defalut in the undercloud. This is done by setting
the generate_service_certificate option to True by default, although,
the deployer can turn it off if needed.
Change-Id: Id329081c06343373309d6880d464ba99aba0c7be
In addition to puppet-stack-config.yaml
(cf. I1de069a4d3786af030530a100982087c0784889e), the endpoints also
need to be specified in the main endpoints list.
Change-Id: I3701c34841b84c2272dcc24d982fc622ff6139b6
Partial-Bug: #1755560
We were not passing the MTU when we create the ctlplane network so if
the local_mtu is less than 1500, 1500 is used by the ctlplane network in
neutron.
Change-Id: Ic7a4c5a62ff49b2f8964dd58bf5c97d9781c4ce1
Related-Bug: #1754036
This change removes a workaround for remaining tuskar* packages after upgrade.
Original problem reported as: https://bugs.launchpad.net/tripleo/+bug/1691744
We have that workaround in L, M, N and O releases.
It's time to get rid of it and forget about tuskar.
Closes-Bug: 1755537
Change-Id: I895dcd880281be3d07310f5983a4fa9fdb9fc88f
It used to be the case that if you give both a user-provided
certificate, and set the flag for instack to autogenerate the
certificate, the autogenerated one took precedence. This is not ideal
since it might not be what the user expects (especially if we switch to
using TLS by default).
Closes-Bug: #1755497
Change-Id: Ia8aa52d80999ad278501ca8ecf0638ef8de6ca19
During undercloud upgrade, yum can update the mariadb-server package.
If that is the case and the updated package is a major mariadb update
(e.g. 5.5 -> 10.1, or 10.0 -> 10.1), some database system tables might
need to be updated.
Ensure that mysql_upgrade will be run after a major mariadb update.
Also, force-stop the mariadb server before the upgrade to workaround
a rpm scriptlet limitation when going 5.5 -> 10.1.
Change-Id: Iebc3f39cb2dae355124ba39f7653ef8d20baacc6
In Pike Mistral workflows in tripleo-common were tagged with
`tripleo-common-managed`. During the transition we needed to conder
installs with no tagged workflows. However, users of Queens and above
will already have this handled, so the extra code and the test case can
be removed.
Change-Id: I06b3bccf03c1e2851c0bc3b291cefbf24ff7dbff
This isn't necessary and will likely have some bad side effects
because re-calling the conf object clears all previously registered
opts, which defeats the purpose of the second call.
Change-Id: I59bd78e85b3d55aea23b46809f4de678d394f66d
Related-Bug: 1751815
This has been unsupported since 2016's puppet-ironic commit here:
I0f242a7e1c28c4007b3c2d955dbd3b29086e92f1
Change-Id: Ic219fcdf2695c08b629015a0c387629d01f86a20
Docker will switch the FORWARD filter to DROP if it sets the ip_forward
to 1. Previously we were doing this in a post configuration element
rather than in the puppet run itself. This change moves the ip_forward=1
to puppet so it runs prior to docker being installed. Additionally we
are ensuring that the full set of network rules are being added to the
FORWARD filter because previously we were only setting half of them.
This would allow us to actually not have to use ACCEPT as the default
for the FORWARD filter but this would require additional testing.
Previously we had tried switching the default policy back to ACCEPT,
however given that docker is not configuring the iptables rule until
it's installed and started, the puppet rules do not actually apply on
the installation of the undercloud. The puppet management of the
defaults for the FORWARD chain only gets updated on a subsequent run of
the installer which will not work.
Change-Id: Ieae6a74f7269bd64606fd80a2a08b2058c24d2c5
Closes-Bug: #1750194
Closes-Bug: #1750874
Add a validation, if the config have multiple subnets
specified but routed networks is disabled we raise
validation error.
Change-Id: Ic7ca1fb76e73da70f6a72100a9cbff42d8f34b0d
Other OpenStack services clients are being installed as dependencies of
Heat. Octavia support in Heat was included during Queens development
cycle [1]. TripleO deployments will include python-octaviaclient as
requirement of Heat. This means the Octavia client will be installed in
the undercloud and overcloud regardless.
This reverts commit fef5be332e.
[1] https://review.openstack.org/#/q/topic:bug/1737567+(status:open+OR+status:merged)
Change-Id: I727503b6c1acf1953a0ad864ae6288021a745193
In the change to keystone sessions and Mistral client 3.2.0 the
exception raised when fetching an environment that doesn't exist
changed. This adds the new exception but continues to catch the previous
one.
Closes-Bug: #1749186
Change-Id: I304547b9ecabe4e387339c8561bbae8651cd9db6
Allow installation of the Octavia client in the Undercloud by setting
new option enable_octavia=True in the undercloud.conf. Default is not to
enable.
Change-Id: I2b27dac2f30a126e6519d19cc135ea6eea59e8a9
* Enable the neutron segments service_plugin for routed
provider networks.
* Update controlplane network code to create segments
for each subnet.
A number of options related to ctlplane network is deprecated.
More details in release notes.
Implements: blueprint tripleo-routed-networks-ironic-inspector
Implements: blueprint tripleo-routed-networks-deployment
Depends-On: I33804bfd105a13c25d6057e8414e09957939e8af
Change-Id: I4b384bab2af9f6ba07a137a37f4098a00ce18bc0
Alex Schultz