This is the first in a series of commits to add support for codespell. This is continuning the process completed in ironic-python-agent.
Future Commits will add a Tox Target, CI support and potentially a git-blame-ignore-revs file if their are lots of spelling mistakes that could clutter git blame.
Change-Id: Icb4e66359c3e79618c916b35793ea7b5f79b030d
This is a follow-up for extra issues identified during code review of
Ib4978f5e3e4f1b64faa1bfae3cdcf46199bb2f21
Story: 2008698
Task: 42099
Change-Id: Ic18d42209d0f0f7c12ab0972dba2b97bb93b7c4e
The Ironic API has a validation on the LocalLinkConnectionType to
ensure all mandatory values are included. Handle failures which
could occur if the switch does not send all mandatory fields.
Change-Id: I8716a69586265a58520cc2c6bc0bbc00a7c159da
Story: 2004238
Task: 27761
When the processed lldp data is used for setting the local_link_connection
switch_id, it will set it even if the Chassis ID is not a mac. Need to
only set it when the ChassisId is a mac address, as is done when using
non-processed lldp data. Ironic validates that switch_id is either a
mac address or OpenFlow datapath ID.
This fixes a regresssion introduced in Pike.
Change-Id: I566acb5b19852b541df7554870ab2666f7df9614
Closes-Bug: 1748022
Set it to True for the PXE-booting port, to False for all the others.
Create an extended functional tests covering various operations with ports.
Change-Id: I435a5c04884b6c4da70cb7260b305fbde23eebc0
Closes-Bug: #1667472
This change uses the processed lldp stored by the lldp_basic plugin
to populate the local_link_connection port_id and switch_id.
If processed lldp data cannot be found, the raw lldp data is processed by
this plugin as currently implemented. This patch changes the
processing to use the construct lib as implemented in the common
definitions in lldp_tlvs.py to parse the LLDP TLVs.
A minor change is also made to pass node_info into warning log messages.
Change-Id: Iae3fa41736898df2c73350d8dc61ed24f2963e32
The i18n team has decided not to translate the logs because it seems
like it not very useful.
Change-Id: I46c1b0c3efa28c3f887b1a29dc77d47fe749be87
Closes-Bug: #1674374
The current local_link_connection hook assumes that all inspected
interfaces are either added to or already exist in ironic as ports. When
CONF.processing.add_ports is set to PXE, and a node has more interfaces
than the one that we PXE on, then there will be more interfaces in the
inventory than added to Ironic. This patch ensures we must handle that
scenario.
Change-Id: I42c98c571ae8cfc26f319b712b5ac5bad88bb75d
Closes-Bug: #1628991
This patch corrects a problem with the LLC hook's use
of the node_info.patch_port function, ensuring the correct data is
passed to the function, not a unicode string.
This patch also ensures that the mac addresses for chassis-id and
port-id are passed to ironic in the expected Unix format. Ironic will
fail to validate the mac addresses without this.
Change-Id: Id5b729cd9e9beeb4f59ba6950162163d2fdf3a3a
Closes-Bug: #1629302
Closes-Bug: #1629303
For Ironic multi-tenant networking support, we need to be able to
discover the nodes local connectivity. To do this IPA can try to pull
LLDP packets for every NIC.
This patch adds a processing hook to handle the data from these packets
in ironic-inspector so that we can populate the correct fields fields in
Ironic. The generic lldp hook only handles the mandatory fields port id
and chassis id, set on port_id and switch_id in local_link_connection.
Further LLDP fields should be handled by additional vendor specific LLDP
processing hooks, that populate the switch_info field in a non-generic
way.
Change-Id: I884eaaa9cc54cd08c21147da438b1dabc10d3a40
Related-Bug: #1526403
Depends-On: Ie655fd59b06de7b84fba3b438d5e4c2ecd8075c3
Depends-On: Idae9b1ede1797029da1bd521501b121957ca1f1a
Sharpz7