summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2 daysMerge "Allow processing power_off to be defined"HEADmasterZuul
3 daysMerge "Use processed bool as key in introspection_data DB table"Zuul
3 daysAllow processing power_off to be definedJulia Kreger
In testing discovery or more advanced workflows in CI that incorporate with inspector, it is generally useful to enable the post processing power setting to be updated. Change-Id: Iece696e91edd78f42bde21738442d0b27ea3dafa Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+2: Mark Goddard <mark@stackhpc.com> Workflow+1: Mark Goddard <mark@stackhpc.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 14 Feb 2019 16:52:26 +0000 Reviewed-on: https://review.openstack.org/636774 Project: openstack/ironic-inspector Branch: refs/heads/master
3 daysUse processed bool as key in introspection_data DB tableBob Fournier
When using store_data=database with sqlalchemy, running introspection results in a DBDuplicateEntry error. This happens because the query when adding an entry uses both the primary key (uuid) and the processed flag, but the processed flag is not a key. This change makes it a key so that both unprocessed and processed data can be stored in the table. Note - since the previous migration hasn't been released yet this fixes it without creating a new one. Change-Id: I052594d529ae363fce50b1726169d86583bb1439 Story: #2004992 Task: #29463 Notes (review): Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Dmitry Tantsur <divius.inside@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 14 Feb 2019 12:00:29 +0000 Reviewed-on: https://review.openstack.org/636692 Project: openstack/ironic-inspector Branch: refs/heads/master
3 daysMerge "Introspection data storage backend follow up"Zuul
10 daysMerge "Support latest as the microversion value"Zuul
2019-01-24Introspection data storage backend follow upKaifeng Wang
An issue is spotted during implementing [1], we have a solely code path from api, do_reapply, reapply, to _reapply. Inspector now reads intrspection data ahead, so there is no need to do so in _reapply, reading introspection data there is never reached. The patch removes unecessary code and corresponding tests. [1] https://storyboard.openstack.org/#!/story/1564863 Change-Id: I5558bce2bc49de3d1c5dba59e203de4824a3addd Story: 1726713 Task: 11373 Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Julia Kreger <juliaashleykreger@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 13 Feb 2019 18:45:28 +0000 Reviewed-on: https://review.openstack.org/632969 Project: openstack/ironic-inspector Branch: refs/heads/master
2019-01-23Merge "introspection data backend: plugin layer"Zuul
2019-01-20Merge "Follow-up Zuulv3 (Ironic jobs rename)"Zuul
2019-01-17Prevent abnormal timeout values from breaking sync with ironicDmitry Tantsur
I had a case when an operator set the timeout too a abnormally large value, which caused OverflowError in the timeout clean_up task, which, in turn, prevented ironic-inspector from ever running node list sync with ironic. This change makes two corrections: * The timeout configuration is limited to 10 years (0 can still be used to disable the timeout completely). * Errors in the clean_up task do not prevent the node list sync from running. Change-Id: Ie3ad29a4abb9ac58c41b776042f80dff6a9c72d2 Story: #2004807 Task: #28963 Notes (review): Code-Review+2: Mark Goddard <mark@stackhpc.com> Code-Review+1: Iury Gregory Melo Ferreira <iurygregory@gmail.com> Code-Review+1: Arne Wiebalck <Arne.Wiebalck@cern.ch> Code-Review+1: Riccardo Pittau <elfosardo@gmail.com> Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Julia Kreger <juliaashleykreger@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 18 Jan 2019 06:43:05 +0000 Reviewed-on: https://review.openstack.org/631538 Project: openstack/ironic-inspector Branch: refs/heads/master
2019-01-16Follow-up Zuulv3 (Ironic jobs rename)Iury Gregory Melo Ferreira
Depends-On: https://review.openstack.org/#/c/629173/ Change-Id: Iab84dc23bbc137bf960e1fdbaf924ea38aecc4b3 Notes (review): Code-Review+2: Kaifeng Wang <kaifeng.w@gmail.com> Workflow+1: Dmitry Tantsur <divius.inside@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sun, 20 Jan 2019 16:27:55 +0000 Reviewed-on: https://review.openstack.org/629475 Project: openstack/ironic-inspector Branch: refs/heads/master
2019-01-07Remove dsvm from zuulv3 job namesIury Gregory Melo Ferreira
According to [1] the dsvm should be removed from zuulv3 jobs [1] https://docs.openstack.org/infra/manual/drivers.html#naming-with-zuul-v3 Change-Id: I5d470b5048e8d474c4c3271fcba85a0dc781827a Notes (review): Code-Review+2: Kaifeng Wang <kaifeng.w@gmail.com> Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Workflow+1: Dmitry Tantsur <divius.inside@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 08 Jan 2019 14:41:55 +0000 Reviewed-on: https://review.openstack.org/629011 Project: openstack/ironic-inspector Branch: refs/heads/master
2019-01-07introspection data backend: plugin layerspace
Configurable introspection data storage backend [1] is proposed to provide flexible extension of introspection data storage instead of the single support of Swift storage backend. This patch adds plugin mechanism for loading introspection storage, creates database backend and moves Swift storage into a plugin. [1] http://specs.openstack.org/openstack/ironic-inspector-specs/specs/configurable-introspection-data-backends.html Story: 1726713 Task: 11373 Co-Authored-By: Kaifeng Wang <kaifeng.w@gmail.com> Change-Id: Ie4d09dc0afc441b20a1e5e3bd8e742b1df918954 Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Julia Kreger <juliaashleykreger@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 23 Jan 2019 03:29:15 +0000 Reviewed-on: https://review.openstack.org/514552 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-12-31Merge "introspection data backend: implements db"Zuul
2018-12-11Merge "spelling error"8.1.0Zuul
2018-12-08Merge "Accept None value for set-attribute"Zuul
2018-12-08spelling errorchenjiao
Change-Id: I90b23399df4cb6e6f5a52b80fdde8ddfe0365641 Notes (review): Code-Review+2: Kaifeng Wang <kaifeng.w@gmail.com> Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Workflow+1: Dmitry Tantsur <divius.inside@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 11 Dec 2018 05:44:26 +0000 Reviewed-on: https://review.openstack.org/623621 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-12-07Accept None value for set-attributeIury Gregory Melo Ferreira
Allows the ``set-attribute`` introspection rule action to use ``None`` as a valid value. Co-Authored-By: Riccardo Pittau <elfosardo@gmail.com> Change-Id: I1aa11c8095c4557107223e352424e3b718e2ab35 Story: #2004546 Task: #28299 Notes (review): Code-Review+2: Mark Goddard <mark@stackhpc.com> Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Workflow+1: Dmitry Tantsur <divius.inside@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 08 Dec 2018 22:51:52 +0000 Reviewed-on: https://review.openstack.org/622898 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-12-05Change openstack-dev to openstack-discussmelissaml
Mailinglists have been updated. Openstack-discuss replaces openstack-dev. Change-Id: I6d9ae8e65f09608286a0181b1ae5f1c82cf0e155 Notes (review): Code-Review+2: Jim Rollenhagen <jim@jimrollenhagen.com> Workflow+1: Jim Rollenhagen <jim@jimrollenhagen.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 04 Dec 2018 20:09:29 +0000 Reviewed-on: https://review.openstack.org/622572 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-12-04introspection data backend: implements dbKaifeng Wang
Configurable introspection data storage backend [1] is proposed to provide flexible extension of introspection data storage instead of the single support of Swift storage backend. This patch adds database support for using ironic-inspector database as the storage backend. A table named ``introspection_data`` is created to serve as the storage for introspected data. [1] http://specs.openstack.org/openstack/ironic-inspector-specs/specs/configurable-introspection-data-backends.html Change-Id: I8b29b7b86d90823d29b921ebf64acddbcd2d8d0d Story: 1726713 Task: 11373 Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Julia Kreger <juliaashleykreger@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 31 Dec 2018 17:57:52 +0000 Reviewed-on: https://review.openstack.org/583930 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-11-28Merge "Support IPv6 address when validating interfaces"Zuul
2018-11-27Merge "Zuul migration"Zuul
2018-11-27Merge "Wrap Flask into oslo.service"Zuul
2018-11-27Merge "Support ip6tables for iptables pxe filter"Zuul
2018-11-24spelling errorchenjiao
Change-Id: Id2f00e4583f4d18542982f9d5a28bb2d3a27875c Notes (review): Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Julia Kreger <juliaashleykreger@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 26 Nov 2018 22:47:04 +0000 Reviewed-on: https://review.openstack.org/619842 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-11-19Add a voting bifrost job to ironic-inspectorDmitry Tantsur
We broke bifrost (and thus openstacksdk) CI with our recent AMQP change. Let us add a job to not let this happen again. Change-Id: I7756f1526fca9c54c431c9e5e21a43c40cdfa1e8 Depends-On: https://review.openstack.org/618726 Notes (review): Code-Review+2: Mark Goddard <mark@stackhpc.com> Code-Review+2: Kaifeng Wang <kaifeng.w@gmail.com> Workflow+1: Kaifeng Wang <kaifeng.w@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 20 Nov 2018 04:13:15 +0000 Reviewed-on: https://review.openstack.org/618731 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-11-19Support IPv6 address when validating interfaceszhengyong
When processing introspection data from IPA, ironic inspector only accept IPv4 address of an interface. In a IPv6 environment, the port will not be collected if processing.add_ports is not set to 'all'. Story: #1744073 Task: #11374 Co-Authored-By: Kaifeng Wang <kaifeng.w@gmail.com> Change-Id: I0e1839df4d0e3b89f182ab98549486199d64c4ad Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Julia Kreger <juliaashleykreger@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 28 Nov 2018 05:39:23 +0000 Reviewed-on: https://review.openstack.org/536139 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-11-15Merge "Wrap rpc server into oslo.service"Zuul
2018-11-15Merge "Handle validation failure if not all switch fields received"Zuul
2018-11-14Replaces http with https in release noteszhouxinyong
Change-Id: Idac5fc5abc0e2f6bff1d6e3bb3f024f0053f0c7a Notes (review): Code-Review+2: Kaifeng Wang <kaifeng.w@gmail.com> Workflow+1: Kaifeng Wang <kaifeng.w@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 14 Nov 2018 09:32:29 +0000 Reviewed-on: https://review.openstack.org/617798 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-11-13Handle validation failure if not all switch fields receivedBob Fournier
The Ironic API has a validation on the LocalLinkConnectionType to ensure all mandatory values are included. Handle failures which could occur if the switch does not send all mandatory fields. Change-Id: I8716a69586265a58520cc2c6bc0bbc00a7c159da Story: 2004238 Task: 27761 Notes (review): Code-Review+2: Kaifeng Wang <kaifeng.w@gmail.com> Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Workflow+1: Dmitry Tantsur <divius.inside@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 15 Nov 2018 14:00:02 +0000 Reviewed-on: https://review.openstack.org/615456 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-11-13Remove the repetition words in usage.rstzhouxinyong
Change-Id: I20656e4f189586b12cdea7ada10fbabe1f4c4dba Notes (review): Code-Review+2: Mark Goddard <mark@stackhpc.com> Workflow+1: Mark Goddard <mark@stackhpc.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 13 Nov 2018 11:05:34 +0000 Reviewed-on: https://review.openstack.org/617563 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-11-07Support ip6tables for iptables pxe filterKaifeng Wang
Adds a configuration option [iptables]ip_version to specify the desired ip version for the iptables pxe filter, which can be set to 4 or 6. When set to 6, the iptables pxe filter will use ip6tables command to manage rules for the port 547 which is the port of DHCPv6 server side. The string type is used to make room for the future, when there is need to automatically determine ip version from the binding interface. Change-Id: I7de2be5950a23def3ec6490f2e6dfa3d5c42798a Story: 1756012 Task: 11411 Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Julia Kreger <juliaashleykreger@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 27 Nov 2018 03:38:12 +0000 Reviewed-on: https://review.openstack.org/615728 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-10-30Zuul migrationKaifeng Wang
This patch migrates legacy dsvm-discovery and dsvm-python3 jobs to zuulv3. Change-Id: I0f6000247a970ea2ccaff4757f7677de2dcd1593 Notes (review): Code-Review+1: Harald Jensås <hjensas@redhat.com> Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Dmitry Tantsur <divius.inside@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 27 Nov 2018 13:06:33 +0000 Reviewed-on: https://review.openstack.org/613498 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-10-23Wrap Flask into oslo.serviceKaifeng Wang
This patch is part of inspector HA work, which wraps inspector api into oslo service. oslo.service has also provided support to signal processing like SIGHUP or SIGTERM, so these code were removed in this patch. Deprecated current SSL cert/key options used by ironic-inspector, code manually creates ssl context were removed. These options will be fed from [ssl] section. Change-Id: Ia5e16fcb9104556d62c90f5507f17b41f73a5208 Story: #2001842 Task: #12609 Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+1: Harald Jensås <hjensas@redhat.com> Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Julia Kreger <juliaashleykreger@gmail.com> Code-Review+1: Brin Zhang <zhangbailin@inspur.com> Code-Review+1: Leopard Ma <mabao@inspur.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 27 Nov 2018 03:38:15 +0000 Reviewed-on: https://review.openstack.org/561823 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-10-23Wrap rpc server into oslo.serviceKaifeng Wang
This patch is part of work splitting inspector api and worker. The rpc server is wrapped into oslo.service, and launched from api process. Now api and worker belongs to separate thread, functional tests use the fake messaging driver, while devstack jobs use rabbitmq. Change-Id: Ie03d16f9d115c3561723463dea6a57d2a763bcc6 Story: #2001842 Task: #23109 Notes (review): Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Workflow+1: Dmitry Tantsur <divius.inside@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 15 Nov 2018 14:00:04 +0000 Reviewed-on: https://review.openstack.org/584758 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-10-22Merge "Add API reference"Zuul
2018-10-22Merge "Rearrange conf and policy configuration file"Zuul
2018-10-16Add API referenceAnton Arefiev
Add initial API reference, which covers all inspector endpoits. The conf.py and the tox environment are stolen from ironic. Co-Authored-By: Kaifeng Wang <kaifeng.w@gmail.com> Change-Id: I5009e8708dcad8ab25380f7bf574125d6e758ef5 Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+2: Ruby Loo <opensrloo@gmail.com> Code-Review+2: Julia Kreger <juliaashleykreger@gmail.com> Workflow+1: Julia Kreger <juliaashleykreger@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 22 Oct 2018 20:31:33 +0000 Reviewed-on: https://review.openstack.org/495752 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-10-16Rearrange conf and policy configuration fileKaifeng Wang
Minor project file structure adjustment, to move config-generator.conf and policy-generator.conf into tools/ subdirectory. Also exclude tools/ from dsvm jobs. Change-Id: I3242401511b88bd9b677d9875481808783f890b8 Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+2: Ruby Loo <opensrloo@gmail.com> Workflow+1: Ruby Loo <opensrloo@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 22 Oct 2018 18:54:37 +0000 Reviewed-on: https://review.openstack.org/609584 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-10-16Merge "Add introspection rules actions to add/remove traits on nodes"Zuul
2018-10-12Merge "Test swift python3 support"Zuul
2018-10-12Merge "Use set_defaults from cors"Zuul
2018-10-11Test swift python3 supportKaifeng Wang
Change-Id: I22766ea3f96c2b0911e1fa3219fab5411fa2b5fc Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+1: Iury Gregory Melo Ferreira <iurygregory@gmail.com> Code-Review+2: Ruby Loo <opensrloo@gmail.com> Workflow+1: Ruby Loo <opensrloo@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 12 Oct 2018 15:50:12 +0000 Reviewed-on: https://review.openstack.org/609573 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-10-10Merge "Use templates for cover and lower-constraints"Zuul
2018-10-08Replace subprocess with processutilsKaifeng Wang
Trying to fix the dsvm-python3 job. Depends-On: https://review.openstack.org/608620 Change-Id: Ibdfed9545a26e752ab7aeed2db122a368c3c06fb Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+1: Iury Gregory Melo Ferreira <iurygregory@gmail.com> Code-Review+2: Sam Betts <sam@code-smash.net> Workflow+1: Sam Betts <sam@code-smash.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 09 Oct 2018 17:41:06 +0000 Reviewed-on: https://review.openstack.org/606349 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-09-22Use templates for cover and lower-constraintsAndreas Jaeger
Small cleanups: * Use openstack-tox-cover template, this runs the cover job in the check queue only. Remove individual cover jobs. * Use openstack-lower-constraints-jobs template, remove individual jobs. * Sort list of templates Change-Id: Ib53ff2b1d336b86eb71b2d30b2ae48bbb59764b9 Notes (review): Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Code-Review+2: Kaifeng Wang <kaifeng.w@gmail.com> Workflow+1: Kaifeng Wang <kaifeng.w@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 10 Oct 2018 06:11:48 +0000 Reviewed-on: https://review.openstack.org/604537 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-09-18Add introspection rules actions to add/remove traits on nodesDmitry Tantsur
Otherwise it's not possible to modify them, since they're not updated via the regular node updating mechanism. Change-Id: I338015ff9dafe07f4e70a23ddcf6cd488eda9907 Story: #2003788 Task: #26496 Notes (review): Code-Review+2: Kaifeng Wang <kaifeng.w@gmail.com> Code-Review+2: Mark Goddard <mark@stackhpc.com> Workflow+1: Mark Goddard <mark@stackhpc.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 16 Oct 2018 06:54:27 +0000 Reviewed-on: https://review.openstack.org/603126 Project: openstack/ironic-inspector Branch: refs/heads/master
2018-09-17Merge "Imported Translations from Zanata"Zuul
2018-09-17Replace assertEqual(True/False, *) with assertTrue/assertFalse in testsTao Li
In UT Test,It provides assertTrue(*) and assertFalse(*) to check the returned value. It is not necessary to use assertEqual(True, *) or assertEqual(False, *) Change-Id: I335e5f542861c31ee5fa75953926e97701e50c77 Story: #2003776 Task: #26469 Notes (review): Code-Review+2: Kaifeng Wang <kaifeng.w@gmail.com> Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com> Workflow+1: Dmitry Tantsur <divius.inside@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 17 Sep 2018 12:25:41 +0000 Reviewed-on: https://review.openstack.org/602582 Project: openstack/ironic-inspector Branch: refs/heads/master