These are detected as errors since the clean up was done[1] in
the requirements repository.
[1] 314734e938f107cbd5ebcc7af4d9167c11347406
Also remove the note about old pip's behavior because the resolver
in recent pip no longer requires specific order.
Change-Id: Ie2f08726cfc764643a50777c552f95413eb67305
On ubuntu based systems calling these in opposite causes a
race condition where partitions aren't ready when we read/use them
Closes-Bug: 2050013
Change-Id: Ied7e4f17786dfc0e7f54962013e48ff96c5faa88
The tox deps option grants installation of single dependencies and
requirements, optionally pinned using constraints, before installing
a package, therefore not granting installation of the correct
constraint during the package installation.
To fix that tox 4.4.0 has introduced the constrain_package_deps
option [1]
[1] https://tox.wiki/en/4.12.1/faq.html#using-constraint-files
Change-Id: I14a93e67735df0f1b82dd687873ec77d8bfaac78
Adds a new module for two qemu-img wrappers that are used both by Ironic
and IPA. The remaining functions in disk_utils are only used by IPA and,
since most of them require root, can no longer be used in the
post-rootwrap Ironic any more. They should be moved to IPA eventually.
Change-Id: I3364a58b52a3e57c2f52356a6496865b749e74a8
I'm not sure why we silence the exception, right now it causes us a very
hard to debug failure. No code in Ironic seems to rely on this behavior.
Change-Id: I3740b600c60ed1b39808d18af2b5074e7e07a149
Continuing the work of @JayF in other repos.
Adds a tox target for codespell, `tox -e codespell`. Can optionally
be run as `tox -e codespell -- -w` to get automatic spelling fixes
applied where appropriate. Adds small amounts of configuration to
setup.cfg, including an ignore list of words.
Related Bug: https://bugs.launchpad.net/ironic-python-agent/+bug/2047654
Change-Id: I284045ee9dfb51eee59a0442abda657c74abed05
Continuing work by @JayF in other ironic repos. Find that explanation below.
This fixes several spelling issues identified by codepsell.
Later changes in this chain will provide the codespell config used to
generate this, as well as adding this commit's SHA, once landed, to a
.git-blame-ignore-revs file to ensure it will not pollute git historys
for modern clients.
Related Bug: https://bugs.launchpad.net/ironic-python-agent/+bug/2047654
Change-Id: I38ad9c46add87b0e67c912f2920f76ea7d0c3b80
We should breadcrumb the operator into what this message means -- right
now, it looks like a programming error when in most cases this is a
configuration error.
Related-bug: 2047709
Change-Id: Ica627834f799cffbf283ee01a2b2482a607c316d
From Zeroconf CHANGELOG.md:
v0.129.0 (2023-12-13)
Feature
* Add decoded_properties method to ServiceInfo
https://github.com/python-zeroconf/python-zeroconf/issues/13329b595a1dca
* Ensure ServiceInfo.properties always returns bytes
https://github.com/python-zeroconf/python-zeroconf/issues/1333d29553ab7d
Technically breaking change
* `ServiceInfo.properties` always returns a dictionary with type
`dict[bytes, bytes | None]` instead of a mix `str` and `bytes`. It was
only possible to get a mixed dictionary if it was manually passed in
when `ServiceInfo` was constructed.
Co-Authored-By: Dmitry Tantsur <dtantsur@protonmail.com>
Change-Id: I7f1a0c3329e5f29ec3e274558e3681142cc2ef78
Listening on Unix sockets is helpful when the whole Ironic is behind
a reverse proxy, as it's the case in Bifrost and Metal3 with TLS on.
This change also extracts some common code to be reused in Ironic later.
Change-Id: I3488b9bb67470ce6d062187dc5e44852f6908493
This change makes ironic-lib consistent with ironic-python-agent
and diskimage-builder's defaults for ESP partition sizes.
The following fedora change lays out why this is a necessary
change: https://fedoraproject.org/wiki/Changes/BiggerESP
In summary, additional space is needed if OS driven firmware
flashing is going to take place, and unikernels + next generation
bootloaders are going to consume more space than the existing
grub loader has.
Change-Id: I4fc63c02bf57a08e75121cfa1fd35a56c0427553
Adds the capability for the topic to contain a port to which
the json rpc client will connect to. This allows for distinct
json-rpc targets to be configured in an environment.
Change-Id: I999316880639cd410543eb54475b0c647b35147b
Some tests tool and IDE may create a .local directory inside the repo
with virtualenvs for dependencies, other tools may create . directories
or files for temporary reports.
While they can be removed in a second time, or configured differently,
it's advisable to just exclude all file starting with . from the
flake8 tests to avoid confusion and possible unexpected errors.
Change-Id: Iea00e194fbe9c89754fb0a65cdaaabdaad31e4cc
Use direct I/O when overwriting the partition table to expose device
failures (which would not be directly noticed otherwise).
Change-Id: Ib0790099d895410681e4a1679bedea62209ff277
Internally, if we want to re-use ironic-prometheus-exporter
*and* get useful metrics data out through it for ironic itself,
we need we need someway to collect and return metrics data.
Turns out, we did most of this for statsd ages ago, and we can
just reuse the framework.
Change-Id: I6060da4ab80c2e6d19d78b808216ae262edcc84c
Per ClarkB on the list, overriding install_command makes it more
difficult to troubleshoot behavior differences and failures.
Change-Id: I3fb6760bf4754bd1688db173037e55c238a0601e
Follow up to change: Iee5ac3a778f8106b7f2e96cd9294e2da28fe4def
Since Python version 2 is not supported we can remove these.
Change-Id: I79a4b189a7fb220a97d83601002339ebfae45104
UPPER_CONSTRAINTS_FILE is old name and deprecated
This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.
Change-Id: I7b79d0bc10c4c5c48e167e7042d383921feb1486
This is a follow-up for I143203be7827f73daba32e7c084c5807063ff91d
with minor fixes requested in the review.
Change-Id: I83a506b0a489efe56b4a11a954a76fe0783fa4ba