openstack
/
ironic-specs
Code Issues Proposed changes

Follow up of inspect wait state spec 

The comments raised at patch [1] needs to be addressed:

1. The document inconsistency about default value of
   ``[conductor]inspect_wait_timeout``.
2. The deprecation of returning ``INSPECTING`` from inspect_hardware
   of inspect interface.

[1] https://review.openstack.org/#/c/515657/

Change-Id: Idec0e7be483d9617318006a5592cbc0502eafaf2
Related-Bug: #1725211
This commit is contained in:
Kaifeng Wang 2018-03-16 22:05:09 +08:00
parent 774b01476c
commit c48069bea7
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
specs/approved/inspect-wait-state.rst
View File

@ -29,8 +29,11 @@ Let's therefore have a new passive state in the **ironic** state machine, the
For asynchronous inspection like ironic inspector driver, ironic conductor
will move node from ``manageable`` to ``inspecting`` state when an inspect
request is issued, then the ironic conductor moves node to ``inspect-wait``
state if ``InspectInterface.inspect_hardware`` returns ``INSPECTING``.
request is issued, then the ironic conductor moves node to ``inspect wait``
state if ``InspectInterface.inspect_hardware`` returns ``INSPECTING`` or
``INSPECTWAIT``. The behavior of returning ``INSPECTING`` will be
deprecated and logged as a warning. After deprecation period, returning
``INSPECTING`` will cause node be moved to ``inspect failed`` state.
Add a new option ``[conductor]inspect_wait_timeout`` to guard the
``inspect wait`` state, the default value is 1800 seconds as same as
@ -145,7 +148,7 @@ Other deployer impact
---------------------
Add a new option ``[conductor]inspect_wait_timeout`` to guard timeout of state
``inspecting``, defaults to 150 seconds.
``inspecting``, defaults to 1800 seconds.
Developer impact
----------------