openstack
/
keystone
Code Issues Proposed changes

Correct test_v3_oauth1.test_bad_authorizing_roles_name 

`test_bad_authorizing_roles_name` was incorrecting using .admin_request
instead of self.put. During the conversion to flask, this results in the
incorrect HTTP 404 (server text/html instead of application
(application/json); the incorrect behavior was due to dispatching to
and un-routed URI. In the legacy keystone wsgi, this was still handled
by the application and erroneously raised a 404 that looked correct.

The use of .put instead of .admin_request simply adds in the /v3 prefix
to the url returned by .authorize_request_token making the routing
now hit the proper controller method.

Change-Id: I1bdfbcaf1c3b6d0d86e2819b65d73af45bc7644d
This commit is contained in:
Morgan Fainberg 2018-06-01 19:00:33 -07:00
parent ccda249e4c
commit 90fa2757ca
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
keystone/tests/unit/test_v3_oauth1.py
View File

@ -899,8 +899,7 @@ class MaliciousOAuth1Tests(OAuth1Tests):
url = self._authorize_request_token(request_key)
body = {'roles': [{'name': 'fake_name'}]}
self.admin_request(path=url, method='PUT',
body=body, expected_status=http_client.NOT_FOUND)
self.put(path=url, body=body, expected_status=http_client.NOT_FOUND)
def test_no_authorizing_user_id(self):
consumer = self._create_single_consumer()