openstack
/
keystoneauth
Code Issues Proposed changes

Don't use mutable defaults in allow arguments 

Not sure how these got here, but they shouldn't stay.

Change-Id: Ib584b9e7201fd8afeb5779c64f8368f2df96bcbf
This commit is contained in:
Monty Taylor 2017-08-16 15:37:39 -05:00
parent e7578c0fe1
commit 2ef98f637e
No known key found for this signature in database
GPG Key ID: 7BAE94BC7141A594
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
keystoneauth1/adapter.py
View File

@ -91,7 +91,7 @@ class Adapter(object):
def __init__(self, session, service_type=None, service_name=None,
interface=None, region_name=None, endpoint_override=None,
version=None, auth=None, user_agent=None,
connect_retries=None, logger=None, allow={},
connect_retries=None, logger=None, allow=None,
additional_headers=None, client_name=None,
client_version=None, allow_version_hack=None,
global_request_id=None,

6
keystoneauth1/identity/base.py
View File

@ -157,7 +157,7 @@ class BaseIdentityPlugin(plugin.BaseAuthPlugin):
return False
def get_endpoint_data(self, session, service_type=None, interface=None,
region_name=None, service_name=None, allow={},
region_name=None, service_name=None, allow=None,
allow_version_hack=True, discover_versions=True,
skip_discovery=False, min_version=None,
max_version=None, endpoint_override=None, **kwargs):
@ -224,6 +224,8 @@ class BaseIdentityPlugin(plugin.BaseAuthPlugin):
:return: Valid EndpointData or None if not available.
:rtype: `keystoneauth1.discover.EndpointData` or None
"""
allow = allow or {}
min_version, max_version = discover._normalize_version_args(
None, min_version, max_version)
@ -303,7 +305,7 @@ class BaseIdentityPlugin(plugin.BaseAuthPlugin):
def get_endpoint(self, session, service_type=None, interface=None,
region_name=None, service_name=None, version=None,
allow={}, allow_version_hack=True,
allow=None, allow_version_hack=True,
skip_discovery=False,
min_version=None, max_version=None,
**kwargs):

2
keystoneauth1/session.py
View File

@ -471,7 +471,7 @@ class Session(object):
endpoint_filter=None, auth=None, requests_auth=None,
raise_exc=True, allow_reauth=True, log=True,
endpoint_override=None, connect_retries=0, logger=_logger,
allow={}, client_name=None, client_version=None,
allow=None, client_name=None, client_version=None,
microversion=None, microversion_service_type=None,
**kwargs):
"""Send an HTTP request with the specified characteristics.