openstack
/
kolla-ansible
Code Issues Proposed changes

Set "no_log" for "databases user and setting permissions" tasks 

At the moment the "databases user and setting permissions" task for
designate and nova leaks the database_password because of the use
of with_items:

---snip---
TASK [nova : Creating Nova databases user and setting permissions] *********************************************************
ok: [x -> y] => (item={u'database_password': u'password', u'database_name': u'nova', u'database_username': u'nova'})
ok: [x -> y] => (item={u'database_password': u'password', u'database_name': u'nova_cell0', u'database_username': u'nova'})
ok: [x -> y] => (item={u'database_password': u'password', u'database_name': u'nova_api', u'database_username': u'nova_api'})
---snap---

Change-Id: I141e4153223c8772c82a31d81e58057ce266c0b9
Co-authored-by: Bernd Müller <mueller@b1-systems.de>
This commit is contained in:
Christian Berendt 2018-10-31 17:22:19 +01:00
parent b5cf164cfb
commit 03788e17d4
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ansible/roles/designate/tasks/bootstrap.yml
View File

@ -41,6 +41,7 @@
database_password: "{{ designate_pool_manager_database_password }}"
when:
- not use_preconfigured_databases | bool
no_log: true
- include_tasks: bootstrap_service.yml
when: database.changed or use_preconfigured_databases | bool

1
ansible/roles/nova/tasks/bootstrap.yml
View File

@ -46,6 +46,7 @@
when:
- database.changed
- not use_preconfigured_databases | bool
no_log: true
- include_tasks: bootstrap_service.yml
when: database.changed or use_preconfigured_databases | bool