summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEduardo Gonzalez <dabarren@gmail.com>2018-02-25 12:02:00 +0100
committerEduardo Gonzalez <dabarren@gmail.com>2018-03-26 17:56:22 +0200
commitea1a1dee0d8b6d4ccba410984ebb4d071ca098ea (patch)
tree05c454ab0d82f44e97be28b6da40a44c4b53e85b
parent7851de5c3c579dc9012a1d6da1f6abe4fb6bec73 (diff)
Verify YAML syntax in gates
This patchset implements yamllint test to all *.yml files. Also fixes syntax errors to make jobs to pass. Change-Id: I3186adf9835b4d0cada272d156b17d1bc9c2b799
Notes
Notes (review): Code-Review+2: Jeffrey Zhang <jeffrey.zhang@99cloud.net> Code-Review+2: caoyuan <cao.yuan@99cloud.net> Workflow+1: caoyuan <cao.yuan@99cloud.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 27 Mar 2018 00:28:24 +0000 Reviewed-on: https://review.openstack.org/547817 Project: openstack/kolla-ansible Branch: refs/heads/master
-rw-r--r--.yamllint15
-rw-r--r--.zuul.yaml3
-rw-r--r--ansible/group_vars/all.yml30
-rw-r--r--ansible/kolla-host.yml1
-rw-r--r--ansible/roles/baremetal/tasks/post-install.yml2
-rw-r--r--ansible/roles/bifrost/tasks/config.yml2
-rw-r--r--ansible/roles/ceilometer/tasks/register.yml4
-rw-r--r--ansible/roles/chrony/tasks/config.yml1
-rw-r--r--ansible/roles/common/defaults/main.yml2
-rw-r--r--ansible/roles/designate/tasks/config.yml2
-rw-r--r--ansible/roles/destroy/tasks/cleanup_host.yml2
-rw-r--r--ansible/roles/glance/handlers/main.yml1
-rw-r--r--ansible/roles/glance/tasks/config.yml1
-rw-r--r--ansible/roles/haproxy/tasks/config.yml1
-rw-r--r--ansible/roles/horizon/tasks/config.yml3
-rw-r--r--ansible/roles/mariadb/tasks/recover_cluster.yml122
-rw-r--r--ansible/roles/memcached/tasks/config.yml1
-rw-r--r--ansible/roles/neutron/tasks/config-neutron-fake.yml1
-rw-r--r--ansible/roles/neutron/tasks/config.yml1
-rw-r--r--ansible/roles/nova/defaults/main.yml2
-rw-r--r--ansible/roles/nova/tasks/bootstrap_xenapi.yml1
-rw-r--r--ansible/roles/nova/tasks/config.yml1
-rw-r--r--ansible/roles/openvswitch/tasks/config.yml1
-rw-r--r--ansible/roles/ovs-dpdk/defaults/main.yml2
-rw-r--r--ansible/roles/ovs-dpdk/handlers/main.yml4
-rw-r--r--ansible/roles/ovs-dpdk/tasks/config.yml2
-rw-r--r--ansible/roles/ovs-dpdk/tasks/pull.yml1
-rw-r--r--ansible/roles/prechecks/tasks/database_checks.yml10
-rw-r--r--ansible/roles/prechecks/tasks/user_checks.yml4
-rw-r--r--ansible/roles/rabbitmq/tasks/config.yml8
-rw-r--r--ansible/roles/skydive/defaults/main.yml1
-rw-r--r--ansible/roles/skydive/handlers/main.yml1
-rw-r--r--ansible/roles/skydive/tasks/precheck.yml1
-rw-r--r--ansible/roles/stop/tasks/stop_containers.yml1
-rw-r--r--ansible/roles/vitrage/defaults/main.yml4
-rw-r--r--contrib/demos/magnum/redis-kube/redis-controller.yaml28
-rw-r--r--contrib/demos/magnum/redis-kube/redis-proxy.yaml10
-rw-r--r--contrib/demos/magnum/redis-kube/redis-sentinel-controller.yaml16
-rw-r--r--etc/kolla/passwords.yml2
-rw-r--r--releasenotes/notes/add-congress-877644b4b0e2ed0a.yaml6
-rw-r--r--releasenotes/notes/add-designate-producer-b6e94153ff9bc45c.yaml2
-rw-r--r--releasenotes/notes/add-watcher-a97995ace827cf71.yaml10
-rw-r--r--releasenotes/notes/congress-broken-cbf8ca59d90a85cb.yaml2
-rw-r--r--releasenotes/notes/deprecate-some-config-files-0ed8c75f6bb4aa26.yaml1
-rw-r--r--releasenotes/notes/enable-nfs-volume-snapshots-a0347a31662b1109.yaml2
-rw-r--r--releasenotes/notes/opendaylight-role-b1787bc458da5bc4.yaml2
-rw-r--r--releasenotes/notes/remove-nova-network-76e1c9b51a4acd5f.yaml1
-rw-r--r--tests/pre.yml1
-rw-r--r--tools/playbook-setup-nodes.yml10
-rw-r--r--tox.ini4
50 files changed, 169 insertions, 167 deletions
diff --git a/.yamllint b/.yamllint
new file mode 100644
index 0000000..8552861
--- /dev/null
+++ b/.yamllint
@@ -0,0 +1,15 @@
1extends: default
2ignore: |
3 .tox/
4
5rules:
6 line-length: disable
7 truthy: disable
8 braces:
9 max-spaces-inside: 1
10 comments:
11 # Ignore first space in comment because we set default options as:
12 #openstack_version: "pike"
13 require-starting-space: true
14 ignore: |
15 etc/kolla/globals.yml \ No newline at end of file
diff --git a/.zuul.yaml b/.zuul.yaml
index 268c880..7013c92 100644
--- a/.zuul.yaml
+++ b/.zuul.yaml
@@ -1,3 +1,4 @@
1---
1- project: 2- project:
2 check: 3 check:
3 jobs: 4 jobs:
@@ -72,7 +73,7 @@
72 vars: 73 vars:
73 scenario: aio 74 scenario: aio
74 roles: 75 roles:
75 - zuul: openstack-infra/zuul-jobs 76 - zuul: openstack-infra/zuul-jobs
76 77
77- job: 78- job:
78 name: kolla-ansible-centos-source 79 name: kolla-ansible-centos-source
diff --git a/ansible/group_vars/all.yml b/ansible/group_vars/all.yml
index 7bc5d64..1710940 100644
--- a/ansible/group_vars/all.yml
+++ b/ansible/group_vars/all.yml
@@ -62,7 +62,7 @@ container_proxy:
62 62
63# By default, Kolla API services bind to the network address assigned 63# By default, Kolla API services bind to the network address assigned
64# to the api_interface. Allow the bind address to be an override. 64# to the api_interface. Allow the bind address to be an override.
65api_interface_address: "{{ hostvars[inventory_hostname]['ansible_' + api_interface]['ipv4']['address'] }}" 65api_interface_address: "{{ hostvars[inventory_hostname]['ansible_' + api_interface]['ipv4']['address'] }}"
66 66
67################ 67################
68# Chrony options 68# Chrony options
@@ -98,14 +98,14 @@ docker_restart_policy_retry: "10"
98 98
99# Common options used throughout Docker 99# Common options used throughout Docker
100docker_common_options: 100docker_common_options:
101 auth_email: "{{ docker_registry_email }}" 101 auth_email: "{{ docker_registry_email }}"
102 auth_password: "{{ docker_registry_password }}" 102 auth_password: "{{ docker_registry_password }}"
103 auth_registry: "{{ docker_registry }}" 103 auth_registry: "{{ docker_registry }}"
104 auth_username: "{{ docker_registry_username }}" 104 auth_username: "{{ docker_registry_username }}"
105 environment: 105 environment:
106 KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}" 106 KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
107 restart_policy: "{{ docker_restart_policy }}" 107 restart_policy: "{{ docker_restart_policy }}"
108 restart_retries: "{{ docker_restart_policy_retry }}" 108 restart_retries: "{{ docker_restart_policy_retry }}"
109 109
110 110
111#################### 111####################
@@ -336,7 +336,7 @@ supported_policy_format_list:
336 336
337# In the context of multi-regions, list here the name of all your regions. 337# In the context of multi-regions, list here the name of all your regions.
338multiple_regions_names: 338multiple_regions_names:
339 - "{{ openstack_region_name }}" 339 - "{{ openstack_region_name }}"
340 340
341openstack_service_workers: "{{ [ansible_processor_vcpus, 5]|min }}" 341openstack_service_workers: "{{ [ansible_processor_vcpus, 5]|min }}"
342openstack_service_rpc_workers: "{{ [ansible_processor_vcpus, 3]|min }}" 342openstack_service_rpc_workers: "{{ [ansible_processor_vcpus, 3]|min }}"
@@ -350,11 +350,11 @@ nova_console: "novnc"
350# OpenStack authentication string. You should only need to override these if you 350# OpenStack authentication string. You should only need to override these if you
351# are changing the admin tenant/project or user. 351# are changing the admin tenant/project or user.
352openstack_auth: 352openstack_auth:
353 auth_url: "{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}" 353 auth_url: "{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"
354 username: "admin" 354 username: "admin"
355 password: "{{ keystone_admin_password }}" 355 password: "{{ keystone_admin_password }}"
356 project_name: "admin" 356 project_name: "admin"
357 domain_name: "default" 357 domain_name: "default"
358 358
359# Endpoint type used to connect with OpenStack services with ansible modules. 359# Endpoint type used to connect with OpenStack services with ansible modules.
360# Valid options are [ public, internal, admin ] 360# Valid options are [ public, internal, admin ]
diff --git a/ansible/kolla-host.yml b/ansible/kolla-host.yml
index 097b8de..4668f38 100644
--- a/ansible/kolla-host.yml
+++ b/ansible/kolla-host.yml
@@ -37,4 +37,3 @@
37 roles: 37 roles:
38 - { role: baremetal, 38 - { role: baremetal,
39 tags: baremetal } 39 tags: baremetal }
40
diff --git a/ansible/roles/baremetal/tasks/post-install.yml b/ansible/roles/baremetal/tasks/post-install.yml
index 2415064..04d44c3 100644
--- a/ansible/roles/baremetal/tasks/post-install.yml
+++ b/ansible/roles/baremetal/tasks/post-install.yml
@@ -93,7 +93,7 @@
93 - enable_host_ntp | bool 93 - enable_host_ntp | bool
94 94
95- name: Synchronizing time one-time 95- name: Synchronizing time one-time
96 command: ntpd -gq 96 command: ntpd -gq
97 become: True 97 become: True
98 when: enable_host_ntp | bool 98 when: enable_host_ntp | bool
99 99
diff --git a/ansible/roles/bifrost/tasks/config.yml b/ansible/roles/bifrost/tasks/config.yml
index 5fd4844..a3dd505 100644
--- a/ansible/roles/bifrost/tasks/config.yml
+++ b/ansible/roles/bifrost/tasks/config.yml
@@ -31,7 +31,7 @@
31 mode: "0660" 31 mode: "0660"
32 become: true 32 become: true
33 with_items: 33 with_items:
34 - "rabbitmq-env.conf" 34 - "rabbitmq-env.conf"
35 35
36- name: Template ssh keys 36- name: Template ssh keys
37 template: 37 template:
diff --git a/ansible/roles/ceilometer/tasks/register.yml b/ansible/roles/ceilometer/tasks/register.yml
index 0904cba..03dd658 100644
--- a/ansible/roles/ceilometer/tasks/register.yml
+++ b/ansible/roles/ceilometer/tasks/register.yml
@@ -11,7 +11,7 @@
11 auth: "{{ '{{ openstack_ceilometer_auth }}' }}" 11 auth: "{{ '{{ openstack_ceilometer_auth }}' }}"
12 endpoint_type: "{{ openstack_interface }}" 12 endpoint_type: "{{ openstack_interface }}"
13 module_extra_vars: 13 module_extra_vars:
14 openstack_ceilometer_auth: "{{ openstack_ceilometer_auth }}" 14 openstack_ceilometer_auth: "{{ openstack_ceilometer_auth }}"
15 run_once: True 15 run_once: True
16 16
17- name: Associate the ResellerAdmin role and ceilometer user 17- name: Associate the ResellerAdmin role and ceilometer user
@@ -25,6 +25,6 @@
25 auth: "{{ '{{ openstack_ceilometer_auth }}' }}" 25 auth: "{{ '{{ openstack_ceilometer_auth }}' }}"
26 endpoint_type: "{{ openstack_interface }}" 26 endpoint_type: "{{ openstack_interface }}"
27 module_extra_vars: 27 module_extra_vars:
28 openstack_ceilometer_auth: "{{ openstack_ceilometer_auth }}" 28 openstack_ceilometer_auth: "{{ openstack_ceilometer_auth }}"
29 when: enable_swift | bool 29 when: enable_swift | bool
30 run_once: True 30 run_once: True
diff --git a/ansible/roles/chrony/tasks/config.yml b/ansible/roles/chrony/tasks/config.yml
index 972b7ea..e19a55c 100644
--- a/ansible/roles/chrony/tasks/config.yml
+++ b/ansible/roles/chrony/tasks/config.yml
@@ -49,4 +49,3 @@
49 with_dict: "{{ chrony_services }}" 49 with_dict: "{{ chrony_services }}"
50 notify: 50 notify:
51 - Restart chrony container 51 - Restart chrony container
52
diff --git a/ansible/roles/common/defaults/main.yml b/ansible/roles/common/defaults/main.yml
index 82f6c1d..dec599c 100644
--- a/ansible/roles/common/defaults/main.yml
+++ b/ansible/roles/common/defaults/main.yml
@@ -28,7 +28,7 @@ common_services:
28 - "/dev/:/dev/" 28 - "/dev/:/dev/"
29 - "/run/:/run/:shared" 29 - "/run/:/run/:shared"
30 - "kolla_logs:/var/log/kolla/" 30 - "kolla_logs:/var/log/kolla/"
31# DUMMY_ENVIRONMENT is needed because empty environment is not supported 31 # DUMMY_ENVIRONMENT is needed because empty environment is not supported
32 cron: 32 cron:
33 container_name: cron 33 container_name: cron
34 enabled: True 34 enabled: True
diff --git a/ansible/roles/designate/tasks/config.yml b/ansible/roles/designate/tasks/config.yml
index a227da8..d1c3beb 100644
--- a/ansible/roles/designate/tasks/config.yml
+++ b/ansible/roles/designate/tasks/config.yml
@@ -79,7 +79,7 @@
79 vars: 79 vars:
80 service: "{{ designate_services['designate-worker'] }}" 80 service: "{{ designate_services['designate-worker'] }}"
81 template: 81 template:
82 src: "{{ item }}" 82 src: "{{ item }}"
83 dest: "{{ node_config_directory }}/designate-worker/pools.yaml" 83 dest: "{{ node_config_directory }}/designate-worker/pools.yaml"
84 mode: "0660" 84 mode: "0660"
85 become: true 85 become: true
diff --git a/ansible/roles/destroy/tasks/cleanup_host.yml b/ansible/roles/destroy/tasks/cleanup_host.yml
index 92248e7..e367910 100644
--- a/ansible/roles/destroy/tasks/cleanup_host.yml
+++ b/ansible/roles/destroy/tasks/cleanup_host.yml
@@ -1,7 +1,7 @@
1--- 1---
2- name: Destroying Kolla host configuration 2- name: Destroying Kolla host configuration
3 become: true 3 become: true
4 script: ../tools/cleanup-host 4 script: ../tools/cleanup-host
5 environment: 5 environment:
6 enable_haproxy: "{{ enable_haproxy }}" 6 enable_haproxy: "{{ enable_haproxy }}"
7 enable_swift: "{{ enable_swift }}" 7 enable_swift: "{{ enable_swift }}"
diff --git a/ansible/roles/glance/handlers/main.yml b/ansible/roles/glance/handlers/main.yml
index 39ea35a..c018ace 100644
--- a/ansible/roles/glance/handlers/main.yml
+++ b/ansible/roles/glance/handlers/main.yml
@@ -45,4 +45,3 @@
45 or glance_conf.changed | bool 45 or glance_conf.changed | bool
46 or policy_overwriting.changed | bool 46 or policy_overwriting.changed | bool
47 or glance_registry_container.changed | bool 47 or glance_registry_container.changed | bool
48
diff --git a/ansible/roles/glance/tasks/config.yml b/ansible/roles/glance/tasks/config.yml
index 39d4542..6015479 100644
--- a/ansible/roles/glance/tasks/config.yml
+++ b/ansible/roles/glance/tasks/config.yml
@@ -125,4 +125,3 @@
125 notify: 125 notify:
126 - Restart glance-api container 126 - Restart glance-api container
127 - Restart glance-registry container 127 - Restart glance-registry container
128
diff --git a/ansible/roles/haproxy/tasks/config.yml b/ansible/roles/haproxy/tasks/config.yml
index 51ddb5b..04c43bc 100644
--- a/ansible/roles/haproxy/tasks/config.yml
+++ b/ansible/roles/haproxy/tasks/config.yml
@@ -109,4 +109,3 @@
109 with_dict: "{{ haproxy_services }}" 109 with_dict: "{{ haproxy_services }}"
110 notify: 110 notify:
111 - "Restart {{ item.key }} container" 111 - "Restart {{ item.key }} container"
112
diff --git a/ansible/roles/horizon/tasks/config.yml b/ansible/roles/horizon/tasks/config.yml
index 5d0b77c..b78b327 100644
--- a/ansible/roles/horizon/tasks/config.yml
+++ b/ansible/roles/horizon/tasks/config.yml
@@ -13,7 +13,7 @@
13 with_dict: "{{ horizon_services }}" 13 with_dict: "{{ horizon_services }}"
14 14
15- set_fact: 15- set_fact:
16 custom_policy: [] 16 custom_policy: []
17 17
18- include: policy_item.yml 18- include: policy_item.yml
19 vars: 19 vars:
@@ -131,4 +131,3 @@
131 - horizon.enabled | bool 131 - horizon.enabled | bool
132 notify: 132 notify:
133 - Restart horizon container 133 - Restart horizon container
134
diff --git a/ansible/roles/mariadb/tasks/recover_cluster.yml b/ansible/roles/mariadb/tasks/recover_cluster.yml
index 5fda362..2258216 100644
--- a/ansible/roles/mariadb/tasks/recover_cluster.yml
+++ b/ansible/roles/mariadb/tasks/recover_cluster.yml
@@ -15,67 +15,67 @@
15 run_once: true 15 run_once: true
16 16
17- block: 17- block:
18 - name: Stop MariaDB containers 18 - name: Stop MariaDB containers
19 kolla_docker: 19 kolla_docker:
20 name: "{{ mariadb_service.container_name }}" 20 name: "{{ mariadb_service.container_name }}"
21 action: "stop_container" 21 action: "stop_container"
22 22
23 - name: Run MariaDB wsrep recovery 23 - name: Run MariaDB wsrep recovery
24 kolla_docker: 24 kolla_docker:
25 action: "start_container" 25 action: "start_container"
26 common_options: "{{ docker_common_options }}" 26 common_options: "{{ docker_common_options }}"
27 environment: 27 environment:
28 KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}" 28 KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
29 BOOTSTRAP_ARGS: "--wsrep-recover" 29 BOOTSTRAP_ARGS: "--wsrep-recover"
30 image: "{{ mariadb_service.image }}" 30 image: "{{ mariadb_service.image }}"
31 labels: 31 labels:
32 BOOTSTRAP: 32 BOOTSTRAP:
33 name: "{{ mariadb_service.container_name }}" 33 name: "{{ mariadb_service.container_name }}"
34 restart_policy: "never" 34 restart_policy: "never"
35 volumes: "{{ mariadb_service.volumes }}" 35 volumes: "{{ mariadb_service.volumes }}"
36 36
37 - name: Stop MariaDB containers 37 - name: Stop MariaDB containers
38 kolla_docker: 38 kolla_docker:
39 name: "{{ mariadb_service.container_name }}" 39 name: "{{ mariadb_service.container_name }}"
40 action: "stop_container" 40 action: "stop_container"
41 41
42 - name: Copying MariaDB log file to /tmp 42 - name: Copying MariaDB log file to /tmp
43 shell: "docker cp {{ mariadb_service.container_name }}:/var/log/kolla/mariadb/mariadb.log /tmp/mariadb_tmp.log" 43 shell: "docker cp {{ mariadb_service.container_name }}:/var/log/kolla/mariadb/mariadb.log /tmp/mariadb_tmp.log"
44 44
45 - name: Get MariaDB wsrep recovery seqno 45 - name: Get MariaDB wsrep recovery seqno
46 shell: "tail -n 200 /tmp/mariadb_tmp.log | grep Recovered | tail -1 | awk '{print $7}' | awk -F'\n' '{print $1}' | awk -F':' '{print $2}'" 46 shell: "tail -n 200 /tmp/mariadb_tmp.log | grep Recovered | tail -1 | awk '{print $7}' | awk -F'\n' '{print $1}' | awk -F':' '{print $2}'"
47 register: wsrep_recovery_seqno 47 register: wsrep_recovery_seqno
48 48
49 - name: Removing MariaDB log file from /tmp 49 - name: Removing MariaDB log file from /tmp
50 file: path=/tmp/mariadb_tmp.log state=absent 50 file: path=/tmp/mariadb_tmp.log state=absent
51 changed_when: false 51 changed_when: false
52 check_mode: no 52 check_mode: no
53 53
54 - name: Registering MariaDB seqno variable 54 - name: Registering MariaDB seqno variable
55 set_fact: 55 set_fact:
56 seqno: "{{ wsrep_recovery_seqno.stdout_lines[0] }}" 56 seqno: "{{ wsrep_recovery_seqno.stdout_lines[0] }}"
57 changed_when: false 57 changed_when: false
58 58
59 - name: Comparing seqno value on all mariadb hosts 59 - name: Comparing seqno value on all mariadb hosts
60 shell: 60 shell:
61 cmd: | 61 cmd: |
62 if [[ ! -z {{ hostvars[inventory_hostname]['seqno'] }} && ! -z {{ hostvars[item]['seqno'] }} && 62 if [[ ! -z {{ hostvars[inventory_hostname]['seqno'] }} && ! -z {{ hostvars[item]['seqno'] }} &&
63 {{ hostvars[inventory_hostname]['seqno'] }} =~ ^[0-9]+$ && {{ hostvars[item]['seqno'] }} =~ ^[0-9]+$ && 63 {{ hostvars[inventory_hostname]['seqno'] }} =~ ^[0-9]+$ && {{ hostvars[item]['seqno'] }} =~ ^[0-9]+$ &&
64 {{ hostvars[inventory_hostname]['seqno'] }} -lt {{ hostvars[item]['seqno'] }} ]]; then echo {{ hostvars[item]['seqno'] }}; fi 64 {{ hostvars[inventory_hostname]['seqno'] }} -lt {{ hostvars[item]['seqno'] }} ]]; then echo {{ hostvars[item]['seqno'] }}; fi
65 with_items: "{{ groups['mariadb'] }}" 65 with_items: "{{ groups['mariadb'] }}"
66 register: seqno_compare 66 register: seqno_compare
67 args: 67 args:
68 executable: /bin/bash 68 executable: /bin/bash
69 changed_when: false 69 changed_when: false
70 70
71 - name: Writing hostname of host with the largest seqno to temp file 71 - name: Writing hostname of host with the largest seqno to temp file
72 local_action: copy content={{ inventory_hostname }} dest=/tmp/kolla_mariadb_recover_inventory_name mode=0644 72 local_action: copy content={{ inventory_hostname }} dest=/tmp/kolla_mariadb_recover_inventory_name mode=0644
73 changed_when: false 73 changed_when: false
74 when: seqno_compare.results | map(attribute='stdout') | join('') == "" 74 when: seqno_compare.results | map(attribute='stdout') | join('') == ""
75 75
76 - name: Registering mariadb_recover_inventory_name from temp file 76 - name: Registering mariadb_recover_inventory_name from temp file
77 set_fact: 77 set_fact:
78 mariadb_recover_inventory_name: "{{ lookup('file', '/tmp/kolla_mariadb_recover_inventory_name') }}" 78 mariadb_recover_inventory_name: "{{ lookup('file', '/tmp/kolla_mariadb_recover_inventory_name') }}"
79 when: 79 when:
80 - mariadb_recover_inventory_name is not defined 80 - mariadb_recover_inventory_name is not defined
81 81
diff --git a/ansible/roles/memcached/tasks/config.yml b/ansible/roles/memcached/tasks/config.yml
index f69b7ad..2b6409d 100644
--- a/ansible/roles/memcached/tasks/config.yml
+++ b/ansible/roles/memcached/tasks/config.yml
@@ -37,4 +37,3 @@
37 - service.enabled | bool 37 - service.enabled | bool
38 - action != "config" 38 - action != "config"
39 notify: Restart memcached container 39 notify: Restart memcached container
40
diff --git a/ansible/roles/neutron/tasks/config-neutron-fake.yml b/ansible/roles/neutron/tasks/config-neutron-fake.yml
index 8577a16..c1cc895 100644
--- a/ansible/roles/neutron/tasks/config-neutron-fake.yml
+++ b/ansible/roles/neutron/tasks/config-neutron-fake.yml
@@ -86,4 +86,3 @@
86 group: "{{ config_owner_group }}" 86 group: "{{ config_owner_group }}"
87 when: inventory_hostname in groups['compute'] 87 when: inventory_hostname in groups['compute']
88 with_sequence: start=1 end={{ num_nova_fake_per_node }} 88 with_sequence: start=1 end={{ num_nova_fake_per_node }}
89
diff --git a/ansible/roles/neutron/tasks/config.yml b/ansible/roles/neutron/tasks/config.yml
index c7e6a54..f6b1bcb 100644
--- a/ansible/roles/neutron/tasks/config.yml
+++ b/ansible/roles/neutron/tasks/config.yml
@@ -436,4 +436,3 @@
436 with_dict: "{{ neutron_services }}" 436 with_dict: "{{ neutron_services }}"
437 notify: 437 notify:
438 - "Restart {{ item.key }} container" 438 - "Restart {{ item.key }} container"
439
diff --git a/ansible/roles/nova/defaults/main.yml b/ansible/roles/nova/defaults/main.yml
index aa33955..0e108f5 100644
--- a/ansible/roles/nova/defaults/main.yml
+++ b/ansible/roles/nova/defaults/main.yml
@@ -111,7 +111,7 @@ nova_services:
111 group: "compute" 111 group: "compute"
112 image: "{{ nova_compute_image_full }}" 112 image: "{{ nova_compute_image_full }}"
113 environment: 113 environment:
114 LIBGUESTFS_BACKEND: "direct" 114 LIBGUESTFS_BACKEND: "direct"
115 privileged: True 115 privileged: True
116 enabled: "{{ not enable_nova_fake | bool }}" 116 enabled: "{{ not enable_nova_fake | bool }}"
117 ipc_mode: "host" 117 ipc_mode: "host"
diff --git a/ansible/roles/nova/tasks/bootstrap_xenapi.yml b/ansible/roles/nova/tasks/bootstrap_xenapi.yml
index 7673463..f3a5e2f 100644
--- a/ansible/roles/nova/tasks/bootstrap_xenapi.yml
+++ b/ansible/roles/nova/tasks/bootstrap_xenapi.yml
@@ -1,3 +1,4 @@
1---
1- name: Install package python-os-xenapi 2- name: Install package python-os-xenapi
2 package: 3 package:
3 name: python-os-xenapi 4 name: python-os-xenapi
diff --git a/ansible/roles/nova/tasks/config.yml b/ansible/roles/nova/tasks/config.yml
index ad5b4f8..f528ebb 100644
--- a/ansible/roles/nova/tasks/config.yml
+++ b/ansible/roles/nova/tasks/config.yml
@@ -203,4 +203,3 @@
203 with_dict: "{{ nova_services }}" 203 with_dict: "{{ nova_services }}"
204 notify: 204 notify:
205 - "Restart {{ item.key }} container" 205 - "Restart {{ item.key }} container"
206
diff --git a/ansible/roles/openvswitch/tasks/config.yml b/ansible/roles/openvswitch/tasks/config.yml
index 4c1c1cc..551f3fa 100644
--- a/ansible/roles/openvswitch/tasks/config.yml
+++ b/ansible/roles/openvswitch/tasks/config.yml
@@ -70,4 +70,3 @@
70 with_dict: "{{ openvswitch_services }}" 70 with_dict: "{{ openvswitch_services }}"
71 notify: 71 notify:
72 - "Restart {{ item.key }} container" 72 - "Restart {{ item.key }} container"
73
diff --git a/ansible/roles/ovs-dpdk/defaults/main.yml b/ansible/roles/ovs-dpdk/defaults/main.yml
index 66feb52..8138ff6 100644
--- a/ansible/roles/ovs-dpdk/defaults/main.yml
+++ b/ansible/roles/ovs-dpdk/defaults/main.yml
@@ -50,7 +50,7 @@ ovsdpdk_services:
50#################### 50####################
51ovs_bridge_mappings: "{% for bridge in neutron_bridge_name.split(',') %}physnet{{ loop.index0 + 1 }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}" 51ovs_bridge_mappings: "{% for bridge in neutron_bridge_name.split(',') %}physnet{{ loop.index0 + 1 }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}"
52ovs_port_mappings: "{% for bridge in neutron_bridge_name.split(',') %} {{ neutron_external_interface.split(',')[loop.index0] }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}" 52ovs_port_mappings: "{% for bridge in neutron_bridge_name.split(',') %} {{ neutron_external_interface.split(',')[loop.index0] }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}"
53dpdk_tunnel_interface : "{{neutron_external_interface}}" 53dpdk_tunnel_interface: "{{neutron_external_interface}}"
54dpdk_tunnel_interface_address: "{{ hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['address'] }}" 54dpdk_tunnel_interface_address: "{{ hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['address'] }}"
55tunnel_interface_network: "{{ hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['network']}}/{{hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['netmask']}}" 55tunnel_interface_network: "{{ hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['network']}}/{{hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['netmask']}}"
56tunnel_interface_cidr: "{{dpdk_tunnel_interface_address}}/{{ tunnel_interface_network | ipaddr('prefix') }}" 56tunnel_interface_cidr: "{{dpdk_tunnel_interface_address}}/{{ tunnel_interface_network | ipaddr('prefix') }}"
diff --git a/ansible/roles/ovs-dpdk/handlers/main.yml b/ansible/roles/ovs-dpdk/handlers/main.yml
index 811db6d..3c58574 100644
--- a/ansible/roles/ovs-dpdk/handlers/main.yml
+++ b/ansible/roles/ovs-dpdk/handlers/main.yml
@@ -50,7 +50,7 @@
50 or inventory_hostname in groups['neutron-l3-agent'] 50 or inventory_hostname in groups['neutron-l3-agent']
51 or inventory_hostname in groups['neutron-metadata-agent'] 51 or inventory_hostname in groups['neutron-metadata-agent']
52 or inventory_hostname in groups['neutron-vpnaas-agent']) 52 or inventory_hostname in groups['neutron-vpnaas-agent'])
53 - ovs_physical_port_policy == 'indexed' 53 - ovs_physical_port_policy == 'indexed'
54 54
55- name: Restart ovsdpdk-vswitchd container 55- name: Restart ovsdpdk-vswitchd container
56 vars: 56 vars:
@@ -86,7 +86,7 @@
86 or inventory_hostname in groups['neutron-l3-agent'] 86 or inventory_hostname in groups['neutron-l3-agent']
87 or inventory_hostname in groups['neutron-metadata-agent'] 87 or inventory_hostname in groups['neutron-metadata-agent']
88 or inventory_hostname in groups['neutron-vpnaas-agent']) 88 or inventory_hostname in groups['neutron-vpnaas-agent'])
89 - ovs_physical_port_policy == 'named' 89 - ovs_physical_port_policy == 'named'
90 90
91- name: wait for dpdk tunnel ip 91- name: wait for dpdk tunnel ip
92 wait_for: 92 wait_for:
diff --git a/ansible/roles/ovs-dpdk/tasks/config.yml b/ansible/roles/ovs-dpdk/tasks/config.yml
index bfb7b15..89c6d68 100644
--- a/ansible/roles/ovs-dpdk/tasks/config.yml
+++ b/ansible/roles/ovs-dpdk/tasks/config.yml
@@ -19,7 +19,7 @@
19 - item.value.host_in_groups | bool 19 - item.value.host_in_groups | bool
20 with_dict: "{{ ovsdpdk_services }}" 20 with_dict: "{{ ovsdpdk_services }}"
21 notify: 21 notify:
22 - "Restart {{ item.key }} container" 22 - "Restart {{ item.key }} container"
23 23
24- name: Copying ovs-dpdkctl tool 24- name: Copying ovs-dpdkctl tool
25 copy: 25 copy:
diff --git a/ansible/roles/ovs-dpdk/tasks/pull.yml b/ansible/roles/ovs-dpdk/tasks/pull.yml
index 9341fcc..2ac1173 100644
--- a/ansible/roles/ovs-dpdk/tasks/pull.yml
+++ b/ansible/roles/ovs-dpdk/tasks/pull.yml
@@ -8,4 +8,3 @@
8 - item.value.enabled | bool 8 - item.value.enabled | bool
9 - item.value.host_in_groups | bool 9 - item.value.host_in_groups | bool
10 with_dict: "{{ ovsdpdk_services }}" 10 with_dict: "{{ ovsdpdk_services }}"
11
diff --git a/ansible/roles/prechecks/tasks/database_checks.yml b/ansible/roles/prechecks/tasks/database_checks.yml
index 883a462..0f53135 100644
--- a/ansible/roles/prechecks/tasks/database_checks.yml
+++ b/ansible/roles/prechecks/tasks/database_checks.yml
@@ -6,9 +6,9 @@
6 port: "{{ database_port }}" 6 port: "{{ database_port }}"
7 with_items: "{{ groups['mariadb'] }}" 7 with_items: "{{ groups['mariadb'] }}"
8 when: 8 when:
9 - not enable_mariadb | bool 9 - not enable_mariadb | bool
10 - enable_external_mariadb_load_balancer | bool 10 - enable_external_mariadb_load_balancer | bool
11 - inventory_hostname in groups['haproxy'] 11 - inventory_hostname in groups['haproxy']
12 12
13- name: "Check if external database address is reachable from all hosts" 13- name: "Check if external database address is reachable from all hosts"
14 wait_for: 14 wait_for:
@@ -16,5 +16,5 @@
16 host: "{{ database_address }}" 16 host: "{{ database_address }}"
17 port: "{{ database_port }}" 17 port: "{{ database_port }}"
18 when: 18 when:
19 - not enable_mariadb | bool 19 - not enable_mariadb | bool
20 - not enable_external_mariadb_load_balancer | bool 20 - not enable_external_mariadb_load_balancer | bool
diff --git a/ansible/roles/prechecks/tasks/user_checks.yml b/ansible/roles/prechecks/tasks/user_checks.yml
index faae3e4..fe8d4af 100644
--- a/ansible/roles/prechecks/tasks/user_checks.yml
+++ b/ansible/roles/prechecks/tasks/user_checks.yml
@@ -10,10 +10,8 @@
10 key: "{{ config_owner_group }}" 10 key: "{{ config_owner_group }}"
11 register: getent_group 11 register: getent_group
12 12
13#(duonghq) it's only a basic check, should be refined later 13# NOTE(duonghq): it's only a basic check, should be refined later
14- name: Check if ansible user can do passwordless sudo 14- name: Check if ansible user can do passwordless sudo
15 shell: sudo -n true 15 shell: sudo -n true
16 register: result 16 register: result
17 failed_when: result | failed 17 failed_when: result | failed
18
19
diff --git a/ansible/roles/rabbitmq/tasks/config.yml b/ansible/roles/rabbitmq/tasks/config.yml
index bc4f3ac..faa5115 100644
--- a/ansible/roles/rabbitmq/tasks/config.yml
+++ b/ansible/roles/rabbitmq/tasks/config.yml
@@ -39,10 +39,10 @@
39 - inventory_hostname in groups[service.group] 39 - inventory_hostname in groups[service.group]
40 - service.enabled | bool 40 - service.enabled | bool
41 with_items: 41 with_items:
42 - "rabbitmq-env.conf" 42 - "rabbitmq-env.conf"
43 - "rabbitmq.config" 43 - "rabbitmq.config"
44 - "rabbitmq-clusterer.config" 44 - "rabbitmq-clusterer.config"
45 - "definitions.json" 45 - "definitions.json"
46 notify: 46 notify:
47 - Restart rabbitmq container 47 - Restart rabbitmq container
48 48
diff --git a/ansible/roles/skydive/defaults/main.yml b/ansible/roles/skydive/defaults/main.yml
index b5e6f56..a30ca1a 100644
--- a/ansible/roles/skydive/defaults/main.yml
+++ b/ansible/roles/skydive/defaults/main.yml
@@ -34,4 +34,3 @@ skydive_analyzer_image_full: "{{ skydive_analyzer_image }}:{{ skydive_analyzer_t
34skydive_agent_image: "{{ docker_registry ~ '/' if docker_registry else '' }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-skydive-agent" 34skydive_agent_image: "{{ docker_registry ~ '/' if docker_registry else '' }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-skydive-agent"
35skydive_agent_tag: "{{ openstack_release }}" 35skydive_agent_tag: "{{ openstack_release }}"
36skydive_agent_image_full: "{{ skydive_agent_image }}:{{ skydive_agent_tag }}" 36skydive_agent_image_full: "{{ skydive_agent_image }}:{{ skydive_agent_tag }}"
37
diff --git a/ansible/roles/skydive/handlers/main.yml b/ansible/roles/skydive/handlers/main.yml
index 353f9e8..01466e0 100644
--- a/ansible/roles/skydive/handlers/main.yml
+++ b/ansible/roles/skydive/handlers/main.yml
@@ -41,4 +41,3 @@
41 - config_json.changed | bool 41 - config_json.changed | bool
42 or skydive_conf.changed |bool 42 or skydive_conf.changed |bool
43 or skydive_agent_container.changed | bool 43 or skydive_agent_container.changed | bool
44
diff --git a/ansible/roles/skydive/tasks/precheck.yml b/ansible/roles/skydive/tasks/precheck.yml
index e67c612..0f58c10 100644
--- a/ansible/roles/skydive/tasks/precheck.yml
+++ b/ansible/roles/skydive/tasks/precheck.yml
@@ -31,4 +31,3 @@
31 - container_facts['skydive_agent'] is not defined 31 - container_facts['skydive_agent'] is not defined
32 - inventory_hostname in groups[skydive_agent.group] 32 - inventory_hostname in groups[skydive_agent.group]
33 - skydive_agent.enabled | bool 33 - skydive_agent.enabled | bool
34
diff --git a/ansible/roles/stop/tasks/stop_containers.yml b/ansible/roles/stop/tasks/stop_containers.yml
index 7b679f8..df184d0 100644
--- a/ansible/roles/stop/tasks/stop_containers.yml
+++ b/ansible/roles/stop/tasks/stop_containers.yml
@@ -1,4 +1,3 @@
1--- 1---
2- name: Stopping Kolla containers 2- name: Stopping Kolla containers
3 command: /tmp/kolla-stop/tools/stop-containers 3 command: /tmp/kolla-stop/tools/stop-containers
4
diff --git a/ansible/roles/vitrage/defaults/main.yml b/ansible/roles/vitrage/defaults/main.yml
index eb0ba10..a5c8bd5 100644
--- a/ansible/roles/vitrage/defaults/main.yml
+++ b/ansible/roles/vitrage/defaults/main.yml
@@ -121,8 +121,8 @@ vitrage_datasource:
121 enabled: "{{ enable_cinder | bool }}" 121 enabled: "{{ enable_cinder | bool }}"
122 - name: "neutron.network,neutron.port" 122 - name: "neutron.network,neutron.port"
123 enabled: "{{ enable_neutron | bool }}" 123 enabled: "{{ enable_neutron | bool }}"
124#TODO(egonzalez) Heat cannot be used with default policy.json due stacks:global_index=rule:deny_everybody. 124 # TODO(egonzalez) Heat cannot be used with default policy.json due stacks:global_index=rule:deny_everybody.
125# Document process to deploy vitrage+heat. 125 # Document process to deploy vitrage+heat.
126 - name: "heat.stack" 126 - name: "heat.stack"
127 enabled: "no" 127 enabled: "no"
128 128
diff --git a/contrib/demos/magnum/redis-kube/redis-controller.yaml b/contrib/demos/magnum/redis-kube/redis-controller.yaml
index 11332e3..28efd31 100644
--- a/contrib/demos/magnum/redis-kube/redis-controller.yaml
+++ b/contrib/demos/magnum/redis-kube/redis-controller.yaml
@@ -4,7 +4,7 @@ kind: ReplicationController
4metadata: 4metadata:
5 name: redis 5 name: redis
6spec: 6spec:
7 replicas: 2 7 replicas: 2
8 selector: 8 selector:
9 name: redis 9 name: redis
10 template: 10 template:
@@ -13,16 +13,16 @@ spec:
13 name: redis 13 name: redis
14 spec: 14 spec:
15 containers: 15 containers:
16 - name: redis 16 - name: redis
17 image: kubernetes/redis:v1 17 image: kubernetes/redis:v1
18 ports: 18 ports:
19 - containerPort: 6379 19 - containerPort: 6379
20 resources: 20 resources:
21 limits: 21 limits:
22 cpu: "1" 22 cpu: "1"
23 volumeMounts: 23 volumeMounts:
24 - mountPath: /redis-master-data 24 - mountPath: /redis-master-data
25 name: data 25 name: data
26 volumes: 26 volumes:
27 - name: data 27 - name: data
28 emptyDir: {} 28 emptyDir: {}
diff --git a/contrib/demos/magnum/redis-kube/redis-proxy.yaml b/contrib/demos/magnum/redis-kube/redis-proxy.yaml
index 03262f8..07a2d34 100644
--- a/contrib/demos/magnum/redis-kube/redis-proxy.yaml
+++ b/contrib/demos/magnum/redis-kube/redis-proxy.yaml
@@ -8,8 +8,8 @@ metadata:
8 name: redis-proxy 8 name: redis-proxy
9spec: 9spec:
10 containers: 10 containers:
11 - name: proxy 11 - name: proxy
12 image: kubernetes/redis-proxy:v1 12 image: kubernetes/redis-proxy:v1
13 ports: 13 ports:
14 - containerPort: 6379 14 - containerPort: 6379
15 name: api 15 name: api
diff --git a/contrib/demos/magnum/redis-kube/redis-sentinel-controller.yaml b/contrib/demos/magnum/redis-kube/redis-sentinel-controller.yaml
index 65e514a..d8ae236 100644
--- a/contrib/demos/magnum/redis-kube/redis-sentinel-controller.yaml
+++ b/contrib/demos/magnum/redis-kube/redis-sentinel-controller.yaml
@@ -4,7 +4,7 @@ kind: ReplicationController
4metadata: 4metadata:
5 name: redis-sentinel 5 name: redis-sentinel
6spec: 6spec:
7 replicas: 2 7 replicas: 2
8 selector: 8 selector:
9 redis-sentinel: "true" 9 redis-sentinel: "true"
10 template: 10 template:
@@ -15,10 +15,10 @@ spec:
15 role: sentinel 15 role: sentinel
16 spec: 16 spec:
17 containers: 17 containers:
18 - name: sentinel 18 - name: sentinel
19 image: kubernetes/redis:v1 19 image: kubernetes/redis:v1
20 env: 20 env:
21 - name: SENTINEL 21 - name: SENTINEL
22 value: "true" 22 value: "true"
23 ports: 23 ports:
24 - containerPort: 26379 24 - containerPort: 26379
diff --git a/etc/kolla/passwords.yml b/etc/kolla/passwords.yml
index 9a59564..0094a15 100644
--- a/etc/kolla/passwords.yml
+++ b/etc/kolla/passwords.yml
@@ -179,7 +179,7 @@ vitrage_keystone_password:
179 179
180memcache_secret_key: 180memcache_secret_key:
181 181
182#HMAC secret key 182# HMAC secret key
183osprofiler_secret: 183osprofiler_secret:
184 184
185nova_ssh_key: 185nova_ssh_key:
diff --git a/releasenotes/notes/add-congress-877644b4b0e2ed0a.yaml b/releasenotes/notes/add-congress-877644b4b0e2ed0a.yaml
index 4a150d0..4e500c7 100644
--- a/releasenotes/notes/add-congress-877644b4b0e2ed0a.yaml
+++ b/releasenotes/notes/add-congress-877644b4b0e2ed0a.yaml
@@ -1,5 +1,5 @@
1--- 1---
2features: 2features:
3- Add ansible role for openstack congress project which provide 3 - Add ansible role for openstack congress project which provide
4 policy as a service across any collection of cloud services in 4 policy as a service across any collection of cloud services in
5 order to offer governance and compliance for dynamic infrastructures. 5 order to offer governance and compliance for dynamic infrastructures.
diff --git a/releasenotes/notes/add-designate-producer-b6e94153ff9bc45c.yaml b/releasenotes/notes/add-designate-producer-b6e94153ff9bc45c.yaml
index 27e8997..cd27145 100644
--- a/releasenotes/notes/add-designate-producer-b6e94153ff9bc45c.yaml
+++ b/releasenotes/notes/add-designate-producer-b6e94153ff9bc45c.yaml
@@ -1,3 +1,3 @@
1--- 1---
2features: 2features:
3 - Add designate-producer ansible role. Orchestrates periodic tasks that are run by designate. 3 - Add designate-producer ansible role. Orchestrates periodic tasks that are run by designate.
diff --git a/releasenotes/notes/add-watcher-a97995ace827cf71.yaml b/releasenotes/notes/add-watcher-a97995ace827cf71.yaml
index 4e081dd..3d4c173 100644
--- a/releasenotes/notes/add-watcher-a97995ace827cf71.yaml
+++ b/releasenotes/notes/add-watcher-a97995ace827cf71.yaml
@@ -1,6 +1,6 @@
1--- 1---
2 features: 2features:
3 - Introduce OpenStack Infrastructure Optimization 3 - Introduce OpenStack Infrastructure Optimization
4 service, also known as Watcher. This project makes 4 service, also known as Watcher. This project makes
5 use of Ceilometer data to rebalance the cloud to 5 use of Ceilometer data to rebalance the cloud to
6 meet declared goals and strategies. 6 meet declared goals and strategies.
diff --git a/releasenotes/notes/congress-broken-cbf8ca59d90a85cb.yaml b/releasenotes/notes/congress-broken-cbf8ca59d90a85cb.yaml
index 3172822..0109d8a 100644
--- a/releasenotes/notes/congress-broken-cbf8ca59d90a85cb.yaml
+++ b/releasenotes/notes/congress-broken-cbf8ca59d90a85cb.yaml
@@ -1,4 +1,4 @@
1--- 1---
2other: 2other:
3 - Congress doesn't work correctly out of the box and will 3 - Congress doesn't work correctly out of the box and will
4 not deploy. See Bug #1634641. 4 not deploy. See Bug https://bugs.launchpad.net/kolla-ansible/+bug/1634641.
diff --git a/releasenotes/notes/deprecate-some-config-files-0ed8c75f6bb4aa26.yaml b/releasenotes/notes/deprecate-some-config-files-0ed8c75f6bb4aa26.yaml
index 87883fb..94953ab 100644
--- a/releasenotes/notes/deprecate-some-config-files-0ed8c75f6bb4aa26.yaml
+++ b/releasenotes/notes/deprecate-some-config-files-0ed8c75f6bb4aa26.yaml
@@ -6,4 +6,3 @@ deprecations:
6 6
7 * /etc/kolla/config/database.conf 7 * /etc/kolla/config/database.conf
8 * /etc/kolla/config/messaging.conf 8 * /etc/kolla/config/messaging.conf
9
diff --git a/releasenotes/notes/enable-nfs-volume-snapshots-a0347a31662b1109.yaml b/releasenotes/notes/enable-nfs-volume-snapshots-a0347a31662b1109.yaml
index 7eea6d4..e6ef1d2 100644
--- a/releasenotes/notes/enable-nfs-volume-snapshots-a0347a31662b1109.yaml
+++ b/releasenotes/notes/enable-nfs-volume-snapshots-a0347a31662b1109.yaml
@@ -8,4 +8,4 @@ upgrade:
8 - | 8 - |
9 On upgrade NFS Cinder snapshots will be activated. One can 9 On upgrade NFS Cinder snapshots will be activated. One can
10 prohibit this by setting nfs_snapshot_support = False in 10 prohibit this by setting nfs_snapshot_support = False in
11 /etc/kolla/config/cinder/cinder-volume.conf, section '[nfs-1]'. \ No newline at end of file 11 /etc/kolla/config/cinder/cinder-volume.conf, section '[nfs-1]'.
diff --git a/releasenotes/notes/opendaylight-role-b1787bc458da5bc4.yaml b/releasenotes/notes/opendaylight-role-b1787bc458da5bc4.yaml
index b7c0ae0..c3686d7 100644
--- a/releasenotes/notes/opendaylight-role-b1787bc458da5bc4.yaml
+++ b/releasenotes/notes/opendaylight-role-b1787bc458da5bc4.yaml
@@ -1,3 +1,3 @@
1--- 1---
2features: 2features:
3 - Add OpenDaylight role \ No newline at end of file 3 - Add OpenDaylight role
diff --git a/releasenotes/notes/remove-nova-network-76e1c9b51a4acd5f.yaml b/releasenotes/notes/remove-nova-network-76e1c9b51a4acd5f.yaml
index 2e3d24c..b338853 100644
--- a/releasenotes/notes/remove-nova-network-76e1c9b51a4acd5f.yaml
+++ b/releasenotes/notes/remove-nova-network-76e1c9b51a4acd5f.yaml
@@ -2,4 +2,3 @@
2deprecations: 2deprecations:
3 - The nova-network was deprecated, we remove it from the nova ansible 3 - The nova-network was deprecated, we remove it from the nova ansible
4 role. 4 role.
5
diff --git a/tests/pre.yml b/tests/pre.yml
index 446575b..cbad56d 100644
--- a/tests/pre.yml
+++ b/tests/pre.yml
@@ -1,3 +1,4 @@
1---
1- hosts: all 2- hosts: all
2 vars: 3 vars:
3 logs_dir: "/tmp/logs" 4 logs_dir: "/tmp/logs"
diff --git a/tools/playbook-setup-nodes.yml b/tools/playbook-setup-nodes.yml
index cd765cf..7b05970 100644
--- a/tools/playbook-setup-nodes.yml
+++ b/tools/playbook-setup-nodes.yml
@@ -32,8 +32,8 @@
32 become: true 32 become: true
33 33
34 tasks: 34 tasks:
35 - name: Create log directory for node 35 - name: Create log directory for node
36 file: 36 file:
37 state: directory 37 state: directory
38 path: /tmp/{{ inventory_hostname }} 38 path: /tmp/{{ inventory_hostname }}
39 become: false 39 become: false
diff --git a/tox.ini b/tox.ini
index 254efcd..73ae651 100644
--- a/tox.ini
+++ b/tox.ini
@@ -30,11 +30,15 @@ setenv = VIRTUAL_ENV={envdir}
30commands = python setup.py testr --coverage --testr-args='{posargs}' 30commands = python setup.py testr --coverage --testr-args='{posargs}'
31 31
32[testenv:pep8] 32[testenv:pep8]
33deps =
34 {[testenv]deps}
35 yamllint
33commands = 36commands =
34 {toxinidir}/tools/run-bashate.sh 37 {toxinidir}/tools/run-bashate.sh
35 flake8 {posargs} 38 flake8 {posargs}
36 python {toxinidir}/tools/validate-all-file.py 39 python {toxinidir}/tools/validate-all-file.py
37 bandit -r ansible kolla_ansible tests tools 40 bandit -r ansible kolla_ansible tests tools
41 yamllint .
38 42
39[testenv:bandit] 43[testenv:bandit]
40commands = bandit -r ansible kolla_ansible tests tools 44commands = bandit -r ansible kolla_ansible tests tools