Commit Graph

16 Commits

Author SHA1 Message Date
Michal Nasiadka 448209459d CI: Add codespell to pep8
Fix existing spelling errors

Change-Id: Ie689cf5a344aaa630a4860448b09242333a8e119
2024-04-22 13:19:23 +00:00
Christian Berendt 89659b4607 ovs-dpdk: add ovs-dpdkctl.sh to the role itself
Currently the ovs-dpdkctl.sh file is present in the tools
directory and the "Copying ovs-dpdkctl tool" task accesses it.

This is bad practice. Files copied from a role should either be
referenced by an absolute path or be part of the role itself.

This change moves the ovs-dpdkctl.sh file in the files
directory of the role.

Change-Id: I01459d39207e54f270f32f37b4a5153c5a819347
2022-04-13 15:42:57 +00:00
Bernd Mueller 92f8daad52 added missing become in ovs-dpdk role
Signed-off-by: Bernd Mueller <mueller@b1-systems.de>
Change-Id: I90d98be9dfb14942ffb4f5293cf52a96a643ee90
2022-04-12 15:08:34 +02:00
Alexander Evseev 7f98238b64 Elevated privileges required to set owner/group/mode by ansible
Elevated (root) privileges are required to set owner/group/mode when
target owner does not math the user running Ansible. Without it the
playbook fails with 'Permission denied' error.

Change-Id: Ie7455a5f1ed709dfb9c9d7c653c6f808c00af4c2
2021-08-06 12:39:32 +00:00
Radosław Piliszek 3411b9e420 Performance: optimize genconfig
Config plays do not need to check containers. This avoids skipping
tasks during the genconfig action.

Ironic and Glance rolling upgrades are handled specially.

Swift and Bifrost do not use the handlers at all.

Partially-Implements: blueprint performance-improvements
Change-Id: I140bf71d62e8f0932c96270d1f08940a5ba4542a
2020-10-12 19:30:06 +02:00
Mark Goddard 9702d4c3c3 Performance: use import_tasks for check-containers.yml
Including tasks has a performance penalty when compared with importing
tasks. If the include has a condition associated with it, then the
overhead of the include may be lower than the overhead of skipping all
imported tasks. In the case of the check-containers.yml include, the
included file only has a single task, so the overhead of skipping this
task will not be greater than the overhead of the task import. It
therefore makes sense to switch to use import_tasks there.

Partially-Implements: blueprint performance-improvements

Change-Id: I65d911670649960708b9f6a4c110d1a7df1ad8f7
2020-07-28 12:10:59 +01:00
Kris Lindgren 2fe0d98ebb Add a job that *only* deploys updated containers
Sometimes as cloud admins, we want to only update code that is running
in a cloud.  But we dont need to do anything else.  Make an action in
kolla-ansible that allows us to do that.

Change-Id: I904f595c69f7276e71692696471e32fd1f88e6e8
Implements: blueprint deploy-containers-action
2019-09-26 17:51:14 +01:00
Mark Goddard de00bf491d Simplify handler conditionals
Currently, we have a lot of logic for checking if a handler should run,
depending on whether config files have changed and whether the
container configuration has changed. As rm_work pointed out during
the recent haproxy refactor, these conditionals are typically
unnecessary - we can rely on Ansible's handler notification system
to only trigger handlers when they need to run. This removes a lot
of error prone code.

This patch removes conditional handler logic for all services. It is
important to ensure that we no longer trigger handlers when unnecessary,
because without these checks in place it will trigger a restart of the
containers.

Implements: blueprint simplify-handlers

Change-Id: I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd
2019-06-27 15:57:19 +00:00
Mark Goddard a4bb8567da Fix up config file permissions on the host
Several config file permissions are incorrect on the host. In general,
files should be 0660, and directories and executables 0770.

Change-Id: Id276ac1864f280554e98b937f2845bb424d521de
Closes-Bug: #1821579
2019-04-02 17:23:31 +01:00
johjuhyun ff29284077 Nics for dpdk should be binded to proper dpdk driver
When deploying ovs-dpdk, if nics for dpdk are not binded
to dpdk driver (vfio/uio), dpdk port won't be created as
dpdk type. ("Error attaching device '%s' to DPDK")
Therefore, before creating bridge for ovs-dpdk, nics
should be binded to proper dpdk driver

Change-Id: I1154202c9cdb5947e7a1bb7f3b34ce5d1d4b9224
Closes-Bug: #1769289
Signed-off-by: johjuhyun <juhyun.joh@samsung.com>
2019-01-20 19:09:56 +09:00
Lakshmi Prasanna Goutham Pratapa 9f0db30fd1 Apply Resource-Constraints to all services.
This commit is the final commit to apply resource-constraints
to all OpenStack services.

Depends-on: I39004f54281f97d53dfa4b1dbcf248650ad6f186
Change-Id: I072d69be9698be54775cb0ae286ea2b6ed78776c
Implements: blueprint resource-constraints
2018-07-23 19:07:05 +05:30
Ha Manh Dong 30be04ea91 Specify 'become' for all tasks that use kolla_docker module
Add become to all tasks that use the module "kolla_docker"

Change-Id: I4309c4011687b88ec31d739fd8f834fe2326ff10
Partial-Implements: blueprint ansible-specific-task-become
2018-06-08 12:39:24 +00:00
Jeffrey Zhang c567055176 Fix ansible warning
- rename action and serial to kolla_ansible and kolla_serial
- use become instead of "sudo <command>" in shell
- Remove quota for failed_when and changed_when in rabbitmq tasks

Change-Id: I78cb60168aaa40bb6439198283546b7faf33917c
Implements: blueprint migrate-to-ansible-2-2-0
2018-05-11 02:54:02 +00:00
caoyuan d6a6486886 Add owner and group when create directories
Change-Id: Idb429823d48c4f40cf391151e8bb7478cc7d3631
2018-04-20 23:16:08 +08:00
Eduardo Gonzalez ea1a1dee0d Verify YAML syntax in gates
This patchset implements yamllint test to all *.yml
files.

Also fixes syntax errors to make jobs to pass.

Change-Id: I3186adf9835b4d0cada272d156b17d1bc9c2b799
2018-03-26 17:56:22 +02:00
Sean Mooney 781d84658d introduce playbook to ovs with dpdk
- This change creates a new role to
  support deploying ovs with dpdk.
- This change introduces an enable_ovs_dpdk
  variable to enable ovs with dpdk as part of
  the deploy action.
- This change extends the ovs-dpdkctl.sh tool
  to correctly deploy ovs-dpdk on Ubuntu and CentOS
  hosts.
- This change extends the cleanup-host tool
  to correctly uninstall ovs-dpdkctl.sh tool and its
  systemd files if present on the host.
- This change automatically configures userspace
  kernel drivers.

partial-implementes: bp/ovs-dpdk
Change-Id: I55858d81df437e8258705b75426f61ab9b907c7d
2017-08-09 18:43:06 +00:00