Fix pep8 tox job

pep8 was configured incorrectly in tox.ini and wasn't catching
violations. This commit fixes the job and the issues that got in while
the job was silently ignoring them.

Change-Id: Id4d1e3192c558edf3c4babae54c87c1ba10d617f
This commit is contained in:
Michał Dulko 2017-12-07 13:42:55 +01:00
parent b9cabcdbc8
commit ffbd59d792
5 changed files with 8 additions and 10 deletions

View File

@ -31,6 +31,6 @@ class BaseAdminKuryrTest(base.BaseAdminNetworkTest):
@classmethod
def resource_setup(cls):
super(BaseAdminKuryrTest, cls).resource_setup()
# TODO (dmellado): Config k8s client in a cleaner way
# TODO(dmellado): Config k8s client in a cleaner way
kubernetes.config.load_kube_config()
cls.k8s_client = kubernetes.client.CoreV1Api()

View File

@ -17,9 +17,9 @@ import time
from kubernetes import client as k8s_client
from kubernetes import config as k8s_config
from tempest.scenario import manager
from tempest.lib.common.utils import data_utils
from tempest import config
from tempest.lib.common.utils import data_utils
from tempest.scenario import manager
CONF = config.CONF
@ -41,7 +41,7 @@ class BaseKuryrScenarioTest(manager.NetworkScenarioTest):
def resource_setup(cls):
super(BaseKuryrScenarioTest, cls).resource_setup()
cls.pod_fips = []
# TODO (dmellado): Config k8s client in a cleaner way
# TODO(dmellado): Config k8s client in a cleaner way
k8s_config.load_kube_config()
@classmethod
@ -68,7 +68,7 @@ class BaseKuryrScenarioTest(manager.NetworkScenarioTest):
body=pod)
status = ""
while status != "Running":
# TODO (dmellado) add timeout config to tempest plugin
# TODO(dmellado) add timeout config to tempest plugin
time.sleep(1)
status = self.get_pod_status(name, namespace)

View File

@ -12,13 +12,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
import testtools
from oslo_log import log as logging
from tempest import config
from tempest.lib.common.utils import data_utils
from tempest.lib import decorators
from tempest.lib import exceptions
from tempest.lib.common.utils import data_utils
from kuryr_tempest_plugin.tests.scenario import base
@ -61,6 +59,7 @@ class TestCrossPingScenario(base.BaseKuryrScenarioTest):
'from host "%s" to "%s".' % (
fip['floating_ip_address'],
pod_fip['floatingip']['floating_ip_address']))
LOG.error(msg)
self.assertEqual('0', result.rstrip('\n'))
except exceptions.SSHExecCommandFailed:
LOG.error("Couldn't ping server")

View File

@ -14,8 +14,8 @@
from oslo_log import log as logging
from tempest.lib import decorators
from tempest.lib.common.utils import data_utils
from tempest.lib import decorators
from kuryr_tempest_plugin.tests import base

View File

@ -29,4 +29,3 @@ commands =
show-source = true
builtins = _
exclude=.venv,.git,.tox,dist,*lib/python*,*egg,tools,doc
select = E