summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSpyros Trigazis (strigazi) <strigazi@gmail.com>2017-06-01 12:20:26 +0000
committerSpyros Trigazis (strigazi) <strigazi@gmail.com>2017-06-06 09:15:47 +0000
commita9c642af0ce75c75a8d1439d63e2c803eaedcc2c (patch)
tree681e110bd0099a0b93db6714b02ba617fd2d7747
parent5fbf9e6c3fca5158f59f2aa48bdd48a77c718923 (diff)
Use eventlet executor in rpc_servicemitaka-eol
The default executor of o.m is 'blocking', but after change [1], o.m with blocking is broken. 'eventlet' and 'non-blocking' work fine and most services use 'eventlet', so this is why it was noticed by magnum which used the default one. Use eventlet to not be affected by bug #1694728 , but more importantly, the oslo team suggests to not use blocking which has 0% test coverage and it is going to be deprecated and unset from the default configuration. [1] https://review.openstack.org/#/c/463673/ Change-Id: I47da73787456c97f7d84fd4440404b551ff62528 Closes-Bug: #1694728 (cherry picked from commit bd69b3fff6b50048813360627fb02044cf1bcb58)
Notes
Notes (review): Code-Review+2: Adrian Otto <aotto@aotto.com> Code-Review+2: yatin <ykarel@redhat.com> Workflow+1: yatin <ykarel@redhat.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 07 Jun 2017 04:49:13 +0000 Reviewed-on: https://review.openstack.org/471277 Project: openstack/magnum Branch: refs/heads/stable/mitaka
-rw-r--r--magnum/common/rpc_service.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/magnum/common/rpc_service.py b/magnum/common/rpc_service.py
index 152f51b..bdadc19 100644
--- a/magnum/common/rpc_service.py
+++ b/magnum/common/rpc_service.py
@@ -66,6 +66,7 @@ class Service(service.Service):
66 # TODO(asalkeld) add support for version='x.y' 66 # TODO(asalkeld) add support for version='x.y'
67 target = messaging.Target(topic=topic, server=server) 67 target = messaging.Target(topic=topic, server=server)
68 self._server = messaging.get_rpc_server(transport, target, handlers, 68 self._server = messaging.get_rpc_server(transport, target, handlers,
69 executor='eventlet',
69 serializer=serializer) 70 serializer=serializer)
70 self.binary = binary 71 self.binary = binary
71 72