summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Bechtold <tbechtold@suse.com>2019-01-04 12:01:34 +0100
committerThomas Bechtold <tbechtold@suse.com>2019-01-04 12:01:34 +0100
commit49e68f84093bb0765f44523c9333d3d86178d49a (patch)
tree96b0dff6bc442e6f361e38863ded9e66bb4f79ce
parent7665ff44047fcc5df9fde749af6f38796ab36190 (diff)
devstack: Do a vgscan before checking if the VG is there
There might be a rescan for volume groups needed before checking if the volume group is already there. Otherwise, the check for the volume group fails which means the code tries to create the volume, but that fails then because the volume is already there. Here is the devstack run log: [...] plugin.sh:configure_backing_file:538 sudo losetup -f --show /opt/stack/data/lvm-shares-backing-file plugin.sh:configure_backing_file:538 DEV=/dev/loop2 plugin.sh:configure_backing_file:543 sudo vgs lvm-shares Volume group "lvm-shares" not found Cannot process volume group lvm-shares plugin.sh:configure_backing_file:543 sudo vgcreate lvm-shares /dev/loop2 Physical volume '/dev/loop2' is already in volume group 'lvm-shares' Unable to add physical volume '/dev/loop2' to volume group 'lvm-shares' /dev/loop2: physical volume not initialized. plugin.sh:configure_backing_file:1 exit_trap [...] Change-Id: I0189580ae40b180249fd5846aa986052e44ce2c2
Notes
Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Workflow+1: Goutham Pacha Ravi <gouthampravi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 04 Jan 2019 19:07:36 +0000 Reviewed-on: https://review.openstack.org/628399 Project: openstack/manila Branch: refs/heads/master
-rwxr-xr-xdevstack/plugin.sh1
1 files changed, 1 insertions, 0 deletions
diff --git a/devstack/plugin.sh b/devstack/plugin.sh
index 696fdea..c9117a3 100755
--- a/devstack/plugin.sh
+++ b/devstack/plugin.sh
@@ -530,6 +530,7 @@ function create_custom_share_types {
530 530
531# configure_backing_file - Set up backing file for LVM 531# configure_backing_file - Set up backing file for LVM
532function configure_backing_file { 532function configure_backing_file {
533 sudo vgscan
533 if ! sudo vgs $SHARE_GROUP; then 534 if ! sudo vgs $SHARE_GROUP; then
534 if [ "$CONFIGURE_BACKING_FILE" = "True" ]; then 535 if [ "$CONFIGURE_BACKING_FILE" = "True" ]; then
535 SHARE_BACKING_FILE=${SHARE_BACKING_FILE:-$DATA_DIR/${SHARE_GROUP}-backing-file} 536 SHARE_BACKING_FILE=${SHARE_BACKING_FILE:-$DATA_DIR/${SHARE_GROUP}-backing-file}