openstack
/
manila
Code Issues Proposed changes

[Trivialfix] Remove the useless parameter 'ext_mgr' 

The parameter 'ext_mgr' is not used in method _setup_routes() in
subclasses:
manila.api.v2/router.APIRouter
manila.api.v1.router.APIRouter
manila.api.versions.VersionsRouter
So it should be removed to make the code clean.

The superclass of them is manila.api.openstack.__init__.APIRouter,
the 'ext_mgr' is removed from method _setup_routers() in superclass.

In method__init__() in superclass, the _setup_routers() is called,
so 'ext_mgr'is removed in related calling statement.

Change-Id: I25e2d5447b328c88c660ae17025f65719290b21b
This commit is contained in:
zhiguo.li 2017-09-05 15:49:47 +08:00 committed by Tom Barron
parent a7cf5117bc
commit 83574cff43
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manila/api/openstack/__init__.py
View File

@ -70,7 +70,7 @@ class APIRouter(base_wsgi.Router):
mapper = ProjectMapper()
self.resources = {}
self._setup_routes(mapper, ext_mgr)
self._setup_routes(mapper)
self._setup_ext_routes(mapper, ext_mgr)
self._setup_extensions(ext_mgr)
super(APIRouter, self).__init__(mapper)
@ -115,5 +115,5 @@ class APIRouter(base_wsgi.Router):
resource.register_actions(controller)
resource.register_extensions(controller)
def _setup_routes(self, mapper, ext_mgr):
def _setup_routes(self, mapper):
raise NotImplementedError

2
manila/api/v1/router.py
View File

@ -48,7 +48,7 @@ class APIRouter(manila.api.openstack.APIRouter):
"""
ExtensionManager = extensions.ExtensionManager
def _setup_routes(self, mapper, ext_mgr):
def _setup_routes(self, mapper):
self.resources['versions'] = versions.create_resource()
mapper.connect("versions", "/",
controller=self.resources['versions'],

2
manila/api/v2/router.py
View File

@ -61,7 +61,7 @@ class APIRouter(manila.api.openstack.APIRouter):
"""
ExtensionManager = extensions.ExtensionManager
def _setup_routes(self, mapper, ext_mgr):
def _setup_routes(self, mapper):
self.resources["versions"] = versions.create_resource()
mapper.connect("versions", "/",
controller=self.resources["versions"],

2
manila/api/versions.py
View File

@ -64,7 +64,7 @@ class VersionsRouter(openstack.APIRouter):
ExtensionManager = extensions.ExtensionManager
def _setup_routes(self, mapper, ext_mgr):
def _setup_routes(self, mapper):
self.resources['versions'] = create_resource()
mapper.connect('versions', '/',
controller=self.resources['versions'],