openstack
/
manila
Code Issues Proposed changes

Merge "NetApp cDOT driver qos policy same name"

This commit is contained in:
Zuul 2018-08-08 13:11:54 +00:00 committed by Gerrit Code Review
parent 92021a8830 5da7d76d8a
commit e2d4e08324
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manila/share/drivers/netapp/dataontap/client/client_cmode.py
View File

@ -3770,6 +3770,8 @@ class NetAppCmodeClient(client_base.NetAppBaseClient):
@na_utils.trace
def qos_policy_group_rename(self, qos_policy_group_name, new_name):
"""Renames a QoS policy group."""
if qos_policy_group_name == new_name:
return
api_args = {
'policy-group-name': qos_policy_group_name,
'new-name': new_name,

9
manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py
View File

@ -6415,6 +6415,15 @@ class NetAppClientCmodeTestCase(test.TestCase):
self.client.send_request.assert_called_once_with(
'qos-policy-group-rename', qos_policy_group_rename_args, False)
def test_qos_policy_group_rename_noop(self):
self.mock_object(self.client, 'send_request')
# rename to same name = no-op
self.client.qos_policy_group_rename(
fake.QOS_POLICY_GROUP_NAME, fake.QOS_POLICY_GROUP_NAME)
self.assertFalse(self.client.send_request.called)
def test_mark_qos_policy_group_for_deletion_rename_failure(self):
self.mock_object(self.client, 'qos_policy_group_exists',
mock.Mock(return_value=True))