openstack
/
manila
Code Issues Proposed changes

[pylint] Use filenames in coding-checks 

When using the argument "all" in our pylint
script, we invoke tests against the whole tree.
This doesn't really work well with module names
since it ignores some submodules that are not
traversable from the main manila module.

By using filenames, we allow pylint to cover
all modules.

Change-Id: I37ea7f72e71ae93f8f654e0aa99744b2ecc1cea9
This commit is contained in:
Goutham Pacha Ravi 2019-02-19 23:11:29 -08:00
parent 10bd807423
commit f2a0410ebd
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/coding-checks.sh
View File

@ -32,8 +32,8 @@ run_pylint() {
CODE_OKAY=0
if [[ "$target" = *"all"* ]]; then
files="manila"
test_files="manila.tests"
files=$(find manila/ -type f -name "*.py" -and ! -path "manila/tests*")
test_files=$(find manila/tests/ -type f -name "*.py")
else
files=$(git diff --name-only --diff-filter=ACMRU HEAD~1 ':!manila/tests/*' '*.py')
test_files=$(git diff --name-only --diff-filter=ACMRU HEAD~1 'manila/tests/*.py')