Commit Graph

4 Commits

Author SHA1 Message Date
Tom Barron c22c073734 Impove coverage job accuracy
by informing it that we use eventlet for concurrency.

We have many false negative coverage runs, even for changes that
do not touch the code under test, for example in doc only change [1].
According to the coverage documentation, unless we indicate that
we are using an alternate to the thread library for concurrency
we will get "very wrong results." [2]

Set this option correctly.  Also avoid false precision in the
coverage report.

[1] http://logs.openstack.org/01/514901/2/check/openstack-tox-cover/6df6369/

[2] https://coverage.readthedocs.io/en/coverage-4.4.1/config.html

TrivialFix

Change-Id: I7398a45cdab8aa4191a55cbb86b9e6499b09f021
2017-10-25 11:57:46 -04:00
pawnesh.kumar 10429b2724 Update .coveragerc after the removal of openstack directory
The openstack directory was used to keep codes from oslo-incubator,
we have retired oslo-incubator,so don't use this directory any more.

Change-Id: I1e6d93e1bb91f4d82c4538b680141f51b8ddff27
2016-10-17 19:49:12 +05:30
Valeriy Ponomaryov 4778740261 Fix 'cover' tox job
Our 'cover' tox job does not work with release of 'coverage' package v4.0
It fails on option 'ignore-errors' in config section '[report]'.

So, replace usage of this option with CLI option '--ignore-errors'.

Change-Id: I404e3cb63453b0245ac05b4d3cb5780e5b8b7f9a
Closes-Bug: #1497897
2015-09-21 15:09:22 +03:00
Valeriy Ponomaryov 4ea9031b4f Make coverage tox job fail when test coverage was reduced
For the moment we can just calculate coverage and generate html with results.
It would be really useful to be able to get 'failure' by this job, when
latest commit introduced reduction of test coverage by any reason - either
addon of new code not covered with unit tests or deletion of existing unit
tests.
It will reduce total required efforts for code reviewers, that are forced now
to perform such check separately and inform about it committer.

Added file 'tools/cover.sh' is taken from OpenStack Rally project as
of state [1], with couple of fixes for satisfying 'bashate'.

Also add configuration file for coverage package.

[1] I7b4defe187c0631928d70bd09d7bcea956f4eed3

Change-Id: Ie0c5721985ae48256d9bb26af5fdb4b05797b359
2015-07-27 14:53:37 +03:00