Commit Graph

16 Commits

Author SHA1 Message Date
Anthony Lee a6d7e90714 Refactor HP 3PAR share driver to now be HPE
This patch refactors the HP share driver to now be
the HPE share driver.

This is being done because the company responsible for
this driver is now Hewlett Packard Enterprise (HPE).

The driver is now located in the manila/share/drivers/hpe
folder.

DocImpact
Implements: blueprint rebrand-hp-3par-share-driver
Change-Id: I36efc04fa6da088ccb06070d8cd4fe29269cd7ca
2015-11-16 12:56:36 -08:00
vponomaryov f38b8d4efd Fix broken unit tests
With release of six module version 1.10.0 several our unit tests
started to fail because of usage of not strict constructions.

Changes:
1) Manila unit test
"manila.tests.share.test_api.ShareAPITestCase.test_extend_quota_error"
used str for int substitution. So, use int data for int substitution.

2) Module 'manila.share.drivers.hp.hp_3par_mediator' was using
LOG.exception function when no traceback were exist it led to
AttributeError on py34. So, replace all usages of 'LOG.exception'
with 'LOG.error' where no raised exceptions exist.

Change-Id: Ic5b37bfb9d939d03f6ff68bc53d134bf9e5f996e
Closes-Bug: #1503969
2015-10-08 13:21:30 +03:00
Mark Sturdevant 4b12f9c8e7 HP 3PAR extra-spec prefix needs to be hp3par
The HP 3PAR share type extra-spec prefix needs
to be "hp3par". The decision to go with "hpe"
was premature and has been reversed. It needs
to be "hp3par" to be in sync with Cinder.

Change-Id: I616832c71d1797fc00da0d9e42c35c315381b6d9
Depends-On: I26dd32b1de8cceeaa6dc674092efec683df71889
Closes-bug: #1488662
2015-09-02 19:51:39 +00:00
Mark Sturdevant 7537951be6 HP 3PAR driver handles shares servers
HP 3PAR driver can use driver_handle_share_servers=True
mode to automatically setup the FSIP using the IP
address, subnet and VLAN tag obtained from the share
network.

The driver_handles_share_servers=False is still supported
with a pre-configured IP address.

Implements Blueprint: hp3par-share-server-support

Change-Id: Iae63a22923a5d7622a8810629071f5ea9823b0ed
2015-08-31 12:31:02 -07:00
Mark Sturdevant d7b1fb9b85 HP 3PAR add more info to the share comment
Put host and original name in comment to help
troubleshoot and clean up test systems.

Implements blueprint: hp3par-share-comment

Change-Id: Ibdbb561553086eeb6da4b94254b1d643b39b767a
2015-08-25 13:23:03 -07:00
Jenkins 8b7a3c876b Merge "HP 3PAR reports capabilities" 2015-08-25 19:03:59 +00:00
Mark Sturdevant 512e891f7b HP 3PAR reports capabilities
Report dedupe, thin_provisioning and hp3par_flash_cache
capabilities for 3PAR. Also report provisioned_capacity_gb
when thin_provisioning is True.

Implements Blueprint: hp3par-capabilities

Change-Id: I9dcba1bff5eba21b9b4b8cd4ed78beab75c2a8b6
2015-08-24 17:05:06 -07:00
Mark Sturdevant eaa2da7cbd Fix HP3PAR extra-specs scoping prefix bug
The recently added HP 3PAR extra-specs for create share options
use the wrong prefix for scoping. The prefix should not have used
an underscore in it. In addition, the underscore used in the docs
was different than in the code.

The new scoping prefix will be "hpe3par" (to be followed by a colon
for scoping or underscore for future capabilities).

Fixes Bug: #1481106

Change-Id: Ibd326fc367c1845e56706969daf01359fa7b2dac
2015-08-04 16:19:31 +00:00
Mark Sturdevant a9bee6e464 Fix HP3PAR SMB extra-specs for ABE and CA
Recently added HP3PAR extra-specs to set access-based enumeration
and continuous-availability on SMB shares is broken. The commands
to send to the array need to use -abe and -ca, but when the extra-spec
names were changed the command was broken.

Change-Id: If8306955c6ec8e7751d0740b0551d9cd3d3b755f
Closes-Bug: #1481096
2015-08-03 15:56:36 -07:00
Mark Sturdevant 8895ea2254 HP 3PAR uses scoped extra-specs to influence share creation options
Add support for share type extra-specs that can be used to influence
share creation options that are specific to 3PAR. These extra-specs
are scoped (use 'hp_3par:' prefix).

CIFS extra-specs include 'smb_abe' (access based enumeration),
'smb_cache' and 'smb_ca' (continuous availability). 'smb_ca' is
ignored until hp3parclient > 3.2.1.

The NFS extra-spec is 'nfs_options'. This value is a comma-separated
string as needed for the 3PAR createfshare -options value in the CLI.
The following values are not allowed because the driver uses
specific settings (for now): (no_)root_squash, (in)secure.
The following values are not allowed per HP 3PAR CLI support
requirements: no_subtree_check, fsid.
'rw' and 'ro' are not allowed because read-only access should be
controlled by Manila and not by extra-specs.
Additional value validation is left to the 3PAR CLI to handle.

Implements Blueprint: hp3par-extra-specs
Change-Id: Ia311cae718bf3998346b068aebb08a64924195de
2015-07-16 10:32:27 -07:00
Alex O'Rourke 2b7c63487d HP 3PAR driver config has unused username/password
Removed all references to hp3par_username and hp3par_password in the
code and documentation as it is currently not used.
Closes-Bug: 1463942

Change-Id: I4dd459077fdeb3387f08cfc0ea08948685e6f4cb
2015-06-19 09:57:18 -07:00
Mark Sturdevant 7c822401f6 HP 3PAR Add version checking and logging
Check for the minimum supported hp3parclient. The older ones are
not supported and this minimum fixes a bug.  Log the hp3parclient,
3PAR WSAPI and driver code versions as requested by support.

Change-Id: I32cff4c5d9f71a9d110a9b08f73e064c178c796a
Closes-Bug: #1463552
2015-06-15 11:13:10 -07:00
Julia Varlamova c8a06f808d Use oslo_log instead of oslo-incubator code
Code from manila/openstack/common/log.py duplicates code
from oslo_log, so we use oslo_log instead of oslo-incubator
log.py module.

Change-Id: I0e4c5833d20ce76a9cf7f2ed2293007d6048ff08
2015-04-21 13:04:45 +03:00
Mark Sturdevant b3aee0a201 HP 3PAR use one filestore per tenant
Using one filestore per tenant allows more shares to be
created on an array.  The original behavior of one filestore
per share can still be used with the hp3par_fstore_per_share=True
configuration (default is False).

Change-Id: I17a8ee138eef0157819ea33c74a43c30ee644817
Implements: blueprint hp3par-filestore-per-tenant
2015-03-02 15:02:01 -08:00
Mark Sturdevant 58858ec84e HP 3PAR driver fix for delete snapshot
Attempting to delete a CIFS snapshot raises an AttributeError
when attempting to split "shareDir" during dependent share
checking.  The split was made safe for an empty shareDir and
the path indexing was fixed in the dependent share checking.

Change-Id: Ieb745df6222817f6c459f62bac3fb66ecc576482
Closes-Bug: #1420055
2015-02-25 09:08:36 -08:00
Mark Sturdevant 2e709aa87d HP 3PAR Driver for Manila
Implement share driver for HP 3PAR arrays with File Persona capabilities.

NFS and CIFS shares can be created and deleted.
Snapshots can be created and deleted.
Read-only shares can be created from snapshots.

Does not support handling of share servers.

A pre-assigned IP address and a pre-configured VFS is used
instead of share networks.  This is done by setting 'hp3par_share_ip_address'
to the desired IP address in the manila.conf.

DocImpact

Change-Id: I90e19a1d34d568eba6178ca3dbb605f37c598439
Implements: blueprint hp3par-manila-driver
2015-02-07 02:10:26 -08:00