Make sure that all password options is defined with secret=True so that
the given values do not appear in debug logs.
Also remove the redundant default=None .
Change-Id: I989e825ef160a65a5a72c58d6fd4e8099044bcd5
The purpose of md5 was not specified.
Veritas drivers use mds hashes which pop on bandit as security issues
Putting "usedforsecurity=False" properly shows the hash function
is not use for security.
Change-Id: I78a5b708cd970dcb60f480d8e6a201d0768645fc
To appease Bandit, timeouts have to be
everywhere. So here are some timeouts
so Bandit stops crying.
Change-Id: I2a913f3b87e16554b1bd68543fcf254cc4226031
To appease Bandit since SHA1 angers
the beast, usedforsecurity=False will be
bolted to the hash function
Change-Id: I33bbb7070ada5509ca05c90d7a38077d38f54a1f
Bandit yelled at this use of urlopen
but the security issue it's worried about
does not apply in this case
Change-Id: Id71c0ee4138b695ff19085a284ccced6b1a9dbba
Replaces Huawei driver's use of Python's
native XML library methods with defusedxml's
methods instead. The native library is vulnerable
to XML attacks while defusedxml isn't. This also
makes Bandit 3 issues happier.
Change-Id: I27d1204ec7dafd3b578d1261c3fd2e371ae405fb
NetApp driver changes to accommodate human readable
share location. Export path is updated with
human frendly value if present else use share-id.
partially-implements: bp human-readable-export-locations
Depends-On: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883
Change-Id: I2f5bfdbc9d0458c7b9198a3eb94b3b095d5b5e04
A couple of releases ago, we started supporting clustered NFS
gateways [1], and we mentioned we had clear intentions to make
this the default choice for the deployments.
In this change, we are deprecating the NFSProtocolHelper, which
will be removed in the next skip-level release.
This means that Manila will no longer support exports created over
a NFS Ganesha instance that is not managed by the Ceph Cluster.
[1] https://review.opendev.org/c/openstack/manila/+/848987
Change-Id: I062a8c552d7d94e010cef6694bec6da68d7ea180
Implement the share backup feature for NetApp driver.
NetApp SnapVault technology is used to create and restore
the backup for NetApp ONTAP share. backup delete workflow
just delete the transferred snapshot from destination
backup volume.
Depends-On: Ifb88ec096674ea8bc010c1c3f6dea1b51be3beaa
Change-Id: I5a4edbf547e7886fb4fa9c1bed90110a33f9bf3b
Export locations are usually too difficult to memo
rize.Currently, there is no way to determine the
export location before the share is created, so
users wait until the share creation request gets
completed, and then they check the export
locations to mount the share. The generated
export locations are often not human readable
and it is hard to memorize and control them.
Implements: bp/human-readable-export-locations
Change-Id: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883
This feature was added and maintained by Cloudbase as part of effort to
support Windows-only OpenStack but Winstackers project was retired and
there seems to be no on requiring this deployment architecture now.
Because the driver hasn't been get any meaningful update for some time
and we no longer have Hyper-V CI active, this proposes deprecating
the driver so that we can retire it in 2024.2 at the earliest.
[1] d9c0bda0b7
Change-Id: Icec29f5512d4c4ce8c8d7ccb1f2d3823bffa7ed9
Make use of the `get_optional_share_creation_data` driver interface
to metadata in shares' created using the cephfs protocol.
Closes-Bug: #2050010
Change-Id: I91b51f974840f593334f2dcddfcfd45adfe87780
The driver was added in 2016, but it has had no 3rd party CI and it has
been untested. According to git log, the driver has not get any updates
specific to it.
Cinder already removed the Tegile driver[1] because of lack of CI.
[1] https://review.opendev.org/c/openstack/cinder/+/501333
Change-Id: I25a97ee23e5ce96ca0aec15941ad26763cd8cea0
CI of these drivers has been broken since migration to Ubuntu Jammy
and no one has shown interest to fix it so far.
Because these drivers haven't been update for some time, we can assume
these drivers are no longer used.
Related-Bug: #1998493
Change-Id: I9df5b7289dcec3a0de321169e892512571e7c006
Conditionally Import Parakimo
Separate SSH functions into ssh_utils.py for safe conditional import.
Change-Id: Ia1a3ee69bef76b52e4e6df1e73488c018ac0f3c9
This removes support for using "vmax" backends, which was translated
to "powermax" backends. This behavior was expected to be removed during
Wallaby cycle.
Also replace the remaining reference to EMC VMAX.
Change-Id: Id1187a9a99d87abefe3549e70df768f41494145f
If share created from snapshot is deleted immediately after creation
and if clone split operation is in progress, then delete call fails.
Fix this issue by first stopping the clone split job and then continue
with deletion.
Closes-bug: #1960239
Change-Id: If9844b3da70cec427c6260ee239c8c6131ed77ed
Minor change to allow multiple data VIP addresses
to be specified in the `flashblade_data_vip` parameter.
Each data VIP will be used to define the file system
export address for shares created. The first address in
the list will be clasified as the Preferred export
address, but this is not enforced.
Change-Id: Ia3bfdd5ce1bfd31d10193d1f222bf27b38c8ef43
Pure uses the version number of the driver to identify which
customers are using which versions of OpenStack.
This will help granular analysis of which driver is being
used in each OpenStack version
Change-Id: If8d94ba3c20ea830f493fb8695f1f9cfe3f3140e
When dropping an export over DBUS, if there's a problem
with the removal, we can ignore the failure and move on.
If not, the share ends up in an "error_deleting" state.
There's not much that we can do here besides logging
the failure as an exception.
Change-Id: I73c2706c9d889f8d08057a543b2a963740bb3f33
Closes-Bug: #2035572
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
Network port host can be totally different than manila host,
So it's weird to force binding host to only manila host.
`service_network_host` allow we specify host for network ports
when `dhss` is True.
Change-Id: I3d9a3bbc81f18d60a0710d9336ad6f97176875be
Instead of using the identifier the migration methods are deriving
the vserver name from the share server id. This causes failure for
migrate a share server that had been migrated before.
Closes-bug: #2037109
Change-Id: Ida13bacab960761bb7cd0708017d864db0d7358f
When creating port bindings for ports inside Neutron, Manila
just uses the hostname using "socket.gethostname()" rather
than the one provided via CONF.host
The default behaviour of CONF.host is "socket.gethostname()"
anyways, so it should work just fine.
Closes-Bug: #2037580
Change-Id: I4181a6f1527c80bf356d6363300b2d420921e7fa
When creating a share using CIFS protocol users can face errors related
with incorrect credentials or insufficient privileges which have not been properly described by the exception error message.
This patch add a more clearer error message to address this kind of
error to the user.
Closes-Bug: #1900755
Change-Id: I589c218f2c1072e17e76a6a8d8d81541d5072ad1