By default, routes.mapper.Mapper.resource adds a bunch of formatted
routes that accept anything after a '.'. Our spec says only .xml
and .json are accepted so limit the formatting to those valuse.
This allows identifiers with a '.' in urls. A few tests were added
to the extensions test to prove that .xml and .json are stripped
but other values are not.
It is already modified in cinder [1].
[1] https://bugs.launchpad.net/cinder/+bug/1307956
Change-Id: I91d8aa967446b5d7ce52f1b245149304494777f3
Closes-bug: #1774353
Fix incorrect order assertEqual(observed, expected) as below.
assertEqual(observed, expected) => assertEqual(expected, observed)
Target of this patch:
manila/tests/api/*
Note:
I also fix following asserts aruond above fixed parts.
assertEqual(xx, True), assertEqual(True, xx) => assertTrue(xx)
As for assertFalse,
I do not convert assertEqual(xx, False) to assertFalse(xx)
because assertFalse(None) does not raise exception.
Change-Id: I8131946efef654235b5e32344b3f5e42ab3d3ced
Partial-Bug: #1259292
Remove the broken XML support presently available in Manila
in order to comply with the general direction among other
OpenStack projects to support JSON only.
Change-Id: Ibb542fa223f7f7d1bf95f3d1f568987ef839cd12
Closes-Bug: #1440782
Add share_type_access extension which introduces
the ability to manage share type access:
* Share types are public by default
* Private share types can be created by setting
the is_public boolean field to False at creation time.
* Access to a private share type can be controlled
by adding or removing a project from it.
* Private share types without projects are only visible
by users with the admin role/context.
Implementation details and unit tests were mostly adapted
from Cinder and Nova access extensions.
Implements bp private-share-types
Change-Id: I83ee57c6a516b5382d074c0082525ad7feadd59c
The oslo team is recommending everyone to switch to the
non-namespaced versions of libraries. Updating the hacking
rule to include a check to prevent oslo.* import from
creeping back in.
oslo.messaging is the only exception because this package doesn't
currently support non-namespaced imports.
Change-Id: I3987e651bc880c8ffa7c0105df0298679dcd3a43
Replace usage of deprecated jsonutils module from oslo-incubator
and use oslo.serialization instead.
A followup-patch will sync with oslo-incubator and remove
the jsonutils module from manila.
Partial-Bug: #1382189
Change-Id: Iafa5090fd0c960ae8e996229ea3352f890decc6c
Fix and enable hacking test:
H402: one line docstring needs punctuation.
Fix testsuite, the change for manila/tests/api/extensions/foxinsocks.py
needs corresponding changes.
Change-Id: I587cd6771787ca56b1410f86a6ec13380bcc206b
Moving file flags.py to manila/common/config.py,
replacing FLAGS by CONF. Rename modules fake_flags to conf_fixture,
test_flags to test_conf, declare_flags to declare_conf,
runtime_flags to runtime_conf like it was done in cinder, nova, glance etc.
Implement bp: use-oslo-conf
Change-Id: I38d869123e5e706d3b06f1844b97ead05e22668f
Goutham Pacha Ravi