Commit Graph

15 Commits

Author SHA1 Message Date
Jay Xu eb9e91e892 EMC VNX Manila Driver Refactoring
EMC VNX Manila driver refactoring targets to the following aspects:
1. Make the object-oriented storage object
2. Improve the unit test coverage

Change-Id: Ifbcad18fc00f9ed0d4f04efead30e8357d88a29f
Implements: blueprint emc-vnx-manila-driver-refactoring
2015-11-12 22:29:49 -05:00
Yusuke Hayashi 8ce1530e21 Fix order of arguments in assertEqual
Fix incorrect order assertEqual(observed, expected) as below.
  assertEqual(observed, expected) => assertEqual(expected, observed)

Target of this patch:
  manila/tests/share/*

Note:
I also fix following asserts around above fixed parts.
  assertEqual(xx, True), assertEqual(True, xx) => assertTrue(xx)

As for assertFalse,
I do not convert assertEqual(xx, False) to assertFalse(xx)
because assertFalse(None) does not raise exception.

Change-Id: I56688105ab3b77e4f71bde472763a9c02c43664b
Partial-Bug: #1259292
2015-10-04 03:43:17 +09:00
Sergey Vilgelm 087fa055b5 Fix missing value types for log message
This patch add missing value types for some log message of exception.

Change-Id: I661d597f5b87923078cdf1556d72b28e7fa18b5f
Closes-Bug: #1494574
2015-09-14 10:49:40 +03:00
Jenkins 5bde0ebdff Merge "Add retry logic when delete a NFS share in VNX" 2015-08-14 08:30:37 +00:00
peter_wang 8d15b99022 Add retry logic when delete a NFS share in VNX
Currently, if user try to delete several NFS shares on same VDM,

VNX backend would report: unable to acquire lock(s).

Use 'retry' logic to handle such kind of error.

Change-Id: I0dafbda265daf19de3d71ee91fc51fb62313e5ec
Closes-Bug: 1480856
2015-08-13 01:13:31 -04:00
Valeriy Ponomaryov ed6ed47202 Fix string/binary conversions for py34 compatibility
Default type of strings in py 2 and 3 are different. So, convert them
explicitly when it is needed for py 2/3 compatibility.

Partially-Implements: bp py3-compatibility
Change-Id: I9b2d7e97fdc7d073a16e729ce0e90b92281fdf8d
2015-08-07 15:33:36 +03:00
Jenkins e9db340379 Merge "EMC VNX: Fix the total capacity for dynamic Pool" 2015-07-14 11:11:27 +00:00
Jay Xu d32c1e5c70 EMC VNX: Fix the total capacity for dynamic Pool
For the pools that are not dynamic, the total capacity of the pool returns
as total size of all members of the pool; For the pools that are dynamic,
it returns the potential, maximum total size, in other words the total size
of all members plus the space available for the pool extension.

Change-Id: Ie093a9ebcda7ca77906efe3786ee585b836c6a52
Closes-bug: 1464136
2015-07-12 20:44:06 -04:00
peter_wang fb84f5d557 Add access-level support in VNX Manila driver
Manila framework adds a new blueprint to set access-level for a share so
that admin can grant read-only/read-write permission to specific share.
This fix is to implement access-level both for CIFS and NFS share
in VNX Manila driver.

Change-Id: Ib651300978c451ca9b0d4b768c1f06d44d51a951
Implements: bp emc-vnx-manila-driver-read-only-share
2015-07-10 18:51:34 -04:00
peter_wang 081f9226e4 Fix incompatiblity issue in VNX manila driver
When running Manila with VNX File OE 8.1.6 or later,
if user creates a NFS share in Manila, driver will
report nas command error when setting nfs permssion.

This fix will use updated nas command to resolve it.

Change-Id: I0550cdf01278fa4e9aeed7891152fed6dcc0eefc
Closes-Bug: #1465543
2015-06-16 17:13:31 -04:00
janonymous 7c4abe2fcc Replace it.next() with next(it) for py3 compat
The Python 2 next() method of iterators was renamed to __next__() on
Python 3. Use the builtin next() function instead which works on Python
2 and Python 3.
This patch was generated by the next operation of the sixer tool:
https://pypi.python.org/pypi/sixer

Change-Id: I13948f73f34c396c5cb4d55b636f12b96e62f9f9
Closes-Bug: #1464935
2015-06-14 14:38:04 +05:30
Jenkins 38687094a2 Merge "Clean up redundant code and nits from EMC VNX driver" 2015-04-27 16:35:30 +00:00
Jay Xu 4b509ee51c Clean up redundant code and nits from EMC VNX driver
* Adding _ for internal function
* Remove the non-used functions
* fix code style issues

Change-Id: I52202a8b2809f0feb9654facea5d5e29a172ce95
2015-04-27 02:27:27 +00:00
Jay Xu b9987e1250 Fix for the deletion of an error share server
Check if share server name is in the parameter server_details when tear down
the share server. If not, just simply return.

Change-Id: Iff85589e198c933b0af67e288ed688be6e1deb39
Closes-Bug: #1446109
2015-04-22 21:22:13 -04:00
Jay Xu 9dd4790f70 Use lib lxml for handling of XML request
Use the third-party library lxml to generate XML request to VNX array,
which replaces the built-in XML builder in the current driver.

Change-Id: Iaca29ef3860b63786d214b700330c374397831b9
Implements: blueprint emc-vnx-manila-driver-lxml-update
2015-04-20 17:31:40 -04:00