This commit does several things:
- Setup and run pylint directly rather than running through a script.
This allows the user to see what is happening while the user is running
through pylint.
- Allow the user to either run pylint on a particular changeset,
or the entire manila tree.
- Allow the user to run on a particular changeset. Using like HEAD~1,
etc.
- I disabled the tests that were reported by pylint.
The thought here would be go through the failures
and correct them.
- Update pylint to 2.1.1.
Change-Id: I398d1ba01a3fd7f1c86ad4065a7984d276f33383
Signed-off-by: Chuck Short <chucks@redhat.com>
Updates the pylint and lint jobs to run under python3 by
changing the target python and updating the version of
pylint used.
Change-Id: Ie0ac158674fb22054b80864d33d9d7ecc82e3b36
Closes-bug: #1673824
The newer version of six (1.4.1) provides six.StringIO
which is a fake file object for textual data. It's an
alias for cStringIO.StringIO, in python2 and io.StringIO
in Python3
Change-Id: I5f4af05eb0754d85a73068d5f6b285d4be07cdfc
Due to the hacking version update several pep8 checks where ignored
in the flakes8 section of the tox.ini. Removed ignored checks and fixed
appropriate pep8 issues.
The list of fixed issues:
- H105 Don't use author tags
- H238 Old style class declaration, use new style (inherit from `object`)
- H501 Do not use self.__dict__ for string formatting
Closes-Bug: 1530719
Change-Id: I890ba4c54b0da10060767620ff5ff7e480d79a9c
The program tools/lintstack.py which is executed by
tools/lintstack.sh when Jenkins runs, only tests for differences
in the output of pylint. Right now, there seems to be
17 errors/warnings that are being carried over from fix to fix,
with no difference between fixes, and so no failures in the
pylint Jenkins job.
It is really difficult to tell what the errors are, so this fix
allows developers determine what the errors are by running the
following command:
$ tox -e lint
A sample output of the command is available as an attachment
to the bug.
Change-Id: I88487829576d55d437b934e08571013b7a6e57cf
Signed-off-by: Luis Pabón <lpabon@redhat.com>
Closes-Bug: #1356588
Signed-off-by: Luis Pabón <lpabon@redhat.com>
six is the canonical compatibility library for supporting
Python 2 and 3 in a single codebase.
The urlparse module was removed in Python 3 and we should
use 'six.moves.urllib.parse' instead of 'urlparse' to make
code compatible with py 2 and 3 as well.
Partially-implements blueprint py3-compatibility
Change-Id: Ib27244d0583e81e307d5e4236cbf85d29566dde9
Fix and enable flake8 test H404:
H404 multi line docstring should start without a leading new line
Change-Id: I13dc13bb5e81d65300680df094cde538c7a6f6df
Partial-Bug: #1333290
'print' function is compatible with 2.x and 3.x python versions
Partially-implements blueprint py3-compatibility
Change-Id: Idea6704be7f49778ca9e99be5b7f449cb89f39dc
Chuck Short