summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
30 hoursMerge "[Unity] Shrink share in Unity driver."HEADmasterZuul
36 hoursFix service image boot issuesTom Barron
We are getting: 403 errors 'Only volume-backed servers are allowed for flavors with zero disk' on scenario tests. Appears to be due to this change [1] which just merged to nova master branch. Ubuntu bionic server doc says the root disk needs 1.5 GB so we are setting the flavor definition to require 2GB. [1] https://github.com/openstack/nova/commit/c8e65a5eb11515cfe70f8e6850b842cd594af6a5 Closes-bug: #1816050 Change-Id: Iba0a15b78bf75a04c1ac0e64e70634772b2dca5c Notes (review): Code-Review+2: Ben Swartzlander <ben@swartzlander.org> Code-Review+2: Tom Barron <tpb@dyncloud.net> Workflow+1: Tom Barron <tpb@dyncloud.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 15 Feb 2019 19:44:44 +0000 Reviewed-on: https://review.openstack.org/637176 Project: openstack/manila Branch: refs/heads/master
2 daysAdd api ref for access rule metadata featurezhongjun2
Partially-implements: bp metadata-for-access-rule Change-Id: Icbac8ec427e23f6a781a7d3e682fe4852fa16179 Notes (review): Code-Review+2: zhongjun <jun.zhongjun2@gmail.com> Code-Review+2: Tom Barron <tpb@dyncloud.net> Workflow+1: Tom Barron <tpb@dyncloud.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 15 Feb 2019 10:07:48 +0000 Reviewed-on: https://review.openstack.org/583091 Project: openstack/manila Branch: refs/heads/master
3 days[Unity] Shrink share in Unity driver.dingd
Change-Id: Iaa29088456e4dd46039511a2bf8bbf789ddd6e7f Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Workflow+1: Goutham Pacha Ravi <gouthampravi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 15 Feb 2019 23:12:00 +0000 Reviewed-on: https://review.openstack.org/632615 Project: openstack/manila Branch: refs/heads/master
5 daysBump timeout on dsvm jobsTom Barron
Many time out even when all tests are succeeding and we will save more resources not having to recheck than by keeping the timeout where it is. Change-Id: I2a84e7a1340ccccb79170196b810aeda7d12914d Notes (review): Code-Review+1: Victoria Martinez de la Cruz <victoria@redhat.com> Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Code-Review+2: Thomas Bechtold <tbechtold@suse.com> Workflow+1: Thomas Bechtold <tbechtold@suse.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 12 Feb 2019 23:24:32 +0000 Reviewed-on: https://review.openstack.org/635834 Project: openstack/manila Branch: refs/heads/master
9 daysAdd tripleo scenario004 job to experimental queuQuique Llorente
Now that we have a all-in-one CI for tripleo called standalone we can start to test that at manila in the experimental pipeline. Change-Id: Ic94ce9698e4926c428ecf63e862df5a3a34b1889 Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Workflow+1: Tom Barron <tpb@dyncloud.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 09 Feb 2019 12:58:03 +0000 Reviewed-on: https://review.openstack.org/634396 Project: openstack/manila Branch: refs/heads/master
10 daysMerge "Match job names in playbooks to their names"Zuul
2019-01-31Match job names in playbooks to their namesTom Barron
in .zuul.yaml. TrivialFix Change-Id: I9376bea74b54abcd36ff1124afb6dd733c183a72 Notes (review): Code-Review+2: Thomas Bechtold <tbechtold@suse.com> Code-Review+2: Rodrigo Barbieri <rodrigo.barbieri2010@gmail.com> Workflow+1: Rodrigo Barbieri <rodrigo.barbieri2010@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 07 Feb 2019 11:54:50 +0000 Reviewed-on: https://review.openstack.org/634298 Project: openstack/manila Branch: refs/heads/master
2019-01-31Address E0102 pylint errorsTom Barron
When pylint is run against manila codebase E0102 errors are reported in api code, however it is appropriate there to redefine methods like ``index`` and ``show`` in different microversion contexts. Add comments to inform pylint that these redefinitions are OK. Change-Id: I295e5b3332ce28811f92487cfafae06568d07871 Notes (review): Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Code-Review+2: Rodrigo Barbieri <rodrigo.barbieri2010@gmail.com> Workflow+1: Rodrigo Barbieri <rodrigo.barbieri2010@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 31 Jan 2019 19:41:21 +0000 Reviewed-on: https://review.openstack.org/634210 Project: openstack/manila Branch: refs/heads/master
2019-01-31Merge "Run cephfs jobs under py3"Zuul
2019-01-30[CI] Drop redundant if condition in the LVM job playbookGoutham Pacha Ravi
Was left over from a JJB template --> ZuulV3 conversion. TrivialFix Change-Id: I0bfdf91dfec397c0fd81e18a29f97ff4c0183205 Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Workflow+1: Tom Barron <tpb@dyncloud.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 30 Jan 2019 20:20:50 +0000 Reviewed-on: https://review.openstack.org/634014 Project: openstack/manila Branch: refs/heads/master
2019-01-30Merge "Fix pylint errors for ganesha manager"Zuul
2019-01-30Run cephfs jobs under py3Tom Barron
Change-Id: Ic9e04c6e8746ae9b017b0cf7a13763caf4e7b140 Notes (review): Code-Review+2: xing-yang <xingyang105@gmail.com> Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Workflow+1: Goutham Pacha Ravi <gouthampravi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 31 Jan 2019 13:56:14 +0000 Reviewed-on: https://review.openstack.org/632521 Project: openstack/manila Branch: refs/heads/master
2019-01-30Merge "Set mode for CephFS volumes and snapshots"Zuul
2019-01-29Fix pylint errors for ganesha managerTom Barron
Closes-bug: #1813800 Change-Id: Id9858f9e016cef2d82d19df24947ae07eba916da Notes (review): Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Code-Review+2: Amit Oren <aoren@infinidat.com> Workflow+1: Amit Oren <aoren@infinidat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 30 Jan 2019 13:37:02 +0000 Reviewed-on: https://review.openstack.org/633721 Project: openstack/manila Branch: refs/heads/master
2019-01-29Merge "Separate APIs for share & replica export locations"Zuul
2019-01-28Set mode for CephFS volumes and snapshotsTom Barron
Corresponding ceph_volume_client PR [1] [1] https://github.com/ceph/ceph/pull/24839 Depends-on: https://review.openstack.org/#/c/630221/ Change-Id: Iad78b8cc25c34d3675cd38ce9c757ad0e411b613 Notes (review): Code-Review+2: Amit Oren <aoren@infinidat.com> Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Workflow+1: Goutham Pacha Ravi <gouthampravi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 30 Jan 2019 03:51:33 +0000 Reviewed-on: https://review.openstack.org/614332 Project: openstack/manila Branch: refs/heads/master
2019-01-28Merge "speed up GET scheduler-stats/pools/detail"Zuul
2019-01-25Merge "Deprecated config option [DEFAUL]memcached_servers"Zuul
2019-01-25Merge "Deprecate [DEFAULT]/share_usage_size_audit_period"Zuul
2019-01-25Deprecated config option [DEFAUL]memcached_serversThomas Bechtold
The option is not used in the code so deprecate it and remove it in a later release. Change-Id: Ie607f263f5abc510134deda4b98cfd070b382687 Notes (review): Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Code-Review+2: Tom Barron <tpb@dyncloud.net> Workflow+1: Tom Barron <tpb@dyncloud.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 25 Jan 2019 14:10:58 +0000 Reviewed-on: https://review.openstack.org/632616 Project: openstack/manila Branch: refs/heads/master
2019-01-24Merge "Fix spurious pylint import errors for ddt and mock"Zuul
2019-01-24Merge "Configure per backend availability zones in devstack"Zuul
2019-01-24Deprecate [DEFAULT]/share_usage_size_audit_periodGoutham Pacha Ravi
This option is unused and is likely going to confuse deployers, especially when using the share usage size tracking feature with a similarly named option (share_usage_size_update_interval) [1]. We can remove this option in the Train release. Closes-Bug: #1813054 [1] https://review.openstack.org/#/c/465055/ Change-Id: Id4585fa887e5bdfd5743dad2c490392ba0401061 Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Code-Review+2: Thomas Bechtold <tbechtold@suse.com> Workflow+1: Thomas Bechtold <tbechtold@suse.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 25 Jan 2019 06:35:18 +0000 Reviewed-on: https://review.openstack.org/632799 Project: openstack/manila Branch: refs/heads/master
2019-01-24Fix spurious pylint import errors for ddt and mockTom Barron
Set dependencies correctly for pylint job in tox.ini so it does not report spurious E041 import errors on mock and ddt modules. Also fix a reference to Cinder instead of Manila in the pylint script. Closes-Bug: #1813156 Change-Id: Ib160caae57e41a4d45483ff4faa599143e694abc Notes (review): Code-Review+2: Rodrigo Barbieri <rodrigo.barbieri2010@gmail.com> Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Workflow+1: Goutham Pacha Ravi <gouthampravi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 24 Jan 2019 20:35:32 +0000 Reviewed-on: https://review.openstack.org/632992 Project: openstack/manila Branch: refs/heads/master
2019-01-24Merge "Allow configuration of a back end specific availability zone"Zuul
2019-01-24Merge "Drop [DEFAULT]root_helper config option"Zuul
2019-01-23Configure per backend availability zones in devstackGoutham Pacha Ravi
Every enabled backend gets assigned to its own AZ. Test cases in manila-tempest-plugin already exercise creating shares (and replicas) across AZs when multiple AZs are available. This is done for all back-end drivers that are not the Generic driver. Configuring backend AZ for each Generic driver based back end will require configuring Nova and Cinder in a similar fashion. Partially-implements: bp per-backend-availability-zones Depends-On: https://review.openstack.org/#/c/630886/ Depends-On: https://review.openstack.org/#/c/629958/ Change-Id: I1b6ff535a22f10e70d379377767c8ffac3ef5286 Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Code-Review+2: Thomas Bechtold <tbechtold@suse.com> Workflow+1: Thomas Bechtold <tbechtold@suse.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 24 Jan 2019 16:45:32 +0000 Reviewed-on: https://review.openstack.org/630039 Project: openstack/manila Branch: refs/heads/master
2019-01-23Allow configuration of a back end specific availability zoneGoutham Pacha Ravi
"storage_availability_zone" in the [DEFAULT] section of manila's configuration file has allowed deployers to configure and manage both service (scheduler, share manager) and storage system availability. However, quite often manila's services (api, scheduler, share and data managers) are run on a dedicated control plane that is a different failure domain from that of the storage that manila manages. Also, when using share replication, deployers would need to run multiple manila share manager services with different configuration files, each with their own "storage_availability_zone". To allow flexibility of separating service and storage availability zones, we introduce a new configuration option "backend_availability_zone" within the share driver/backend section. When this option is used, it will override the value of the "storage_availability_zone" from the [DEFAULT] section. Change-Id: Ice99a880dd7be7af94dea86b31a6db88be3d7d9b Implements: bp per-backend-availability-zones Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Code-Review+2: Thomas Bechtold <tbechtold@suse.com> Workflow+1: Thomas Bechtold <tbechtold@suse.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 24 Jan 2019 11:52:28 +0000 Reviewed-on: https://review.openstack.org/629958 Project: openstack/manila Branch: refs/heads/master
2019-01-23[Trivial fix] add missing ws seperator between wordszhufl
This is to add missing ws seperator between words. Change-Id: I314f8a2e8de4df2179504cfaee2c372c774d1f19 Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Workflow+1: Tom Barron <tpb@dyncloud.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 23 Jan 2019 13:42:40 +0000 Reviewed-on: https://review.openstack.org/632622 Project: openstack/manila Branch: refs/heads/master
2019-01-23Drop [DEFAULT]root_helper config optionThomas Bechtold
The option is not used anywhere in the codebase. Manila uses "sudo" together with "rootwrap". Change-Id: If276a1bac32f5273c433805263d507e2fc3b2f26 Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Workflow+1: Goutham Pacha Ravi <gouthampravi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 24 Jan 2019 00:52:45 +0000 Reviewed-on: https://review.openstack.org/632617 Project: openstack/manila Branch: refs/heads/master
2019-01-16[Unity] Revert to snapshot supportYong Huang
Implement revert to snapshot support for Dell EMC Unity driver. Change-Id: I3a4da4a506ae4c2dbcd97207121ce19ecfb98043 Implements: unity-revert-to-snapshot Notes (review): Code-Review+1: Ryan Liang <ryan.liang@emc.com> Code-Review+1: Yongjun Bai <baiyj666@gmail.com> Code-Review+2: Tom Barron <tpb@dyncloud.net> Code-Review+2: Amit Oren <aoren@infinidat.com> Workflow+1: Amit Oren <aoren@infinidat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 17 Jan 2019 11:15:19 +0000 Reviewed-on: https://review.openstack.org/630630 Project: openstack/manila Branch: refs/heads/master
2019-01-08Convert dummy job to py3Tom Barron
Install all python packages for python3 and run tempest with python 3. Change-Id: If25075933b0b07a12814fda44ef5139a40c78f67 Notes (review): Code-Review+2: xing-yang <xingyang105@gmail.com> Code-Review+2: Ben Swartzlander <ben@swartzlander.org> Workflow+1: Ben Swartzlander <ben@swartzlander.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 08 Jan 2019 23:26:42 +0000 Reviewed-on: https://review.openstack.org/629143 Project: openstack/manila Branch: refs/heads/master
2019-01-08Merge "Publish sample config file in the genconfig job"Zuul
2019-01-07Separate APIs for share & replica export locationsGoutham Pacha Ravi
Users of replicated shares expect to see primary export locations when viewing information regarding the share. Because we collate exports of all replicas within the export locations APIs, it becomes hard for users to discern which exports belong to the primary share. For secondary replicas, users would also need additional information (availability zone, state of the replication) to work with. Introduce micro-version 2.47 from which the export locations API (GET /v2/{tenant_id}/shares/{share_id}/export_locations) no longer provides export locations of non-active share replicas. A new API has been introduced to provide export location details for share replicas, both active and non-active. (GET /v2/{tenant_id}/share-replicas/{share_replica_id}/export-locations) The new API provides the replica's state and availability zone in addition to the export location information. APIImpact Implements: bp export-locations-az Change-Id: I0a1d9dd00b4c13ac01988e30ca2b7d7ce4a747d1 Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Code-Review+2: Thomas Bechtold <tbechtold@suse.com> Workflow+1: Thomas Bechtold <tbechtold@suse.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 29 Jan 2019 11:15:31 +0000 Reviewed-on: https://review.openstack.org/628069 Project: openstack/manila Branch: refs/heads/master
2019-01-05Set paramiko logging to DEBUG levelTom Barron
Connections to backends via paramiko often fail for obscure reasons. If the service log level is DEBUG, increase paramiko logging to DEBUG level as well so that we have more information when issues of this sort occur. Change-Id: I44d8902d58c2ad48b8a37dfbff96c5b9471651e4 Notes (review): Code-Review+2: Thomas Bechtold <tbechtold@suse.com> Code-Review+2: zhongjun <jun.zhongjun2@gmail.com> Code-Review+2: Rodrigo Barbieri <rodrigo.barbieri2010@gmail.com> Workflow+1: Goutham Pacha Ravi <gouthampravi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 05 Jan 2019 05:29:55 +0000 Reviewed-on: https://review.openstack.org/627853 Project: openstack/manila Branch: refs/heads/master
2019-01-05Change ssh_utils parameter to correctly send keepalive packetsTom Barron
The current implementation of ssh_utils never sends keepalive packets. In ssh_utils.SSHPool, the socket timeout parameter is set to None intending to keep ssh connections open. However, when the parameter is set to None, ssh_utils does not run the code to compare idle duration and keepalive interval. This patch reverts the socket timeout parameter to default (0.1 sec). The ssh_utils compares them every 0.1 seconds, and sends a keepalive packet if idle duration > keepalive interval (= self.conn_timeout). See cinder change: I8234083107207b9ebc0849947e8de92b5cf3e36e Change-Id: Ib13e5c6246412d667554cb0bd9c419b513af70c7 Related-Bug: #1673662 Notes (review): Code-Review+2: Rodrigo Barbieri <rodrigo.barbieri2010@gmail.com> Code-Review+2: Thomas Bechtold <tbechtold@suse.com> Workflow+1: Goutham Pacha Ravi <gouthampravi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 05 Jan 2019 03:10:47 +0000 Reviewed-on: https://review.openstack.org/627797 Project: openstack/manila Branch: refs/heads/master
2019-01-05Merge "Improve service instance module debug logging"Zuul
2019-01-04Merge "Move/Drop useless SQL related config options"Zuul
2019-01-04Merge "devstack: Do a vgscan before checking if the VG is there"Zuul
2019-01-04Merge "QNAP: Fix inconsistent cases while create/manage from snapshot"Zuul
2019-01-04Merge "Fix the misspelling of "except""Zuul
2019-01-04Merge "Add Ubuntu Bionic CephFS jobs"Zuul
2019-01-04devstack: Do a vgscan before checking if the VG is thereThomas Bechtold
There might be a rescan for volume groups needed before checking if the volume group is already there. Otherwise, the check for the volume group fails which means the code tries to create the volume, but that fails then because the volume is already there. Here is the devstack run log: [...] plugin.sh:configure_backing_file:538 sudo losetup -f --show /opt/stack/data/lvm-shares-backing-file plugin.sh:configure_backing_file:538 DEV=/dev/loop2 plugin.sh:configure_backing_file:543 sudo vgs lvm-shares Volume group "lvm-shares" not found Cannot process volume group lvm-shares plugin.sh:configure_backing_file:543 sudo vgcreate lvm-shares /dev/loop2 Physical volume '/dev/loop2' is already in volume group 'lvm-shares' Unable to add physical volume '/dev/loop2' to volume group 'lvm-shares' /dev/loop2: physical volume not initialized. plugin.sh:configure_backing_file:1 exit_trap [...] Change-Id: I0189580ae40b180249fd5846aa986052e44ce2c2 Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Workflow+1: Goutham Pacha Ravi <gouthampravi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 04 Jan 2019 19:07:36 +0000 Reviewed-on: https://review.openstack.org/628399 Project: openstack/manila Branch: refs/heads/master
2019-01-04QNAP: Fix inconsistent cases while create/manage from snapshotChris Yang
There are two situation may cause the size of share/snapshot managed by manila is inconsistent with the NAS backend. One is to create a share from snapshot. While the other one is to manage an existing snapshot. Change-Id: Iaef8d8cb4be0d8872a2796c0fc69279c14f15a80 Closes-Bug: #1810476 Notes (review): Code-Review+2: Thomas Bechtold <tbechtold@suse.com> Code-Review+2: Tom Barron <tpb@dyncloud.net> Workflow+1: Tom Barron <tpb@dyncloud.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 04 Jan 2019 16:55:03 +0000 Reviewed-on: https://review.openstack.org/628342 Project: openstack/manila Branch: refs/heads/master
2019-01-04Fix the misspelling of "except"lijunjie
Change-Id: I19a5b802faf88aeb522cf14f474d79d8e226ea34 Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Workflow+1: Tom Barron <tpb@dyncloud.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 04 Jan 2019 15:26:32 +0000 Reviewed-on: https://review.openstack.org/628375 Project: openstack/manila Branch: refs/heads/master
2019-01-04Merge "Drop trycmd() from manila/utils.py"Zuul
2019-01-04Publish sample config file in the genconfig jobGoutham Pacha Ravi
Add a post run to enable copying the sample file generated to zuul logs. Change-Id: Ifc1e71ce486ef9cefc07dbe9fb7c78ce150317bd Notes (review): Code-Review+2: Tom Barron <tpb@dyncloud.net> Code-Review+2: Thomas Bechtold <tbechtold@suse.com> Workflow+1: Thomas Bechtold <tbechtold@suse.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 08 Jan 2019 11:37:41 +0000 Reviewed-on: https://review.openstack.org/628287 Project: openstack/manila Branch: refs/heads/master
2019-01-03Merge "QNAP: driver should not manage snapshot which does not exist"Zuul
2019-01-03Improve service instance module debug loggingTom Barron
Change-Id: Ib3a9bebe362609d7198e053afebc6004f3d94baf Notes (review): Code-Review+2: Goutham Pacha Ravi <gouthampravi@gmail.com> Workflow+1: Goutham Pacha Ravi <gouthampravi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 05 Jan 2019 00:47:56 +0000 Reviewed-on: https://review.openstack.org/627796 Project: openstack/manila Branch: refs/heads/master