Commit Graph

7 Commits

Author SHA1 Message Date
Takashi Kajinami 8ec4687566 [coordination] backend_url should be secret
The backend_url option can sometimes contain secrets.

For example when redis coordination backend is used and authentication
is enabled in redis, the plain redis password is put as an URL element.

[coordination]
backend_url=redis://:password@127.0.0.1:6379

Closes-Bug: #2012246
Change-Id: Ia815720cedda2f5c70205ffda5c765364cee8f8c
2023-03-20 18:37:48 +09:00
haixin 7f2b25332a remove usage of six library
remove usage of six library from the following directory:
1:share
2:volume
and some files.

Change-Id: If5bb2976bc54887c74649a00deaeaa71e296aaaa
2022-02-10 02:46:34 +00:00
junboli 97cfb648c4 Remove unused configuration options
Cleanup the deprecated configuration options, these options
are no longer used.

Change-Id: I4d475246b7ce12adbdbc4b7f65ce9aecd92c5fb5
2017-12-13 22:49:35 +08:00
Tom Barron a9d5d8301f Fix deprecated options version
When old coordination options were deprecated [1]
the wrong release version for manila Pike was used,
so fix this.

TrivialFix

[1] I86ef7a092a3ab7fd0a90ab664b7f9f62a275901b

Change-Id: I245ddd52894e37d9fd3c968e05550a2aa7fc2180
2017-07-19 08:12:55 -04:00
Tom Barron 326755f42c coordination: use tooz builtin heartbeat feature
Since a few versions, tooz can manage the heartbeat entirely
internally.

Use that feature and simplify the manila code.

See Cinder change [1].

Closes-Bug: #1691323

[1] I7fa654caf6620d410d4e297d3d8af2215e27ed12

Change-Id: I86ef7a092a3ab7fd0a90ab664b7f9f62a275901b
2017-05-17 10:38:53 +02:00
yfzhao 8dd6cd5850 Remove log translations in others 5/5
Log messages are no longer being translated. This removes all use of
the _LE, _LI, and _LW translation markers to simplify logging and to
avoid confusion with new contributions.
This is the 5/5 commit.
Old commit will be abandoned: https://review.openstack.org/#/c/447822/

See:
http://lists.openstack.org/pipermail/openstack-i18n/2016-November/002574.html
http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html

Change-Id: Ifebf6bf1ab8280c3ad3c573ae3772624bf47b461
Depends-On: I9fd264a443c634465b8548067f86ac14c1a51faa
Partial-Bug: #1674542
2017-04-08 02:19:02 +00:00
Goutham Pacha Ravi 02ab18c5df Tooz integration
Manila currently uses file locks from oslo_concurrency to
coordinate operations racing with each other to perform a
particular action. In many situations, deployers may need a
distributed lock to a local file lock (or even a file lock living on
a shared file system). This need is accentuated if they were running
Manila services in HA or if they were using Share Replication across
AZs where manila-share services were running off different controllers
that would not be able to share a common oslo_concurrency
file lock or be protected against service/lock management failures.

Integrate Tooz library with helper methods to create a locking
coordinator and allow deployers to make the choice between file
and distributed locks.

Start the manila share service with Tooz backed coordination.

Replace the locks used for Share Replication work-flows in the
share manager to use Tooz based locks.

Co-Authored-By: Goutham Pacha Ravi <gouthampravi@gmail.com>
Co-Authored-By: Szymon Wroblewski <szymon.wroblewski@intel.com>
Co-Authored-By: Tom Barron <tpb@dyncloud.net>

Related-Bug: #1585241
Partially-implements: bp distributed-locking-with-tooz
Change-Id: I710e86bd42034fa3b93b87ff77fa48ada8661168
2017-01-19 14:29:31 -05:00