If we are manually creating these things, we don't want any
automatically created. This is a latent issue that was being exposed by
SQLAlchemy 2.0's tweaked session management.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: I9d760ebbfcca176a39b44f20fb92e16eaf6284c5
This patch adds a delete cli command to ShareCommands
The helper CLI command checks if service if up. If service
is down, it deletes the share instance
Closes-Bug: #1867030
Change-Id: I6a0575c1ed86213010e50fe1b7a733cdf7fa1736
Thankfully the APIs being migrated here were _mostly_ sharing sessions
already, so we can simply migrate from public (decorated) methods to
private methods with minimal fuss.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: Id1b555e48106662d15e8c50567a5f3acecf6a8f1
Make use of the `get_optional_share_creation_data` driver interface
to metadata in shares' created using the cephfs protocol.
Closes-Bug: #2050010
Change-Id: I91b51f974840f593334f2dcddfcfd45adfe87780
The WalkVersionsMixin class was already removed from oslo.db, because
of removal of sqlalchemy-migrate support.
Change-Id: I952e0aed8705fd4fc0b89f6ee34f31da1b30c656
- A new config option named ``admin_metadata_keys`` was introduced
and we expect it to be set in the DEFAULT section of the manila
configuration file. It is expected that administrators will provide
a list of metadata keys that can only be updated by administrators
through this configuration option.
- Drivers will be able to set metadata while creating shares
through the `get_optional_share_creation_data` driver interface.
Closes-Bug: #2050010
Change-Id: I6412710c7db89747d23033e1a5a6be9de5886b0b
Ensure that an assert method is actually used when validating calls
in unit tests.
This also revealed an issue with the expected calls; query updated
to reflect the use of to domain attribute in the security context.
Change-Id: I7f71437330a23a2b5f178cf1980ba23260ea4a9b
Conditionally Import Parakimo
Separate SSH functions into ssh_utils.py for safe conditional import.
Change-Id: Ia1a3ee69bef76b52e4e6df1e73488c018ac0f3c9
In case of keystoneauth1 ConnectError, manila will retry the neutron
API call. For create_port(), it will make sure no duplicate ports
are created.
Closes-bug: #2049507
Change-Id: I12fece58671e9fb3705e22090187c42d9c3a74d9
This removes support for using "vmax" backends, which was translated
to "powermax" backends. This behavior was expected to be removed during
Wallaby cycle.
Also replace the remaining reference to EMC VMAX.
Change-Id: Id1187a9a99d87abefe3549e70df768f41494145f
This ensures api service dumps config options to debug logs when being
deployed as a wsgi app, so that users can review the effective values
and find misconfiguration more easily.
Closes-Bug: #2031480
Change-Id: I622fbae7fb273e7405a305cc3e33ac89c0564fdc
services are down
enhance the user message when all of the share
manager services are down or are still
initializing
removed a duplicate test: test_create_share_non_admin
Closes-Bug: #1886690
Change-Id: I168564a5b054d17762ad668ebbe4f5e7b562197b
If share created from snapshot is deleted immediately after creation
and if clone split operation is in progress, then delete call fails.
Fix this issue by first stopping the clone split job and then continue
with deletion.
Closes-bug: #1960239
Change-Id: If9844b3da70cec427c6260ee239c8c6131ed77ed
Minor change to allow multiple data VIP addresses
to be specified in the `flashblade_data_vip` parameter.
Each data VIP will be used to define the file system
export address for shares created. The first address in
the list will be clasified as the Preferred export
address, but this is not enforced.
Change-Id: Ia3bfdd5ce1bfd31d10193d1f222bf27b38c8ef43
"self" needs to be the first parameter; or pylint
complains.
Change-Id: I23b5c2c3f53c66e120fc852f50ad13e9c889c98c
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
We migrate both of these at the same time since a share replica is
effectively a share instance with only the 'replica_state' field set. As
such, they share many common DB APIs.
These are mostly trivial to migrate. Just a lot of refactoring to create
private methods, avoiding nested transactions.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: I267e2e0fac0b4130f8836de276082788fbd8d454
NetApp driver changes to accommodate human readable
share location. Export path is updated with
human frendly value if present else use share-id.
partially-implements: bp human-readable-export-locations
Depends-On: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883
Change-Id: I2f5bfdbc9d0458c7b9198a3eb94b3b095d5b5e04
Added new column named 'backup_type' in 'share_backups' table
and changes the share common api libs to support the dhss_true
configuration for share backup creation
Partially-implements: bp/share-backup
Change-Id: Ifb88ec096674ea8bc010c1c3f6dea1b51be3beaa
Implement the share backup feature for NetApp driver.
NetApp SnapVault technology is used to create and restore
the backup for NetApp ONTAP share. backup delete workflow
just delete the transferred snapshot from destination
backup volume.
Depends-On: Ifb88ec096674ea8bc010c1c3f6dea1b51be3beaa
Change-Id: I5a4edbf547e7886fb4fa9c1bed90110a33f9bf3b
In a replication setup, users encountered a critical
issue where they unintentionally reset the replica_state
of an active replica while attempting to resolve errors
on a non-active replica. This led to a situation with no
active replica, causing data loss. Users expected
server-side validation to prevent such actions.
This commit implements the necessary validation in the
codebase to ensure that the reset_replica_state action
cannot be applied to active replicas, addressing the
reported issue and improving data integrity in
replication setups.
Co-Authored-By: Solly <solobarine@gmail.com>
Closes-Bug: #2015328
Change-Id: I629669476e585a834673b8c8b49ad4b0270b877f
Zuul