Fix test method which has incorrect reference

test_add_host_to_aggregate is a test method to confirm the behavior of
masakari.compute.nova.API#add_host_to_aggregate method.

In this test method, add_host_to_aggregate method should be called with
'mock_aggregate' object, but as for now, it is called with
'mock_aggregates' object. In addition, add_host method in novaclient is
called with 'mock_aggregates.id'. This is wrong reference.

This patch fix that wrong reference in test_add_host_to_aggregate
method.

TrivialFix

Change-Id: I36b4ddad9286159ae752a2e482a82d4830a33a82
This commit is contained in:
Yukinori Sagara 2017-02-28 23:59:06 +09:00
parent 7415951c46
commit b71530559f
1 changed files with 5 additions and 2 deletions

View File

@ -251,10 +251,13 @@ class NovaApiTestCase(test.TestCase):
@mock.patch('masakari.compute.nova.novaclient')
def test_add_host_to_aggregate(self, mock_novaclient):
mock_aggregate = mock.MagicMock()
mock_aggregates = mock.MagicMock()
mock_aggregates.return_value = mock.MagicMock(
aggregate=mock_aggregate)
mock_novaclient.return_value = mock.MagicMock(
aggregates=mock_aggregates)
self.api.add_host_to_aggregate(self.ctx, 'fake_host', mock_aggregates)
self.api.add_host_to_aggregate(self.ctx, 'fake_host', mock_aggregate)
mock_novaclient.assert_called_once_with(self.ctx)
mock_aggregates.add_host.assert_called_once_with(
mock_aggregates.id, 'fake_host')
mock_aggregate.id, 'fake_host')