Implement policy in code - cron trigger (4)

This commit migrate all cron trigger policies into code [1].

Like oslo.config, with oslo.policy, we can define all of
default rules in code base and only change some rules
via policy file. Another thing that we should use yaml
format instead of json format.

[1] https://governance.openstack.org/tc/goals/queens/policy-in-code.html
Co-authored-By: Dai Dang-Van <daidv@vn.fujitsu.com>

Change-Id: Ib877e4ac6ebfe4068e85705955923d162757689f

etc/policy.json

@@ -1,12 +1,6 @@
 {
     "default": "rule:admin_or_owner",
 
-    "cron_triggers:create": "rule:admin_or_owner",
-    "cron_triggers:delete": "rule:admin_or_owner",
-    "cron_triggers:get": "rule:admin_or_owner",
-    "cron_triggers:list": "rule:admin_or_owner",
-    "cron_triggers:list:all_projects": "rule:admin_only",
-
     "environments:create": "rule:admin_or_owner",
     "environments:delete": "rule:admin_or_owner",
     "environments:get": "rule:admin_or_owner",

mistral/policies/__init__.py

@@ -17,11 +17,13 @@ import itertools
 from mistral.policies import action
 from mistral.policies import action_executions
 from mistral.policies import base
+from mistral.policies import cron_trigger
 
 
 def list_rules():
     return itertools.chain(
         action.list_rules(),
         action_executions.list_rules(),
-        base.list_rules()
+        base.list_rules(),
+        cron_trigger.list_rules()
     )

mistral/policies/cron_trigger.py

@@ -0,0 +1,80 @@
+# All Rights Reserved.
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+from oslo_policy import policy
+
+from mistral.policies import base
+
+CRON_TRIGGERS = 'cron_triggers:%s'
+
+rules = [
+    policy.DocumentedRuleDefault(
+        name=CRON_TRIGGERS % 'create',
+        check_str=base.RULE_ADMIN_OR_OWNER,
+        description='Creates a new cron trigger.',
+        operations=[
+            {
+                'path': '/v2/cron_triggers',
+                'method': 'POST'
+            }
+        ]
+    ),
+    policy.DocumentedRuleDefault(
+        name=CRON_TRIGGERS % 'delete',
+        check_str=base.RULE_ADMIN_OR_OWNER,
+        description='Delete cron trigger.',
+        operations=[
+            {
+                'path': '/v2/cron_triggers',
+                'method': 'DELETE'
+            }
+        ]
+    ),
+    policy.DocumentedRuleDefault(
+        name=CRON_TRIGGERS % 'get',
+        check_str=base.RULE_ADMIN_OR_OWNER,
+        description='Returns the named cron trigger.',
+        operations=[
+            {
+                'path': '/v2/cron_triggers/{cron_trigger_id}',
+                'method': 'GET'
+            }
+        ]
+    ),
+    policy.DocumentedRuleDefault(
+        name=CRON_TRIGGERS % 'list',
+        check_str=base.RULE_ADMIN_OR_OWNER,
+        description='Return all cron triggers.',
+        operations=[
+            {
+                'path': '/v2/cron_triggers',
+                'method': 'GET'
+            }
+        ]
+    ),
+    policy.DocumentedRuleDefault(
+        name=CRON_TRIGGERS % 'list:all_projects',
+        check_str=base.RULE_ADMIN_ONLY,
+        description='Return all cron triggers of all projects.',
+        operations=[
+            {
+                'path': '/v2/cron_triggers',
+                'method': 'GET'
+            }
+        ]
+    )
+]
+
+
+def list_rules():
+    return rules

mistral/tests/unit/fake_policy.py

@@ -15,11 +15,6 @@
 policy_data = """{
     "default": "rule:admin_or_owner",
 
-    "cron_triggers:create": "rule:admin_or_owner",
-    "cron_triggers:delete": "rule:admin_or_owner",
-    "cron_triggers:get": "rule:admin_or_owner",
-    "cron_triggers:list": "rule:admin_or_owner",
-
     "environments:create": "rule:admin_or_owner",
     "environments:delete": "rule:admin_or_owner",
     "environments:get": "rule:admin_or_owner",