openstack
/
mistral
Code Issues Proposed changes

Implement policy in code - action execution (2) 

This commit migrate all action execution policies into code [1].

Like oslo.config, with oslo.policy, we can define all of
default rules in code base and only change some rules
via policy file. Another thing that we should use yaml
format instead of json format.

[1] https://governance.openstack.org/tc/goals/queens/policy-in-code.html
Co-authored-By: Dai Dang-Van <daidv@vn.fujitsu.com>

Change-Id: Ic4b597995ae2ab49e793871c14060f0b9662f468
This commit is contained in:
Hieu LE 2017-10-11 14:54:16 +07:00 committed by Dai Dang Van
parent 49ed570cfe
commit 33407d6f44
4 changed files with 82 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
etc/policy.json
View File

@ -1,12 +1,6 @@
{
"default": "rule:admin_or_owner",
"action_executions:delete": "rule:admin_or_owner",
"action_execution:create": "rule:admin_or_owner",
"action_executions:get": "rule:admin_or_owner",
"action_executions:list": "rule:admin_or_owner",
"action_executions:update": "rule:admin_or_owner",
"actions:create": "rule:admin_or_owner",
"actions:delete": "rule:admin_or_owner",
"actions:get": "rule:admin_or_owner",

3
mistral/policies/__init__.py
View File

@ -12,13 +12,14 @@
# License for the specific language governing permissions and limitations
# under the License.
import itertools
from mistral.policies import action_executions
from mistral.policies import base
def list_rules():
return itertools.chain(
action_executions.list_rules(),
base.list_rules()
)

80
mistral/policies/action_executions.py Normal file
View File

@ -0,0 +1,80 @@
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from oslo_policy import policy
from mistral.policies import base
ACTION_EXECUTIONS = 'action_executions:%s'
rules = [
policy.DocumentedRuleDefault(
name=ACTION_EXECUTIONS % 'create',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Create new action execution.',
operations=[
{
'path': '/v2/action_executions',
'method': 'POST'
}
]
),
policy.DocumentedRuleDefault(
name=ACTION_EXECUTIONS % 'delete',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Delete the specified action execution.',
operations=[
{
'path': '/v2/action_executions',
'method': 'DELETE'
}
]
),
policy.DocumentedRuleDefault(
name=ACTION_EXECUTIONS % 'get',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Return the specified action execution.',
operations=[
{
'path': '/v2/action_executions/{action_execution_id}',
'method': 'GET'
}
]
),
policy.DocumentedRuleDefault(
name=ACTION_EXECUTIONS % 'list',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Return all tasks within the execution.',
operations=[
{
'path': '/v2/action_executions',
'method': 'GET'
}
]
),
policy.DocumentedRuleDefault(
name=ACTION_EXECUTIONS % 'update',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Update the specified action execution.',
operations=[
{
'path': '/v2/action_executions',
'method': 'PUT'
}
]
)
]
def list_rules():
return rules

6
mistral/tests/unit/fake_policy.py
View File

@ -15,12 +15,6 @@
policy_data = """{
"default": "rule:admin_or_owner",
"action_executions:delete": "rule:admin_or_owner",
"action_execution:create": "rule:admin_or_owner",
"action_executions:get": "rule:admin_or_owner",
"action_executions:list": "rule:admin_or_owner",
"action_executions:update": "rule:admin_or_owner",
"actions:create": "rule:admin_or_owner",
"actions:delete": "rule:admin_or_owner",
"actions:get": "rule:admin_or_owner",